Files
sure/test/models/sophtron_item_test.rb
Juan José Mata c92b984cef [codex] Add Sophtron manual sync fixes (#1714)
* Add manual Sophtron sync flow (#1705)

Branch-to-branch merge.

* Copy edits

* Make Sophtron manual sync institution scoped

* Populate Sophtron manual sync stats

* Restore Sophtron bank credential copy

* Address Sophtron manual sync review feedback

* Scope manual sync processing failure handling

* Hide raw Sophtron processor errors from flash

* Clear Sophtron manual sync pointers on provider errors

* Keep manual Sophtron MFA on manual sync records

* Preserve manual sync processing error details
2026-05-09 21:55:20 +02:00

219 lines
7.3 KiB
Ruby

require "test_helper"
class SophtronItemTest < ActiveSupport::TestCase
include ActiveJob::TestHelper
setup do
@family = families(:dylan_family)
@item = @family.sophtron_items.create!(
name: "Sophtron",
user_id: "developer-user",
access_key: Base64.strict_encode64("secret-key")
)
end
test "ensure_customer reuses persisted customer id" do
@item.update!(customer_id: "cust-existing")
provider = mock
provider.expects(:list_customers).never
assert_equal "cust-existing", @item.ensure_customer!(provider: provider)
end
test "ensure_customer reuses matching listed customer" do
provider = mock
provider.expects(:list_customers).returns([
{ CustomerID: "cust-1", CustomerName: @item.generated_customer_name }
])
provider.expects(:create_customer).never
assert_equal "cust-1", @item.ensure_customer!(provider: provider)
assert_equal "cust-1", @item.customer_id
assert_equal @item.generated_customer_name, @item.customer_name
end
test "ensure_customer creates customer when no matching customer exists" do
provider = mock
provider.expects(:list_customers).returns([])
provider.expects(:create_customer)
.with(unique_id: @item.generated_customer_unique_id, name: @item.generated_customer_name, source: "Sure")
.returns({ CustomerID: "cust-new", CustomerName: @item.generated_customer_name })
assert_equal "cust-new", @item.ensure_customer!(provider: provider)
assert_equal "cust-new", @item.customer_id
end
test "connected_to_institution ignores failed connection attempts" do
@item.update!(user_institution_id: "ui-1", status: :requires_update)
assert_not @item.connected_to_institution?
end
test "connected_to_institution ignores jobs that are still running" do
@item.update!(user_institution_id: "ui-1", current_job_id: "job-1", status: :good)
assert_not @item.connected_to_institution?
end
test "connected_to_institution ignores stale timeout job snapshots" do
@item.update!(
user_institution_id: "ui-1",
status: :good,
job_status: "Timeout",
raw_job_payload: {
SuccessFlag: false,
LastStatus: "Timeout"
}
)
assert_not @item.connected_to_institution?
end
test "provider_display_name keeps accounts grouping provider-level" do
@item.update!(name: "Bank of America", institution_name: "Bank of America")
assert_equal "Sophtron Connection", @item.provider_display_name
end
test "fetch_remote_accounts persists Sophtron account snapshots" do
@item.update!(user_institution_id: "ui-1")
provider = mock
provider.expects(:get_accounts).with("ui-1").returns({
accounts: [
{
id: "acct-1",
account_id: "acct-1",
account_name: "Sophtron Checking",
balance: "123.45",
balance_currency: "USD",
currency: "USD"
}.with_indifferent_access
],
total: 1
})
@item.stubs(:sophtron_provider).returns(provider)
accounts = @item.fetch_remote_accounts(force: true)
assert_equal 1, accounts.count
assert_equal "Sophtron Checking", @item.sophtron_accounts.find_by!(account_id: "acct-1").name
end
test "reject_already_linked removes accounts with existing account provider links" do
account = accounts(:depository)
sophtron_account = @item.sophtron_accounts.create!(
account_id: "acct-1",
name: "Sophtron Checking",
currency: "USD",
balance: 100
)
AccountProvider.create!(account: account, provider: sophtron_account)
available = @item.reject_already_linked([
{ id: "acct-1", account_name: "Linked" },
{ id: "acct-2", account_name: "Available" }
])
assert_equal [ "acct-2" ], available.map { |account_data| SophtronItem.external_account_id(account_data) }
end
test "build_mfa_challenge normalizes Sophtron job challenge fields" do
challenge = @item.build_mfa_challenge(
SecurityQuestion: [ "Question?" ].to_json,
TokenMethod: [ "sms" ].to_json,
TokenSentFlag: true,
TokenInputName: "Token",
TokenRead: "phone",
CaptchaImage: "YWJj"
)
assert_equal [ "Question?" ], challenge[:security_questions]
assert_equal [ "sms" ], challenge[:token_methods]
assert_equal true, challenge[:token_sent]
assert_equal "phone", challenge[:token_read]
assert_equal "YWJj", challenge[:captcha_image]
end
test "start_initial_load_later starts a sync when no active sync exists" do
assert_no_enqueued_jobs only: SophtronInitialLoadJob do
assert_difference "@item.syncs.count", 1 do
assert_enqueued_with job: SyncJob do
@item.start_initial_load_later
end
end
end
end
test "start_initial_load_later seeds sync window for transaction import" do
@item.update!(sync_start_date: Date.new(2026, 1, 1))
@item.start_initial_load_later
assert_equal Date.new(2026, 1, 1), @item.syncs.ordered.first.window_start_date
end
test "start_initial_load_later queues a follow-up when current sync is already running" do
sync = @item.syncs.create!
sync.start!
assert_no_difference "@item.syncs.count" do
assert_enqueued_with job: SophtronInitialLoadJob do
@item.start_initial_load_later
end
end
end
test "manual Sophtron accounts do not remove the whole item from automatic sync scope" do
manual_item = @family.sophtron_items.create!(
name: "Manual Sophtron",
user_id: "manual-user",
access_key: Base64.strict_encode64("secret-key")
)
manual_account = manual_item.sophtron_accounts.create!(
account_id: "acct-manual",
name: "Manual Sophtron Checking",
currency: "USD",
balance: 100,
manual_sync: true
)
auto_account = manual_item.sophtron_accounts.create!(
account_id: "acct-auto",
name: "Automatic Sophtron Checking",
currency: "USD",
balance: 100
)
AccountProvider.create!(account: accounts(:depository), provider: manual_account)
AccountProvider.create!(account: accounts(:credit_card), provider: auto_account)
assert_includes SophtronItem.active, manual_item
assert_includes SophtronItem.syncable, manual_item
assert_equal [ auto_account ], manual_item.automatic_sync_sophtron_accounts.to_a
assert_equal [ manual_account ], manual_item.manual_sync_sophtron_accounts.to_a
end
test "whole item manual mode removes linked accounts from automatic sync scope" do
manual_item = @family.sophtron_items.create!(
name: "Manual Sophtron",
user_id: "manual-user",
access_key: Base64.strict_encode64("secret-key"),
manual_sync: true
)
first_account = manual_item.sophtron_accounts.create!(
account_id: "acct-1",
name: "Manual Sophtron Checking",
currency: "USD",
balance: 100
)
second_account = manual_item.sophtron_accounts.create!(
account_id: "acct-2",
name: "Manual Sophtron Card",
currency: "USD",
balance: 200
)
AccountProvider.create!(account: accounts(:depository), provider: first_account)
AccountProvider.create!(account: accounts(:credit_card), provider: second_account)
assert_empty manual_item.automatic_sync_sophtron_accounts
assert_equal [ first_account, second_account ], manual_item.manual_sync_sophtron_accounts.to_a
end
end