mirror of
https://github.com/we-promise/sure.git
synced 2026-04-15 18:14:14 +00:00
140ea78b0e
* Add shared sync statistics collection and provider sync summary UI - Introduced `SyncStats::Collector` concern to centralize sync statistics logic, including account, transaction, holdings, and health stats collection. - Added collapsible `ProviderSyncSummary` component for displaying sync summaries across providers. - Updated syncers (e.g., `LunchflowItem::Syncer`) to use the shared collector methods for consistent stats calculation. - Added rake tasks under `dev:sync_stats` for testing and development purposes, including fake stats generation with optional issues. - Enhanced provider-specific views to include sync summaries using the new shared component. * Refactor `ProviderSyncSummary` to improve maintainability - Extracted `severity_color_class` to simplify severity-to-CSS mapping. - Replaced `holdings_label` with `holdings_label_key` for streamlined localization. - Updated locale file to separate `found` and `processed` translations for clarity. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
227 lines
11 KiB
Plaintext
227 lines
11 KiB
Plaintext
<%# locals: (simplefin_item:) %>
|
||
|
||
<%= tag.div id: dom_id(simplefin_item) do %>
|
||
<details open class="group bg-container p-4 shadow-border-xs rounded-xl">
|
||
<summary class="flex items-center justify-between gap-2">
|
||
<div class="flex items-center gap-2">
|
||
<%= icon "chevron-right", class: "group-open:transform group-open:rotate-90" %>
|
||
|
||
<div class="flex items-center justify-center h-8 w-8 bg-success/10 rounded-full">
|
||
<% if simplefin_item.logo.attached? %>
|
||
<%= image_tag simplefin_item.logo, class: "rounded-full h-full w-full", loading: "lazy" %>
|
||
<% else %>
|
||
<div class="flex items-center justify-center">
|
||
<%= tag.p simplefin_item.name.first.upcase, class: "text-success text-xs font-medium" %>
|
||
</div>
|
||
<% end %>
|
||
</div>
|
||
|
||
<%# Compute unlinked count early for badge display %>
|
||
<% header_unlinked_count = if defined?(@simplefin_unlinked_count_map) && @simplefin_unlinked_count_map
|
||
@simplefin_unlinked_count_map[simplefin_item.id] || 0
|
||
else
|
||
begin
|
||
simplefin_item.simplefin_accounts
|
||
.left_joins(:account, :account_provider)
|
||
.where(accounts: { id: nil }, account_providers: { id: nil })
|
||
.count
|
||
rescue => e
|
||
0
|
||
end
|
||
end %>
|
||
|
||
<div class="pl-1 text-sm">
|
||
<div class="flex items-center gap-2">
|
||
<%= tag.p simplefin_item.name, class: "font-medium text-primary" %>
|
||
<% if header_unlinked_count.to_i > 0 %>
|
||
<%= link_to setup_accounts_simplefin_item_path(simplefin_item),
|
||
data: { turbo_frame: :modal },
|
||
class: "inline-flex items-center gap-1 px-2 py-0.5 rounded-full text-xs font-medium bg-warning/10 text-warning hover:bg-warning/20 transition-colors" do %>
|
||
<%= icon "alert-circle", size: "xs" %>
|
||
<span><%= header_unlinked_count %> <%= header_unlinked_count == 1 ? "account" : "accounts" %> need setup</span>
|
||
<% end %>
|
||
<% end %>
|
||
<% if simplefin_item.scheduled_for_deletion? %>
|
||
<p class="text-destructive text-sm animate-pulse"><%= t(".deletion_in_progress") %></p>
|
||
<% end %>
|
||
</div>
|
||
<% if simplefin_item.accounts.any? %>
|
||
<p class="text-xs text-secondary">
|
||
<%= simplefin_item.institution_summary %>
|
||
</p>
|
||
<%# Extra inline badges from latest sync stats %>
|
||
<% stats = (@simplefin_sync_stats_map || {})[simplefin_item.id] || {} %>
|
||
<% if stats.present? %>
|
||
<div class="flex items-center gap-2 mt-1">
|
||
<% if stats["unlinked_accounts"].to_i > 0 %>
|
||
<%= render DS::Tooltip.new(text: "Accounts need setup", icon: "link-2", size: "sm") %>
|
||
<span class="text-xs text-secondary">Unlinked: <%= stats["unlinked_accounts"].to_i %></span>
|
||
<% end %>
|
||
|
||
<% if stats["accounts_skipped"].to_i > 0 %>
|
||
<%= render DS::Tooltip.new(text: "Some accounts were skipped due to errors during sync", icon: "alert-triangle", size: "sm", color: "warning") %>
|
||
<span class="text-xs text-warning">Skipped: <%= stats["accounts_skipped"].to_i %></span>
|
||
<% end %>
|
||
|
||
<% if stats["rate_limited"].present? || stats["rate_limited_at"].present? %>
|
||
<% ts = stats["rate_limited_at"] %>
|
||
<% ago = (ts.present? ? (begin; time_ago_in_words(Time.parse(ts)); rescue StandardError; nil; end) : nil) %>
|
||
<%= render DS::Tooltip.new(
|
||
text: (ago ? "Rate limited (" + ago + " ago)" : "Rate limited recently"),
|
||
icon: "clock",
|
||
size: "sm",
|
||
color: "warning"
|
||
) %>
|
||
<% end %>
|
||
|
||
<% if stats["total_errors"].to_i > 0 || (stats["errors"].is_a?(Array) && stats["errors"].any?) %>
|
||
<% tooltip_text = simplefin_error_tooltip(stats) %>
|
||
<% if tooltip_text.present? %>
|
||
<%= render DS::Tooltip.new(text: tooltip_text, icon: "alert-octagon", size: "sm", color: "warning") %>
|
||
<% end %>
|
||
<% end %>
|
||
|
||
<% if stats["total_accounts"].to_i > 0 %>
|
||
<span class="text-xs text-secondary">Total: <%= stats["total_accounts"].to_i %></span>
|
||
<% end %>
|
||
</div>
|
||
<% end %>
|
||
<% end %>
|
||
<%# Determine if all reported errors are benign duplicate-skips (suppress scary banner). Computed in controller for testability. %>
|
||
<% duplicate_only_errors = (@simplefin_duplicate_only_map || {})[simplefin_item.id] || false %>
|
||
<% if simplefin_item.syncing? %>
|
||
<div class="text-secondary flex items-center gap-1">
|
||
<%= icon "loader", size: "sm", class: "animate-spin" %>
|
||
<%= tag.span t(".syncing") %>
|
||
</div>
|
||
<% elsif simplefin_item.requires_update? %>
|
||
<div class="text-warning flex items-center gap-1">
|
||
<%= icon "alert-triangle", size: "sm", color: "warning" %>
|
||
<%= tag.span t(".requires_update") %>
|
||
</div>
|
||
<% elsif (stale_status = simplefin_item.stale_sync_status)[:stale] %>
|
||
<div class="text-warning flex items-center gap-1">
|
||
<%= icon "alert-circle", size: "sm", color: "warning" %>
|
||
<%= tag.span stale_status[:message], class: "text-sm" %>
|
||
</div>
|
||
<% elsif simplefin_item.rate_limited_message.present? %>
|
||
<div class="text-warning flex items-center gap-1">
|
||
<%= icon "clock", size: "sm", color: "warning" %>
|
||
<%= tag.span simplefin_item.rate_limited_message %>
|
||
</div>
|
||
<% elsif simplefin_item.sync_error.present? && !duplicate_only_errors %>
|
||
<div class="text-secondary flex items-center gap-1">
|
||
<%= render DS::Tooltip.new(text: simplefin_item.sync_error, icon: "alert-circle", size: "sm", color: "destructive") %>
|
||
<%= tag.span t(".error"), class: "text-destructive" %>
|
||
</div>
|
||
<% elsif duplicate_only_errors %>
|
||
<div class="text-secondary flex items-center gap-1">
|
||
<%= icon "info", size: "sm" %>
|
||
<%= tag.span "Some accounts were skipped as duplicates — use ‘Link existing accounts’ to merge.", class: "text-secondary" %>
|
||
</div>
|
||
<% else %>
|
||
<p class="text-secondary">
|
||
<% if simplefin_item.last_synced_at %>
|
||
<% if simplefin_item.sync_status_summary %>
|
||
<%= t(".status_with_summary", timestamp: time_ago_in_words(simplefin_item.last_synced_at), summary: simplefin_item.sync_status_summary) %>
|
||
<% else %>
|
||
<%= t(".status", timestamp: time_ago_in_words(simplefin_item.last_synced_at)) %>
|
||
<% end %>
|
||
<% else %>
|
||
<%= t(".status_never") %>
|
||
<% end %>
|
||
</p>
|
||
<% end %>
|
||
</div>
|
||
</div>
|
||
|
||
<div class="flex items-center gap-2">
|
||
<% if simplefin_item.requires_update? %>
|
||
<%= render DS::Link.new(
|
||
text: t(".update"),
|
||
icon: "refresh-cw",
|
||
variant: "secondary",
|
||
href: edit_simplefin_item_path(simplefin_item),
|
||
frame: "modal"
|
||
) %>
|
||
<% elsif Rails.env.development? %>
|
||
<%= icon(
|
||
"refresh-cw",
|
||
as_button: true,
|
||
href: sync_simplefin_item_path(simplefin_item)
|
||
) %>
|
||
<% end %>
|
||
|
||
<%= render DS::Menu.new do |menu| %>
|
||
<% menu.with_item(
|
||
variant: "button",
|
||
text: t(".delete"),
|
||
icon: "trash-2",
|
||
href: simplefin_item_path(simplefin_item),
|
||
method: :delete,
|
||
confirm: CustomConfirm.for_resource_deletion(simplefin_item.name, high_severity: true)
|
||
) %>
|
||
<% end %>
|
||
</div>
|
||
</summary>
|
||
|
||
<% unless simplefin_item.scheduled_for_deletion? %>
|
||
<div class="space-y-4 mt-4">
|
||
<% if simplefin_item.accounts.any? %>
|
||
<%= render "accounts/index/account_groups", accounts: simplefin_item.accounts %>
|
||
<% end %>
|
||
|
||
<%# Sync summary (collapsible) - using shared ProviderSyncSummary component
|
||
Prefer controller-provided map; fallback to latest sync stats so Turbo broadcasts
|
||
can render the summary without requiring a full page refresh. %>
|
||
<% stats = if defined?(@simplefin_sync_stats_map) && @simplefin_sync_stats_map
|
||
@simplefin_sync_stats_map[simplefin_item.id] || {}
|
||
else
|
||
# `latest_sync` is private on Syncable; access via association for broadcast renders.
|
||
simplefin_item.syncs.ordered.first&.sync_stats || {}
|
||
end %>
|
||
<%= render ProviderSyncSummary.new(
|
||
stats: stats,
|
||
provider_item: simplefin_item,
|
||
institutions_count: simplefin_item.connected_institutions.size
|
||
) %>
|
||
|
||
<%# Compute unlinked SimpleFin accounts (no legacy account and no AccountProvider link)
|
||
# Prefer controller-provided map; fallback to a local query so the card stays accurate after Turbo broadcasts %>
|
||
<% unlinked_count = if defined?(@simplefin_unlinked_count_map) && @simplefin_unlinked_count_map
|
||
@simplefin_unlinked_count_map[simplefin_item.id] || 0
|
||
else
|
||
begin
|
||
simplefin_item.simplefin_accounts
|
||
.left_joins(:account, :account_provider)
|
||
.where(accounts: { id: nil }, account_providers: { id: nil })
|
||
.count
|
||
rescue => e
|
||
Rails.logger.warn("SimpleFin card: unlinked_count fallback failed: #{e.class} - #{e.message}")
|
||
0
|
||
end
|
||
end %>
|
||
|
||
<% if unlinked_count.to_i > 0 %>
|
||
<div class="p-4 flex flex-col gap-3 items-center justify-center">
|
||
<p class="text-primary font-medium text-sm"><%= t(".setup_needed") %></p>
|
||
<p class="text-secondary text-sm"><%= t(".setup_description") %></p>
|
||
<%= render DS::Link.new(
|
||
text: t(".setup_action"),
|
||
icon: "settings",
|
||
variant: "primary",
|
||
href: setup_accounts_simplefin_item_path(simplefin_item),
|
||
frame: :modal
|
||
) %>
|
||
</div>
|
||
<% elsif simplefin_item.accounts.empty? %>
|
||
<div class="p-4 flex flex-col gap-3 items-center justify-center">
|
||
<p class="text-primary font-medium text-sm"><%= t(".no_accounts_title") %></p>
|
||
<p class="text-secondary text-sm"><%= t(".no_accounts_description") %></p>
|
||
</div>
|
||
<% end %>
|
||
</div>
|
||
<% end %>
|
||
</details>
|
||
<% end %>
|