mirror of
https://github.com/we-promise/sure.git
synced 2026-07-24 18:55:27 +00:00
* Add per-account toggle to disable automatic transaction categorization Adds an `enable_category_matcher` boolean (default: true) to accounts so users can opt out of Plaid's automatic category suggestions on a per-account basis. When disabled, newly synced transactions arrive uncategorized so rules or manual assignment take precedence. - New migration adds `enable_category_matcher` column (default true, null: false) - `PlaidEntry::Processor#matched_category` gates the CategoryMatcher call on the account flag - Toggle rendered in the account edit modal for linked accounts (saves via main form submit) - `AccountableResource#account_params` permits the new field - `AccountsController#toggle_category_matcher` action added for potential API use - i18n strings added for label and hint text - Unit test covers the disabled-matcher path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Only show category matcher toggle for Plaid-linked accounts Only PlaidEntry::Processor honors enable_category_matcher, but the toggle rendered for every linked account, silently doing nothing for other providers. Adds Account::Linkable#supports_category_matcher? (covering both the legacy plaid_account_id link and AccountProvider rows) and gates the form toggle on it. The SimpleFIN TODO now also points at this helper so the toggle appears once SimpleFIN matching lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Add controller tests for category matcher toggle persistence and rendering Covers the two paths flagged in review as untested: the flag persisting through the shared AccountableResource#update action via account_params (both disable and re-enable), and the edit form rendering the toggle only for accounts where supports_category_matcher? is true. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Signed-off-by: Mike Lloyd <49411532+mike-lloyd03@users.noreply.github.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
120 lines
4.0 KiB
Ruby
120 lines
4.0 KiB
Ruby
module AccountableResource
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
include Periodable, StreamExtensions
|
|
|
|
before_action :set_account, only: [ :show ]
|
|
before_action :set_manageable_account, only: [ :edit, :update ]
|
|
before_action :set_link_options, only: :new
|
|
end
|
|
|
|
class_methods do
|
|
def permitted_accountable_attributes(*attrs)
|
|
@permitted_accountable_attributes = attrs if attrs.any?
|
|
@permitted_accountable_attributes ||= [ :id ]
|
|
end
|
|
end
|
|
|
|
def new
|
|
@account = Current.family.accounts.build(
|
|
currency: Current.family.currency,
|
|
accountable: accountable_type.new
|
|
)
|
|
end
|
|
|
|
def show
|
|
@chart_view = params[:chart_view] || "balance"
|
|
@q = params.fetch(:q, {}).permit(:search)
|
|
entries = @account.entries.search(@q).reverse_chronological
|
|
|
|
@pagy, @entries = pagy(entries, limit: safe_per_page(10))
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def create
|
|
opening_balance_date = begin
|
|
account_params[:opening_balance_date].presence&.to_date
|
|
rescue Date::Error
|
|
nil
|
|
end || (Time.zone.today - 2.years)
|
|
Account.transaction do
|
|
@account = Current.family.accounts.create_and_sync(
|
|
account_params.except(:return_to, :opening_balance_date).merge(owner: Current.user),
|
|
opening_balance_date: opening_balance_date
|
|
)
|
|
@account.lock_saved_attributes!
|
|
end
|
|
|
|
# Prefer the form-carried return_to, then the session value StoreLocation
|
|
# captured from `?return_to=` (survives multi-step flows where the param
|
|
# isn't threaded), then the account page. The form param is sanitized here
|
|
# (the session value is already filtered at store time); the session is
|
|
# consumed with delete so a stale value can't leak into a later flow.
|
|
return_path = safe_return_to(account_params[:return_to]) || session.delete(:return_to).presence || @account
|
|
redirect_to return_path,
|
|
notice: t("accounts.create.success", type: accountable_type.name.underscore.humanize)
|
|
end
|
|
|
|
def update
|
|
# Handle balance update if the value actually changed
|
|
if account_params[:balance].present? && account_params[:balance].to_d != @account.balance
|
|
result = @account.set_current_balance(account_params[:balance].to_d)
|
|
unless result.success?
|
|
@error_message = result.error_message
|
|
render :edit, status: :unprocessable_entity
|
|
return
|
|
end
|
|
end
|
|
|
|
# Update remaining account attributes. Note: currency is intentionally allowed
|
|
# here so all account types (depositories, credit cards, loans, etc.) can
|
|
# have their currency changed via this shared update path.
|
|
update_params = account_params.except(:return_to, :balance, :opening_balance_date)
|
|
unless @account.update(update_params)
|
|
@error_message = @account.errors.full_messages.join(", ")
|
|
render :edit, status: :unprocessable_entity
|
|
return
|
|
end
|
|
|
|
@account.lock_saved_attributes!
|
|
redirect_back_or_to account_path(@account), notice: t("accounts.update.success", type: accountable_type.name.underscore.humanize)
|
|
end
|
|
|
|
private
|
|
def set_link_options
|
|
account_type_name = accountable_type.name
|
|
|
|
# Get all available provider configs dynamically for this account type
|
|
@provider_configs = Provider::Factory.connection_configs_for_account_type(
|
|
account_type: account_type_name,
|
|
family: Current.family
|
|
)
|
|
end
|
|
|
|
def accountable_type
|
|
controller_name.classify.constantize
|
|
end
|
|
|
|
def set_account
|
|
@account = Current.user.accessible_accounts.find(params[:id])
|
|
end
|
|
|
|
def set_manageable_account
|
|
@account = Current.user.accessible_accounts.find(params[:id])
|
|
require_account_permission!(@account)
|
|
end
|
|
|
|
def account_params
|
|
params.require(:account).permit(
|
|
:name, :balance, :subtype, :currency, :accountable_type, :return_to,
|
|
:opening_balance_date,
|
|
:institution_name, :institution_domain, :notes, :exclude_from_reports,
|
|
:enable_category_matcher,
|
|
accountable_attributes: self.class.permitted_accountable_attributes
|
|
)
|
|
end
|
|
end
|