mirror of
https://github.com/we-promise/sure.git
synced 2026-05-30 15:59:02 +00:00
- Page header: title "Savings" + "Your savings accounts and the goals you're working toward." Removed the top-right New goal button (moves into the Goals section). - Hero card: "Total in savings" with sum-of-savings-subtype balance, 30-day delta vs last 30 days (Family#savings_balance_30d_delta), 3-stat sub-row (Accounts / Active goals / Saved toward goals), and a D3 sparkline area chart on the right (new `savings-sparkline` Stimulus controller, sourced from Family#savings_balance_series). - Accounts section: lists Depository accounts with subtype = "savings" as cards (blue avatar, name, subtype, balance, "Funds N goals"). New Savings::AccountCardComponent. - Goals section header: "Goals" + "Save toward what matters." + "New goal" button right-aligned to the section (not the page header). - Removed state-filter pill nav. Active goals render in the main grid; Completed goals get a "Completed · N" divider w/ check-circle icon and their own grid below. - Goal card layout reworked: horizontal bar replaced with a 64px donut ring on the right side of the card header (ring colour tracks goal.status — yellow=behind, primary=on-track, green=reached). Pill is inline with the goal name. - Status pill copy: "Behind pace" → "Behind". - Filter bar (copied from settings/providers): search input + status chips (All / On track / Behind / No date). Hidden when ≤ 6 active goals. Powered by `savings-goals-filter` Stimulus controller — toggles `.hidden` on cards by goal name + status. - Family#savings_subtype_accounts, total_savings_balance, savings_balance_series, savings_balance_30d_delta helpers; controller computes hero payload + account-goal counts for the cards.
254 lines
8.7 KiB
Ruby
254 lines
8.7 KiB
Ruby
class SavingsGoalsController < ApplicationController
|
|
before_action :set_savings_goal, only: %i[show edit update destroy pause resume complete archive unarchive]
|
|
|
|
STATE_FILTERS = %w[all active paused completed archived].freeze
|
|
|
|
def index
|
|
@counts = STATE_FILTERS.each_with_object({}) do |state, h|
|
|
h[state] = state == "all" ? Current.family.savings_goals.count : Current.family.savings_goals.where(state: state).count
|
|
end
|
|
|
|
all_goals = Current.family.savings_goals.with_current_balance.alphabetically.to_a
|
|
@active_goals = all_goals.reject { |g| %w[completed archived].include?(g.state) }
|
|
@completed_goals = all_goals.select { |g| g.state == "completed" }
|
|
|
|
@linkable_account_count = Current.family.accounts.where(accountable_type: "Depository").visible.count
|
|
@savings_accounts = Current.family.savings_subtype_accounts
|
|
@account_goal_counts = goal_count_per_account(@savings_accounts)
|
|
@hero = hero_payload(all_goals)
|
|
@show_search = @active_goals.size > 6
|
|
end
|
|
|
|
def show
|
|
@contributions = @savings_goal.savings_contributions.includes(:account).chronological.limit(50)
|
|
@funding_breakdown = funding_breakdown_for(@savings_goal)
|
|
@stats = stats_for(@savings_goal)
|
|
end
|
|
|
|
def new
|
|
@savings_goal = Current.family.savings_goals.new(
|
|
color: SavingsGoal::COLORS.sample,
|
|
currency: Current.family.primary_currency_code
|
|
)
|
|
@linkable_accounts = linkable_accounts_for_new
|
|
end
|
|
|
|
def create
|
|
@savings_goal = Current.family.savings_goals.new(savings_goal_params)
|
|
accounts = lookup_accounts(params.dig(:savings_goal, :account_ids))
|
|
@savings_goal.currency = accounts.first.currency if accounts.any? && @savings_goal.currency.blank?
|
|
|
|
SavingsGoal.transaction do
|
|
accounts.each { |a| @savings_goal.savings_goal_accounts.build(account: a) }
|
|
@savings_goal.save!
|
|
create_initial_contribution_if_provided!(@savings_goal, accounts)
|
|
end
|
|
|
|
flash[:notice] = t(".success")
|
|
respond_to do |format|
|
|
format.html { redirect_to savings_goal_path(@savings_goal) }
|
|
format.turbo_stream do
|
|
render turbo_stream: turbo_stream.action(:redirect, savings_goal_path(@savings_goal))
|
|
end
|
|
end
|
|
rescue ActiveRecord::RecordInvalid
|
|
@linkable_accounts = linkable_accounts_for_new
|
|
render :new, status: :unprocessable_entity
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def update
|
|
if @savings_goal.update(savings_goal_update_params)
|
|
flash[:notice] = t(".success")
|
|
respond_to do |format|
|
|
format.html { redirect_to savings_goal_path(@savings_goal) }
|
|
format.turbo_stream do
|
|
render turbo_stream: turbo_stream.action(:redirect, savings_goal_path(@savings_goal))
|
|
end
|
|
end
|
|
else
|
|
render :edit, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
unless @savings_goal.archived?
|
|
redirect_to savings_goal_path(@savings_goal), alert: t(".archive_first")
|
|
return
|
|
end
|
|
|
|
@savings_goal.destroy!
|
|
redirect_to savings_goals_path, notice: t(".success")
|
|
end
|
|
|
|
def pause
|
|
perform_transition!(:pause)
|
|
end
|
|
|
|
def resume
|
|
perform_transition!(:resume)
|
|
end
|
|
|
|
def complete
|
|
perform_transition!(:complete)
|
|
end
|
|
|
|
def archive
|
|
perform_transition!(:archive)
|
|
end
|
|
|
|
def unarchive
|
|
perform_transition!(:unarchive)
|
|
end
|
|
|
|
private
|
|
def set_savings_goal
|
|
@savings_goal = Current.family.savings_goals.find(params[:id])
|
|
end
|
|
|
|
def savings_goal_params
|
|
params.require(:savings_goal).permit(:name, :target_amount, :target_date, :color, :notes)
|
|
end
|
|
|
|
def savings_goal_update_params
|
|
params.require(:savings_goal).permit(:name, :target_amount, :target_date, :color, :notes)
|
|
end
|
|
|
|
def lookup_accounts(ids)
|
|
return [] if ids.blank?
|
|
|
|
ids = Array(ids).reject(&:blank?)
|
|
Current.family.accounts.where(accountable_type: "Depository").visible.where(id: ids).to_a
|
|
end
|
|
|
|
def linkable_accounts_for_new
|
|
Current.family.accounts.where(accountable_type: "Depository").visible.alphabetically.to_a
|
|
end
|
|
|
|
def create_initial_contribution_if_provided!(goal, accounts)
|
|
amount = params.dig(:savings_goal, :initial_contribution_amount)
|
|
account_id = params.dig(:savings_goal, :initial_contribution_account_id)
|
|
return if amount.blank? || account_id.blank?
|
|
return unless BigDecimal(amount.to_s) > 0
|
|
|
|
source = accounts.find { |a| a.id == account_id }
|
|
raise ActiveRecord::RecordInvalid.new(goal) unless source
|
|
|
|
goal.savings_contributions.create!(
|
|
account: source,
|
|
amount: amount,
|
|
currency: goal.currency,
|
|
source: "initial",
|
|
contributed_at: Date.current
|
|
)
|
|
end
|
|
|
|
def funding_breakdown_for(goal)
|
|
totals = goal.savings_contributions
|
|
.group(:account_id)
|
|
.sum(:amount)
|
|
goal.linked_accounts.map do |account|
|
|
amount = totals[account.id] || 0
|
|
{ account: account, amount: amount, money: Money.new(amount, goal.currency) }
|
|
end
|
|
end
|
|
|
|
def hero_payload(all_goals)
|
|
family = Current.family
|
|
currency = family.primary_currency_code
|
|
total_savings = family.total_savings_balance
|
|
saved_toward_goals = all_goals.sum { |g| g.current_balance.to_d }
|
|
delta = family.savings_balance_30d_delta
|
|
{
|
|
currency: currency,
|
|
total_savings_money: Money.new(total_savings, currency),
|
|
saved_toward_goals_money: Money.new(saved_toward_goals, currency),
|
|
accounts_count: family.savings_subtype_accounts.size,
|
|
active_goals_count: @counts["active"].to_i,
|
|
delta: delta,
|
|
delta_amount_money: Money.new(delta[:amount].abs, currency),
|
|
sparkline_series: family.savings_balance_series(days: 30)
|
|
}
|
|
end
|
|
|
|
def goal_count_per_account(accounts)
|
|
return {} if accounts.empty?
|
|
|
|
SavingsGoalAccount
|
|
.where(account_id: accounts.map(&:id))
|
|
.joins(:savings_goal)
|
|
.where.not(savings_goals: { state: %w[archived] })
|
|
.group(:account_id)
|
|
.count
|
|
end
|
|
|
|
def stats_for(goal)
|
|
avg = goal.average_monthly_contribution.to_d
|
|
sub_avg = if goal.monthly_target_amount && goal.monthly_target_amount.to_d > avg
|
|
t("savings_goals.show.stats.needs_per_month", amount: Money.new(goal.monthly_target_amount, goal.currency).format)
|
|
else
|
|
t("savings_goals.show.stats.above_target_pace")
|
|
end
|
|
sub_target = if goal.monthly_target_amount
|
|
t("savings_goals.show.stats.needs_per_month", amount: Money.new(goal.monthly_target_amount, goal.currency).format)
|
|
else
|
|
t("savings_goals.show.stats.no_required_pace")
|
|
end
|
|
months_since_start = ((Date.current.year - goal.created_at.year) * 12 + (Date.current.month - goal.created_at.month)).clamp(0, 1200)
|
|
sub_started = t("savings_goals.show.stats.months_ago", count: months_since_start)
|
|
linked_balance = goal.linked_accounts.sum { |a| a.balance.to_d }
|
|
sub_linked = t("savings_goals.show.stats.n_accounts", count: goal.linked_accounts.size)
|
|
|
|
summary = projection_summary(goal, avg)
|
|
|
|
{
|
|
avg_monthly: avg,
|
|
avg_monthly_sub: sub_avg,
|
|
contributions_count: goal.savings_contributions.count,
|
|
monthly_target_sub: sub_target,
|
|
started_sub: sub_started,
|
|
linked_balance: linked_balance,
|
|
linked_balance_sub: sub_linked,
|
|
projection_summary: summary
|
|
}
|
|
end
|
|
|
|
def projection_summary(goal, avg_monthly)
|
|
currency = goal.currency
|
|
money = ->(amount) { Money.new(amount, currency).format }
|
|
|
|
if goal.completed? || goal.progress_percent >= 100
|
|
t("savings_goals.show.projection.reached")
|
|
elsif goal.target_date.nil?
|
|
t("savings_goals.show.projection.no_target_date")
|
|
elsif goal.monthly_target_amount && avg_monthly < goal.monthly_target_amount
|
|
t("savings_goals.show.projection.behind",
|
|
current: money.call(avg_monthly),
|
|
required: money.call(goal.monthly_target_amount))
|
|
elsif avg_monthly.positive?
|
|
months_to_target = (goal.remaining_amount.to_d / avg_monthly).ceil
|
|
projected_date = Date.current >> months_to_target.to_i
|
|
t("savings_goals.show.projection.on_track",
|
|
date: projected_date.strftime("%b %Y"))
|
|
else
|
|
t("savings_goals.show.projection.no_pace")
|
|
end
|
|
end
|
|
|
|
def perform_transition!(event)
|
|
if @savings_goal.aasm.may_fire_event?(event)
|
|
@savings_goal.public_send("#{event}!")
|
|
respond_to do |format|
|
|
format.html { redirect_to savings_goal_path(@savings_goal), notice: t(".success") }
|
|
format.turbo_stream do
|
|
render turbo_stream: turbo_stream.action(:redirect, savings_goal_path(@savings_goal))
|
|
end
|
|
end
|
|
else
|
|
redirect_to savings_goal_path(@savings_goal), alert: t(".invalid_transition")
|
|
end
|
|
end
|
|
end
|