mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Wire ui layout and AI flags into mobile auth Include ui_layout and ai_enabled in mobile login/signup/SSO payloads, add an authenticated endpoint to enable AI from Flutter, and gate mobile navigation based on intro layout and AI consent flow. * Linter * Ensure write scope on enable_ai * Make sure AI is available before enabling it * Test improvements * PR comment * Fix review issues: test assertion bug, missing coverage, and Dart defaults (#985) - Fix login test to use ai_enabled? (method) instead of ai_enabled (column) to match what mobile_user_payload actually serializes - Add test for enable_ai when ai_available? returns false (403 path) - Default aiEnabled to false when user is null in AuthProvider to avoid showing AI as available before authentication completes - Remove extra blank lines in auth_provider.dart and auth_service.dart https://claude.ai/code/session_01LEYYmtsDBoqizyihFtkye4 Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
509 lines
16 KiB
Ruby
509 lines
16 KiB
Ruby
require "test_helper"
|
|
|
|
class Api::V1::AuthControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
# Clean up any existing invite codes
|
|
InviteCode.destroy_all
|
|
@device_info = {
|
|
device_id: "test-device-123",
|
|
device_name: "Test iPhone",
|
|
device_type: "ios",
|
|
os_version: "17.0",
|
|
app_version: "1.0.0"
|
|
}
|
|
|
|
# Ensure the shared OAuth application exists
|
|
@shared_app = Doorkeeper::Application.find_or_create_by!(name: "Sure Mobile") do |app|
|
|
app.redirect_uri = "sureapp://oauth/callback"
|
|
app.scopes = "read read_write"
|
|
app.confidential = false
|
|
end
|
|
@shared_app.update!(scopes: "read read_write")
|
|
|
|
# Clear the memoized class variable so it picks up the test record
|
|
MobileDevice.instance_variable_set(:@shared_oauth_application, nil)
|
|
end
|
|
|
|
test "should signup new user and return OAuth tokens" do
|
|
assert_difference("User.count", 1) do
|
|
assert_difference("MobileDevice.count", 1) do
|
|
assert_no_difference("Doorkeeper::Application.count") do
|
|
assert_difference("Doorkeeper::AccessToken.count", 1) do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "SecurePass123!",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info
|
|
}
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
assert_response :created
|
|
response_data = JSON.parse(response.body)
|
|
|
|
assert response_data["user"]["id"].present?
|
|
assert_equal "newuser@example.com", response_data["user"]["email"]
|
|
assert_equal "New", response_data["user"]["first_name"]
|
|
assert_equal "User", response_data["user"]["last_name"]
|
|
new_user = User.find(response_data["user"]["id"])
|
|
assert_equal new_user.ui_layout, response_data["user"]["ui_layout"]
|
|
assert_equal new_user.ai_enabled?, response_data["user"]["ai_enabled"]
|
|
|
|
# OAuth token assertions
|
|
assert response_data["access_token"].present?
|
|
assert response_data["refresh_token"].present?
|
|
assert_equal "Bearer", response_data["token_type"]
|
|
assert_equal 2592000, response_data["expires_in"] # 30 days
|
|
assert response_data["created_at"].present?
|
|
|
|
# Verify the device was created
|
|
created_user = User.find(response_data["user"]["id"])
|
|
device = created_user.mobile_devices.first
|
|
assert_equal @device_info[:device_id], device.device_id
|
|
assert_equal @device_info[:device_name], device.device_name
|
|
assert_equal @device_info[:device_type], device.device_type
|
|
end
|
|
|
|
test "should not signup without device info" do
|
|
assert_no_difference("User.count") do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "SecurePass123!",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_response :bad_request
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Device information is required", response_data["error"]
|
|
end
|
|
|
|
test "should not signup with invalid password" do
|
|
assert_no_difference("User.count") do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "weak",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :unprocessable_entity
|
|
response_data = JSON.parse(response.body)
|
|
assert response_data["errors"].include?("Password must be at least 8 characters")
|
|
end
|
|
|
|
test "should not signup with duplicate email" do
|
|
existing_user = users(:family_admin)
|
|
|
|
assert_no_difference("User.count") do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: existing_user.email,
|
|
password: "SecurePass123!",
|
|
first_name: "Duplicate",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :unprocessable_entity
|
|
end
|
|
|
|
test "should create user with admin role and family" do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "SecurePass123!",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info
|
|
}
|
|
|
|
assert_response :created
|
|
response_data = JSON.parse(response.body)
|
|
|
|
new_user = User.find(response_data["user"]["id"])
|
|
assert_equal "admin", new_user.role
|
|
assert new_user.family.present?
|
|
end
|
|
|
|
test "should require invite code when enabled" do
|
|
# Mock invite code requirement
|
|
Api::V1::AuthController.any_instance.stubs(:invite_code_required?).returns(true)
|
|
|
|
assert_no_difference("User.count") do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "SecurePass123!",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :forbidden
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Invite code is required", response_data["error"]
|
|
end
|
|
|
|
test "should signup with valid invite code when required" do
|
|
# Create a valid invite code
|
|
invite_code = InviteCode.create!
|
|
|
|
# Mock invite code requirement
|
|
Api::V1::AuthController.any_instance.stubs(:invite_code_required?).returns(true)
|
|
|
|
assert_difference("User.count", 1) do
|
|
assert_difference("InviteCode.count", -1) do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "SecurePass123!",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info,
|
|
invite_code: invite_code.token
|
|
}
|
|
end
|
|
end
|
|
|
|
assert_response :created
|
|
end
|
|
|
|
test "should reject invalid invite code" do
|
|
# Mock invite code requirement
|
|
Api::V1::AuthController.any_instance.stubs(:invite_code_required?).returns(false)
|
|
|
|
assert_no_difference("User.count") do
|
|
post "/api/v1/auth/signup", params: {
|
|
user: {
|
|
email: "newuser@example.com",
|
|
password: "SecurePass123!",
|
|
first_name: "New",
|
|
last_name: "User"
|
|
},
|
|
device: @device_info,
|
|
invite_code: "invalid_code"
|
|
}
|
|
end
|
|
|
|
assert_response :forbidden
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Invalid invite code", response_data["error"]
|
|
end
|
|
|
|
test "should login existing user and return OAuth tokens" do
|
|
user = users(:family_admin)
|
|
password = user_password_test
|
|
|
|
# Ensure user has no mobile devices
|
|
user.mobile_devices.destroy_all
|
|
|
|
assert_difference("MobileDevice.count", 1) do
|
|
assert_difference("Doorkeeper::AccessToken.count", 1) do
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: password,
|
|
device: @device_info
|
|
}
|
|
end
|
|
end
|
|
|
|
assert_response :success
|
|
response_data = JSON.parse(response.body)
|
|
|
|
assert_equal user.id.to_s, response_data["user"]["id"]
|
|
assert_equal user.email, response_data["user"]["email"]
|
|
assert_equal user.ui_layout, response_data["user"]["ui_layout"]
|
|
assert_equal user.ai_enabled?, response_data["user"]["ai_enabled"]
|
|
|
|
# OAuth token assertions
|
|
assert response_data["access_token"].present?
|
|
assert response_data["refresh_token"].present?
|
|
assert_equal "Bearer", response_data["token_type"]
|
|
assert_equal 2592000, response_data["expires_in"] # 30 days
|
|
|
|
# Verify the device
|
|
device = user.mobile_devices.where(device_id: @device_info[:device_id]).first
|
|
assert device.present?
|
|
assert device.active?
|
|
end
|
|
|
|
test "should require MFA when enabled" do
|
|
user = users(:family_admin)
|
|
password = user_password_test
|
|
|
|
# Enable MFA for user
|
|
user.setup_mfa!
|
|
user.enable_mfa!
|
|
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: password,
|
|
device: @device_info
|
|
}
|
|
|
|
assert_response :unauthorized
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Two-factor authentication required", response_data["error"]
|
|
assert response_data["mfa_required"]
|
|
end
|
|
|
|
test "should login with valid MFA code" do
|
|
user = users(:family_admin)
|
|
password = user_password_test
|
|
|
|
# Enable MFA for user
|
|
user.setup_mfa!
|
|
user.enable_mfa!
|
|
totp = ROTP::TOTP.new(user.otp_secret)
|
|
|
|
assert_difference("Doorkeeper::AccessToken.count", 1) do
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: password,
|
|
otp_code: totp.now,
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :success
|
|
response_data = JSON.parse(response.body)
|
|
assert response_data["access_token"].present?
|
|
end
|
|
|
|
test "should revoke existing tokens for same device on login" do
|
|
user = users(:family_admin)
|
|
password = user_password_test
|
|
|
|
# Create an existing device and token
|
|
device = user.mobile_devices.create!(@device_info)
|
|
existing_token = Doorkeeper::AccessToken.create!(
|
|
application: @shared_app,
|
|
resource_owner_id: user.id,
|
|
mobile_device_id: device.id,
|
|
expires_in: 30.days.to_i,
|
|
scopes: "read_write"
|
|
)
|
|
|
|
assert existing_token.accessible?
|
|
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: password,
|
|
device: @device_info
|
|
}
|
|
|
|
assert_response :success
|
|
|
|
# Check that old token was revoked
|
|
existing_token.reload
|
|
assert existing_token.revoked?
|
|
end
|
|
|
|
test "should not login with invalid password" do
|
|
user = users(:family_admin)
|
|
|
|
assert_no_difference("Doorkeeper::AccessToken.count") do
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: "wrong_password",
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :unauthorized
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Invalid email or password", response_data["error"]
|
|
end
|
|
|
|
test "should not login with non-existent email" do
|
|
assert_no_difference("Doorkeeper::AccessToken.count") do
|
|
post "/api/v1/auth/login", params: {
|
|
email: "nonexistent@example.com",
|
|
password: user_password_test,
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :unauthorized
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Invalid email or password", response_data["error"]
|
|
end
|
|
|
|
test "should login even when OAuth application is missing" do
|
|
user = users(:family_admin)
|
|
password = user_password_test
|
|
|
|
# Simulate a fresh instance where seeds were never run
|
|
Doorkeeper::Application.where(name: "Sure Mobile").destroy_all
|
|
MobileDevice.instance_variable_set(:@shared_oauth_application, nil)
|
|
|
|
assert_difference("Doorkeeper::Application.count", 1) do
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: password,
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :success
|
|
response_data = JSON.parse(response.body)
|
|
assert response_data["access_token"].present?
|
|
assert response_data["refresh_token"].present?
|
|
end
|
|
|
|
test "should not login without device info" do
|
|
user = users(:family_admin)
|
|
|
|
assert_no_difference("Doorkeeper::AccessToken.count") do
|
|
post "/api/v1/auth/login", params: {
|
|
email: user.email,
|
|
password: user_password_test
|
|
}
|
|
end
|
|
|
|
assert_response :bad_request
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Device information is required", response_data["error"]
|
|
end
|
|
|
|
test "should refresh access token with valid refresh token" do
|
|
user = users(:family_admin)
|
|
device = user.mobile_devices.create!(@device_info)
|
|
|
|
# Create initial token
|
|
initial_token = Doorkeeper::AccessToken.create!(
|
|
application: @shared_app,
|
|
resource_owner_id: user.id,
|
|
mobile_device_id: device.id,
|
|
expires_in: 30.days.to_i,
|
|
scopes: "read_write",
|
|
use_refresh_token: true
|
|
)
|
|
|
|
# Wait to ensure different timestamps
|
|
sleep 0.1
|
|
|
|
assert_difference("Doorkeeper::AccessToken.count", 1) do
|
|
post "/api/v1/auth/refresh", params: {
|
|
refresh_token: initial_token.refresh_token,
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :success
|
|
response_data = JSON.parse(response.body)
|
|
|
|
# New token assertions
|
|
assert response_data["access_token"].present?
|
|
assert response_data["refresh_token"].present?
|
|
assert_not_equal initial_token.token, response_data["access_token"]
|
|
assert_equal 2592000, response_data["expires_in"]
|
|
|
|
# Old token should be revoked
|
|
initial_token.reload
|
|
assert initial_token.revoked?
|
|
end
|
|
|
|
test "should not refresh with invalid refresh token" do
|
|
assert_no_difference("Doorkeeper::AccessToken.count") do
|
|
post "/api/v1/auth/refresh", params: {
|
|
refresh_token: "invalid_token",
|
|
device: @device_info
|
|
}
|
|
end
|
|
|
|
assert_response :unauthorized
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Invalid refresh token", response_data["error"]
|
|
end
|
|
|
|
test "should not refresh without refresh token" do
|
|
post "/api/v1/auth/refresh", params: {
|
|
device: @device_info
|
|
}
|
|
|
|
assert_response :bad_request
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "Refresh token is required", response_data["error"]
|
|
end
|
|
|
|
test "should enable ai for authenticated user" do
|
|
user = users(:family_admin)
|
|
user.update!(ai_enabled: false)
|
|
device = user.mobile_devices.create!(@device_info)
|
|
token = Doorkeeper::AccessToken.create!(application: @shared_app, resource_owner_id: user.id, mobile_device_id: device.id, scopes: "read_write")
|
|
|
|
patch "/api/v1/auth/enable_ai", headers: {
|
|
"Authorization" => "Bearer #{token.token}",
|
|
"Content-Type" => "application/json"
|
|
}
|
|
|
|
assert_response :success
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal true, response_data.dig("user", "ai_enabled")
|
|
assert_equal user.ui_layout, response_data.dig("user", "ui_layout")
|
|
assert_equal true, user.reload.ai_enabled
|
|
end
|
|
|
|
test "should require read_write scope to enable ai" do
|
|
user = users(:family_admin)
|
|
user.update!(ai_enabled: false)
|
|
device = user.mobile_devices.create!(@device_info)
|
|
token = Doorkeeper::AccessToken.create!(application: @shared_app, resource_owner_id: user.id, mobile_device_id: device.id, scopes: "read")
|
|
|
|
patch "/api/v1/auth/enable_ai", headers: {
|
|
"Authorization" => "Bearer #{token.token}",
|
|
"Content-Type" => "application/json"
|
|
}
|
|
|
|
assert_response :forbidden
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "insufficient_scope", response_data["error"]
|
|
assert_equal "This action requires the 'write' scope", response_data["message"]
|
|
assert_not user.reload.ai_enabled
|
|
end
|
|
|
|
test "should require authentication when enabling ai" do
|
|
patch "/api/v1/auth/enable_ai", headers: { "Content-Type" => "application/json" }
|
|
|
|
assert_response :unauthorized
|
|
end
|
|
|
|
test "should return forbidden when ai is not available" do
|
|
user = users(:family_admin)
|
|
user.update!(ai_enabled: false)
|
|
device = user.mobile_devices.create!(@device_info)
|
|
token = Doorkeeper::AccessToken.create!(application: @shared_app, resource_owner_id: user.id, mobile_device_id: device.id, scopes: "read_write")
|
|
User.any_instance.stubs(:ai_available?).returns(false)
|
|
|
|
patch "/api/v1/auth/enable_ai", headers: {
|
|
"Authorization" => "Bearer #{token.token}",
|
|
"Content-Type" => "application/json"
|
|
}
|
|
|
|
assert_response :forbidden
|
|
response_data = JSON.parse(response.body)
|
|
assert_equal "AI is not available for your account", response_data["error"]
|
|
assert_not user.reload.ai_enabled
|
|
end
|
|
end
|