mirror of
https://github.com/we-promise/sure.git
synced 2026-09-08 16:14:23 +00:00
Brandon
fe0d27471d
* feat(bills): the bills pages, calendar feed and in-page AI helpers Second of three chunks carved out of #3083, stacked on the schema and domain core. This is everything a user sees and clicks. The whole surface sits behind the preview flag, so it is unreachable until someone opts in. Pages, all under one nav entry: - the pay run, a month calendar, the full bills table, and the paycheck planner - a detail drawer per bill, with payment history, price changes and cost analytics - create and edit flows for bills, subscriptions, installment plans and income The overview marks pay periods inside the month, so a weekly paycheck no longer reads as one undifferentiated month of bills. Markers appear only when income actually subdivides the month, which means monthly and undeclared income render exactly as before and there is no new setting to configure. Navigation and design system: - one preview-gated nav item shared by the desktop rail and the mobile bar - DS::Sparkline for payment-history charts, replacing raw SVG in views - status badges render through DS::Pill rather than hand-rolled spans - the suggestions panel is a disclosure that remembers being collapsed, per device, the way privacy mode and the sidebar width already do - every surface reflows to phone widths without horizontal scroll Calendar feed: a signed ICS feed per family, served sessionless by token, with a reset that revokes previously shared URLs. In-page AI helpers: smart fill on the bill form and a smart configuration proposal on an existing bill, each reading a bounded slice of charge history. Provider-side prompt assembly sits behind the existing LlmConcept interface, with an implementation for each of the two providers. These belong here rather than with the assistant tools because they are buttons on these pages and lean on the provider suggester, not on the tool registry. Suite 7,776 runs green apart from the pre-existing passkey-session flake, which passes standalone. Rubocop clean, eager loading verified. The hosting guide for the feature ships here rather than with the schema, since its instructions walk pages this PR introduces. * Render the suggested strip through DS::Disclosure The hand-rolled details pair predates the component. The card_inset variant is the same shape, so the strip now inherits the design system chrome, and the persisted-disclosure controller rides along unchanged. * Route the remaining hand-rolled chips through the design system The subscription-state chips, rule-match chips and match-reason chips become DS::Pill, with the state chips extracted to one shared partial so the drawer and the summary tab stop carrying copy-pasted markup. The AI prompt chips become DS::Button and the bills-index filter becomes DS::SearchInput, both of which this PR already uses elsewhere for the same shapes. * Fix erb_lint whitespace offenses in bills views * Address the post-ready review round * Require a writable destination account and gate the feed on preview * Reject an unresolvable declared account out loud
78 lines
2.9 KiB
Ruby
78 lines
2.9 KiB
Ruby
# An extension to `link_to` helper. All options are passed through to the `link_to` helper with some additional
|
|
# options available.
|
|
class DS::Link < DS::Buttonish
|
|
attr_reader :frame
|
|
|
|
VARIANTS = VARIANTS.reverse_merge(
|
|
default: {
|
|
# Underline + `text-link` so the link is distinguishable by more
|
|
# than color alone (WCAG 1.4.1). Keyboard focus uses the canonical
|
|
# `.focus-ring` (#2136) so every primitive shares one indicator.
|
|
container_classes: "text-link underline underline-offset-2 hover:no-underline focus-ring",
|
|
icon_classes: "text-secondary"
|
|
}
|
|
).freeze
|
|
|
|
def merged_opts
|
|
merged_opts = opts.dup || {}
|
|
data = merged_opts.delete(:data) || {}
|
|
|
|
if frame
|
|
data = data.merge(turbo_frame: frame)
|
|
end
|
|
|
|
# `link_to method:` has been inert since the UJS removal -- Turbo drives
|
|
# non-GET links via `data-turbo-method` instead. Translate so a caller
|
|
# writing the natural `method: :post` gets a real POST, not a silent GET.
|
|
if (http_method = merged_opts.delete(:method))
|
|
data = data.merge(turbo_method: http_method)
|
|
end
|
|
|
|
# External link hardening: `target="_blank"` without `rel="noopener"`
|
|
# exposes window.opener to the new tab (reverse-tabnabbing). Always
|
|
# set `noopener noreferrer` when we send the user off-tab. Authors
|
|
# can override by passing `rel:` explicitly.
|
|
if merged_opts[:target].to_s == "_blank"
|
|
merged_opts[:rel] ||= "noopener noreferrer"
|
|
end
|
|
|
|
# Icon-only links have no visible text node, so screen readers fall
|
|
# back to announcing the href. Derive a humanized fallback from the
|
|
# icon key so AT users hear *something* meaningful; explicit
|
|
# `aria: { label: }` on the caller still wins. Mirrors DS::Button.
|
|
#
|
|
# When the link also opens in a new tab, fold the cue into the
|
|
# generated `aria-label` itself — `aria-label` overrides the
|
|
# descendant accessible name, so the sr-only "(opens in new tab)"
|
|
# span in the template would otherwise be masked.
|
|
if icon_only? && icon.present?
|
|
aria = (merged_opts[:aria] || {}).symbolize_keys
|
|
if aria[:label].blank? && merged_opts[:"aria-label"].blank?
|
|
label = icon.to_s.tr("-_", " ").humanize
|
|
if merged_opts[:target].to_s == "_blank"
|
|
label = "#{label} #{I18n.t("ds.link.opens_in_new_tab", default: "(opens in new tab)")}"
|
|
end
|
|
aria[:label] = label
|
|
merged_opts[:aria] = aria
|
|
end
|
|
end
|
|
|
|
merged_opts.merge(
|
|
class: class_names(container_classes, extra_classes),
|
|
data: data
|
|
)
|
|
end
|
|
|
|
# Render an sr-only suffix when the link opens in a new tab so AT
|
|
# users hear "(opens in new tab)" — visual is a separate concern
|
|
# (callers can render a `external-link` icon if they want a glyph).
|
|
def opens_in_new_tab?
|
|
opts[:target].to_s == "_blank"
|
|
end
|
|
|
|
private
|
|
def container_size_classes
|
|
super unless variant == :default
|
|
end
|
|
end
|