Files
sure/test/models/recurring_transaction/classifier_test.rb
T
Brandon 686205c0ff feat(bills): schema and domain core for the bills subsystem (#3201)
* feat(bills): schema and domain core for the bills subsystem

First of three chunks carved out of #3083. This one carries the schema and the
domain layer: no bills pages, no calendar feed, no assistant tools. Nothing here
is reachable from the UI yet, so it changes no user-visible behavior on its own.

Schema, in a single migration with a full down:

- recurrence_rules, recurring_occurrences, recurring_allocations,
  recurring_price_changes and recurring_match_rejections
- bill columns on recurring_transactions (bill_type, payment_url, autopay,
  notes, anchor and end conditions, weekend adjustment, dedup scope)
- the four data backfills, in their original order

Domain layer:

- Schedule, the pure date PORO every cadence resolves through, and
  FrequencyPreset for the labels
- OccurrenceGenerator, Matcher, Allocator, PriceChangeDetector, Classifier,
  DeclaredBill, HistoryBackfiller and PaycheckPlanner
- Pipeline, tying detection to generation, plus the nightly job and rake task

Existing detection code changed in three places, each a bug this schema exposes:

- Cleaner used a flat two-month staleness threshold, which silently retired
  every quarterly and annual series
- SubscriptionAuditGenerator used a flat 45-day overdue threshold, meaningless
  at both ends of the frequency range
- CashFlowWarningGenerator read one projected entry per series, which only
  equalled the monthly amount because every series was monthly; weekly bills
  were under-counted fourfold in its 30-day projection

The JSON API travels with the model rather than the UI, because the status enum
widens here. The API accepts only active and inactive on write; suggested,
paused and ended are lifecycle states owned by detection, so the documented
enum stays truthful.

Uniqueness keys gain dedup_scope alongside amount, never instead of it: a
series that is not price-forked carries a blank scope, so amount is what keeps
two different prices apart.

Suite 7,550 runs, 0 failures. Rubocop and brakeman clean. Eager loading
verified, and the migration reverses and re-applies. Includes the first review round: orphan repair matches income and refuses coincidental twins, session imports persist occurrence mappings across chunks, semimonthly anchors canonicalize, classifier keywords match whole words, and the down refuses rather than failing when price-forked rows exist.

* Address second review round

Bound the cross-currency default allocation by the entry leftover and the
occurrence remainder, matching the same-currency path. Let keyword stems
carry a suffix again after the word-boundary fix silenced them. Skip an
incoherent recurrence rule row instead of rolling back the whole import.
Check rollback collisions per restored index so a refusal cannot land
after the bills tables are dropped. Replay the closed_at test through a
real second import. Preload the orphan repair associations and move the
allocator errors to locale keys.

* Match index NULL semantics in the rollback collision checks

GROUP BY treats NULLs as equal but the restored unique indexes do not:
account_id is nullable and indexed, so two accountless rows can never
collide under any of them. Excluding NULL accounts keeps the guard from
refusing a rollback PostgreSQL can perform. Verified live both ways:
accountless duplicates roll back, a real collision still refuses.

* Address maintainer review

Scope the payable debt-destination subquery to the row and its family
instead of scanning every account in the installation. Batch the cash
flow generator remaining-amount sums into one grouped query, matching
the two sibling sites. Enforce both window bounds in the after_count
branch so a future-anchored plan cannot leak past the requested end
date. Skip the explicit regeneration when the day column change will
fire the model callback anyway. Add the missing locale entry for the
allocation currency validation.
2026-08-31 23:41:38 +02:00

125 lines
4.4 KiB
Ruby

require "test_helper"
class RecurringTransaction::ClassifierTest < ActiveSupport::TestCase
Classifier = RecurringTransaction::Classifier
def setup
@family = families(:dylan_family)
@depository = accounts(:depository)
@credit_card = accounts(:credit_card)
end
test "known services classify as subscriptions with autopay on" do
result = Classifier.classify(name: "Netflix.com", entries: entries_of(15.99, 15.99), account: @depository)
assert_equal "subscription", result.bill_type
assert result.autopay
end
test "utility and telecom wording classifies as a bill even when flat" do
result = Classifier.classify(name: "XFINITY INTERNET", entries: entries_of(89.99, 89.99), account: @credit_card)
assert_equal "bill", result.bill_type
assert_not result.autopay
end
test "ach and billpay descriptors are push payments, not subscriptions" do
result = Classifier.classify(name: "WATSON PROPERTY WEB PMT", entries: entries_of(537.50, 537.50), account: @depository)
assert_equal "bill", result.bill_type
end
test "a flat modest card charge with no name signal reads as a subscription" do
result = Classifier.classify(name: "SOMEOBSCURESERVICE", entries: entries_of(9.99, 9.99), account: @credit_card)
assert_equal "subscription", result.bill_type
end
test "varying amounts break the card-charge heuristic" do
result = Classifier.classify(name: "SOMEOBSCURESERVICE", entries: entries_of(42.17, 39.80), account: @credit_card)
assert_equal "bill", result.bill_type
end
test "interest charges never read as subscriptions someone chose" do
result = Classifier.classify(name: "Interest Charge", entries: entries_of(2.14, 2.14), account: @credit_card)
assert_equal "bill", result.bill_type
end
test "the series inherits the cluster's most common category" do
food = categories(:food_and_drink)
tagged = entries_of(12, 12, 12)
tagged.first(2).each { |entry| entry.entryable.update!(category: food) }
result = Classifier.classify(name: "MYSTERY BOX", entries: tagged, account: @depository)
assert_equal food.id, result.category_id
end
test "detection creates classified suggestions" do
@family.recurring_transactions.destroy_all
[ 0, 1, 2 ].each do |months_ago|
@credit_card.entries.create!(
date: months_ago.months.ago.beginning_of_month + 7.days,
amount: 15.99, currency: "USD", name: "SPOTIFY USA",
entryable: Transaction.new
)
end
RecurringTransaction::Identifier.new(@family).identify_recurring_patterns
created = @family.recurring_transactions.find_by(name: "SPOTIFY USA")
assert_equal "subscription", created.bill_type
assert created.autopay
assert_equal "suggested", created.status
end
# A substring test let "max" claim any Maxwell and "gas" claim a gastropub,
# and a false subscription match also set autopay, which hides the row from
# the needs-action list.
test "short keywords only match whole words" do
result = RecurringTransaction::Classifier.classify(
name: "Maxwell Plumbing", entries: entries_of(45)
)
assert_equal "bill", result.bill_type, "Maxwell is not HBO Max"
end
test "the real service names still match" do
result = RecurringTransaction::Classifier.classify(
name: "HBO MAX SUBSCRIPTION", entries: entries_of(15.99)
)
assert_equal "subscription", result.bill_type
end
# The word-boundary fix silently disabled the stems: utilit never
# matches UTILITIES. Starred stems accept a suffix without regaining the
# anywhere-in-the-word looseness the boundary fix removed.
test "keyword stems still reach their inflections" do
utilities = RecurringTransaction::Classifier.classify(
name: "AUSTIN UTILITIES", entries: entries_of(120)
)
assert_equal "bill", utilities.bill_type
assert_not utilities.autopay, "a utility is not autopay by default"
insurer = RecurringTransaction::Classifier.classify(
name: "STATE FARM INSUR PREM", entries: entries_of(140)
)
assert_equal "bill", insurer.bill_type
end
private
def entries_of(*amounts)
amounts.map.with_index do |amount, index|
@depository.entries.create!(
date: index.months.ago.to_date,
amount: amount,
currency: "USD",
name: "classifier test entry #{index}",
entryable: Transaction.new
)
end
end
end