mirror of
https://github.com/we-promise/sure.git
synced 2026-05-31 16:29:03 +00:00
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
117 lines
4.7 KiB
Plaintext
117 lines
4.7 KiB
Plaintext
<% content_for :title, t(".title") %>
|
|
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: t(".title")) do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "coins", class: "text-primary" %>
|
|
<span class="text-primary"><%= t(".subtitle") %></span>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% dialog.with_body do %>
|
|
<%= form_with url: complete_account_setup_binance_item_path(@binance_item),
|
|
method: :post,
|
|
local: true,
|
|
id: "binance-setup-form",
|
|
data: {
|
|
controller: "loading-button",
|
|
action: "submit->loading-button#showLoading",
|
|
loading_button_loading_text_value: t(".creating"),
|
|
turbo_frame: "_top"
|
|
},
|
|
class: "space-y-6" do |form| %>
|
|
|
|
<div class="space-y-4">
|
|
<div class="bg-surface border border-primary p-4 rounded-lg">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "info", size: "sm", class: "text-primary mt-0.5 flex-shrink-0" %>
|
|
<div>
|
|
<p class="text-sm text-primary">
|
|
<%= t(".instructions") %>
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="bg-surface border border-primary p-4 rounded-lg space-y-3">
|
|
<p class="text-sm font-medium text-primary"><%= t(".historical_import") %></p>
|
|
<div class="field">
|
|
<%= form.label :sync_start_date, t("settings.providers.binance_panel.sync_start_date_label"), class: "label" %>
|
|
<%= form.date_field :sync_start_date,
|
|
value: @binance_item.sync_start_date || (Date.current - 1.year),
|
|
max: Date.current,
|
|
class: "input" %>
|
|
<p class="help-text mt-1 text-xs text-secondary"><%= t("settings.providers.binance_panel.sync_start_date_help") %></p>
|
|
</div>
|
|
</div>
|
|
|
|
<% if @binance_accounts.empty? %>
|
|
<div class="text-center py-8">
|
|
<p class="text-secondary"><%= t(".no_accounts") %></p>
|
|
</div>
|
|
<% else %>
|
|
<div data-controller="select-all">
|
|
<div class="flex items-center justify-between mb-2">
|
|
<span class="text-sm text-secondary">
|
|
<%= t(".accounts_count", count: @binance_accounts.count) %>
|
|
</span>
|
|
<label class="flex items-center gap-2 text-sm cursor-pointer">
|
|
<input type="checkbox"
|
|
id="binance-select-all"
|
|
data-action="change->select-all#toggle"
|
|
class="checkbox checkbox--dark">
|
|
<span class="text-secondary"><%= t(".select_all") %></span>
|
|
</label>
|
|
</div>
|
|
|
|
<div class="space-y-2 max-h-96 overflow-y-auto">
|
|
<% @binance_accounts.each do |binance_account| %>
|
|
<label for="ba_<%= binance_account.id %>" class="flex items-center gap-3 p-3 border border-primary rounded-lg hover:bg-surface transition-colors cursor-pointer">
|
|
<%= check_box_tag "selected_accounts[]",
|
|
binance_account.id,
|
|
false,
|
|
id: "ba_#{binance_account.id}",
|
|
class: "checkbox checkbox--dark",
|
|
data: { select_all_target: "checkbox" } %>
|
|
<div class="flex-1 min-w-0">
|
|
<p class="font-medium text-primary truncate">
|
|
<%= binance_account.name %>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
<%= binance_account.currency %>
|
|
</p>
|
|
</div>
|
|
<div class="text-right shrink-0">
|
|
<p class="text-sm font-medium text-primary">
|
|
<%= number_with_delimiter(binance_account.current_balance || 0, delimiter: ",") %>
|
|
</p>
|
|
<p class="text-xs text-secondary">
|
|
<%= binance_account.currency %>
|
|
</p>
|
|
</div>
|
|
</label>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="flex gap-3">
|
|
<%= render DS::Button.new(
|
|
text: t(".import_selected"),
|
|
variant: "primary",
|
|
icon: "plus",
|
|
type: "submit",
|
|
class: "flex-1",
|
|
data: { loading_button_target: "button" }
|
|
) %>
|
|
<%= render DS::Link.new(
|
|
text: t(".cancel"),
|
|
variant: "secondary",
|
|
href: accounts_path
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|