mirror of
https://github.com/we-promise/sure.git
synced 2026-09-09 00:24:15 +00:00
Brandon
686205c0ff
* feat(bills): schema and domain core for the bills subsystem First of three chunks carved out of #3083. This one carries the schema and the domain layer: no bills pages, no calendar feed, no assistant tools. Nothing here is reachable from the UI yet, so it changes no user-visible behavior on its own. Schema, in a single migration with a full down: - recurrence_rules, recurring_occurrences, recurring_allocations, recurring_price_changes and recurring_match_rejections - bill columns on recurring_transactions (bill_type, payment_url, autopay, notes, anchor and end conditions, weekend adjustment, dedup scope) - the four data backfills, in their original order Domain layer: - Schedule, the pure date PORO every cadence resolves through, and FrequencyPreset for the labels - OccurrenceGenerator, Matcher, Allocator, PriceChangeDetector, Classifier, DeclaredBill, HistoryBackfiller and PaycheckPlanner - Pipeline, tying detection to generation, plus the nightly job and rake task Existing detection code changed in three places, each a bug this schema exposes: - Cleaner used a flat two-month staleness threshold, which silently retired every quarterly and annual series - SubscriptionAuditGenerator used a flat 45-day overdue threshold, meaningless at both ends of the frequency range - CashFlowWarningGenerator read one projected entry per series, which only equalled the monthly amount because every series was monthly; weekly bills were under-counted fourfold in its 30-day projection The JSON API travels with the model rather than the UI, because the status enum widens here. The API accepts only active and inactive on write; suggested, paused and ended are lifecycle states owned by detection, so the documented enum stays truthful. Uniqueness keys gain dedup_scope alongside amount, never instead of it: a series that is not price-forked carries a blank scope, so amount is what keeps two different prices apart. Suite 7,550 runs, 0 failures. Rubocop and brakeman clean. Eager loading verified, and the migration reverses and re-applies. Includes the first review round: orphan repair matches income and refuses coincidental twins, session imports persist occurrence mappings across chunks, semimonthly anchors canonicalize, classifier keywords match whole words, and the down refuses rather than failing when price-forked rows exist. * Address second review round Bound the cross-currency default allocation by the entry leftover and the occurrence remainder, matching the same-currency path. Let keyword stems carry a suffix again after the word-boundary fix silenced them. Skip an incoherent recurrence rule row instead of rolling back the whole import. Check rollback collisions per restored index so a refusal cannot land after the bills tables are dropped. Replay the closed_at test through a real second import. Preload the orphan repair associations and move the allocator errors to locale keys. * Match index NULL semantics in the rollback collision checks GROUP BY treats NULLs as equal but the restored unique indexes do not: account_id is nullable and indexed, so two accountless rows can never collide under any of them. Excluding NULL accounts keeps the guard from refusing a rollback PostgreSQL can perform. Verified live both ways: accountless duplicates roll back, a real collision still refuses. * Address maintainer review Scope the payable debt-destination subquery to the row and its family instead of scanning every account in the installation. Batch the cash flow generator remaining-amount sums into one grouped query, matching the two sibling sites. Enforce both window bounds in the after_count branch so a future-anchored plan cannot leak past the requested end date. Skip the explicit regeneration when the day column change will fire the model callback anyway. Add the missing locale entry for the allocation currency validation.
81 lines
2.9 KiB
YAML
81 lines
2.9 KiB
YAML
import_market_data:
|
|
cron: "0 22 * * 1-5" # 5:00 PM EST / 6:00 PM EDT (NY time) Monday through Friday
|
|
class: "ImportMarketDataJob"
|
|
queue: "scheduled"
|
|
description: "Imports market data daily at 5:00 PM EST (1 hour after market close)"
|
|
args:
|
|
mode: "full"
|
|
clear_cache: false
|
|
|
|
clean_syncs:
|
|
cron: "0 * * * *" # every hour
|
|
class: "SyncCleanerJob"
|
|
queue: "scheduled"
|
|
description: "Cleans up stale syncs and reaps imports, exports, and provider fetch flags stuck by lost jobs"
|
|
|
|
run_security_health_checks:
|
|
cron: "0 2 * * 1-5" # 2:00 AM EST / 3:00 AM EDT (NY time) Monday through Friday
|
|
class: "SecurityHealthCheckJob"
|
|
queue: "scheduled"
|
|
description: "Runs security health checks to detect issues with security data"
|
|
|
|
sync_hourly:
|
|
cron: "0 * * * *" # every hour at the top of the hour
|
|
class: "SyncHourlyJob"
|
|
queue: "scheduled"
|
|
description: "Syncs provider items that opt-in to hourly syncing"
|
|
|
|
sync_property_valuations:
|
|
cron: "30 1 1 * *" # monthly on the 1st at 1:30 AM
|
|
class: "SyncPropertyValuationsJob"
|
|
queue: "scheduled"
|
|
description: "Refreshes AVM property valuations once a month (providers enforce tight monthly request caps)"
|
|
|
|
clean_data:
|
|
cron: "0 3 * * *" # daily at 3:00 AM
|
|
class: "DataCleanerJob"
|
|
queue: "scheduled"
|
|
description: "Cleans up old data (e.g., expired merchant associations, expired archived exports)"
|
|
|
|
clean_debug_log_entries:
|
|
cron: "30 3 * * *" # daily at 3:30 AM
|
|
class: "DebugLogCleanupJob"
|
|
queue: "scheduled"
|
|
description: "Deletes debug log entries older than 90 days"
|
|
|
|
clean_inactive_families:
|
|
cron: "0 4 * * *" # daily at 4:00 AM
|
|
class: "InactiveFamilyCleanerJob"
|
|
queue: "scheduled"
|
|
description: "Archives and destroys families that expired their trial without subscribing (managed mode only)"
|
|
|
|
refresh_demo_family:
|
|
cron: "0 5 * * *" # daily at 5:00 AM UTC
|
|
class: "DemoFamilyRefreshJob"
|
|
queue: "scheduled"
|
|
description: "Refreshes demo family data and emails super admins with daily usage summary"
|
|
|
|
generate_recurring_occurrences:
|
|
cron: "30 5 * * *" # daily at 5:30 AM UTC, before insights so generators see fresh occurrences
|
|
class: "GenerateRecurringOccurrencesJob"
|
|
queue: "scheduled"
|
|
description: "Materializes the rolling window of recurring-transaction occurrences for every family"
|
|
|
|
generate_insights:
|
|
cron: "0 6 * * *" # daily at 6:00 AM UTC, after the nightly cleanup jobs
|
|
class: "GenerateInsightsJob"
|
|
queue: "scheduled"
|
|
description: "Generates proactive financial insights for families with preview features enabled"
|
|
|
|
sweep_expired_goal_pledges:
|
|
cron: "*/15 * * * *" # every 15 minutes
|
|
class: "SweepExpiredGoalPledgesJob"
|
|
queue: "scheduled"
|
|
description: "Marks goal pledges that passed their 7-day window as expired"
|
|
|
|
refresh_maintained_goal_targets:
|
|
cron: "0 3 1 * *" # 3:00 AM on the 1st of each month
|
|
class: "RefreshMaintainedGoalTargetsJob"
|
|
queue: "scheduled"
|
|
description: "Recomputes the floor of reserves expressed in months of expenses"
|