mirror of
https://github.com/we-promise/sure.git
synced 2026-08-12 11:10:20 +00:00
Guillem Arias
88032ce020
Reshape the goals feature to live on top of linked-account balances. A goal's balance is now the live balance of every depository account linked to it — no parallel ledger, no "log a contribution" step. The "Add contribution" affordance is replaced by a 7-day GoalPledge (kind: transfer | manual_save). GoalPledge::Reconciler matches incoming Transactions (via Account::ProviderImportAdapter) and Valuations (via Account::ReconciliationManager) against open pledges within ±5 days, ±$0.50, or ±1% — single hook covers every provider (Plaid, SimpleFIN, Lunchflow, Enable Banking, Brex, IBKR, Kraken, SnapTrade) plus manual balance edits. A 15-minute Sidekiq cron sweeps expired pledges. Goal model: balance derived from linked_accounts.sum(&:balance), new pace (90-day net non-transfer inflow), months_of_runway, last_matched_pledge_*, pledge_action_label_key (the "I just transferred…" vs "I just saved…" verb switch). UI: - Index gets a 3-card KPI strip (Contributed last 30d / Needs this month / On track) plus a pending-pledges callout. - Show page swaps the "Add contribution" CTA for the pledge modal, replaces the contribution list with a pending-pledge banner, and rebuilds the funding widget into per-account rows with a 12-bucket weekly sparkline and last-30 inflow. - Projection chart adds a required-line (dashed light from today → target) and a translucent pending-pledge bump at today's X. Schema (3 migrations): 1. goal_pledges table with PG enums (goal_pledge_kind, goal_pledge_status), open-by-expiry index, and unique-when-not-null matched_transaction_id. 2. Drop goal_contributions. 3. Partial unique index on transactions ((extra -> 'goal' ->> 'pledge_id')) built CONCURRENTLY so it doesn't block prod. After pulling: run bin/rails db:migrate, then commit the schema.rb sync separately (or let CI regenerate). Deferred to v1.1: allocation columns, contention/archived banners, "why is this behind?" diagnostic, reallocate flow, refresh-sync + Plaid throttle, unallocated-cash chip, joint-account approval, goal_activities log, polymorphic matched_entry_id/type for manual pledge audit.
28 lines
1.3 KiB
Ruby
28 lines
1.3 KiB
Ruby
class CreateGoalPledges < ActiveRecord::Migration[7.2]
|
|
def change
|
|
create_enum :goal_pledge_kind, %w[transfer manual_save]
|
|
create_enum :goal_pledge_status, %w[open matched cancelled expired]
|
|
|
|
create_table :goal_pledges, id: :uuid do |t|
|
|
t.references :goal, null: false, foreign_key: { on_delete: :cascade }, type: :uuid
|
|
t.references :account, null: false, foreign_key: { on_delete: :restrict }, type: :uuid
|
|
t.decimal :amount, precision: 19, scale: 4, null: false
|
|
t.string :currency, null: false
|
|
t.enum :kind, enum_type: :goal_pledge_kind, null: false
|
|
t.enum :status, enum_type: :goal_pledge_status, default: "open", null: false
|
|
t.datetime :expires_at, null: false
|
|
t.uuid :matched_transaction_id
|
|
|
|
t.timestamps
|
|
end
|
|
|
|
add_foreign_key :goal_pledges, :transactions, column: :matched_transaction_id, on_delete: :nullify
|
|
|
|
add_index :goal_pledges, [ :goal_id, :status ]
|
|
add_index :goal_pledges, [ :status, :expires_at ], where: "status = 'open'", name: "index_goal_pledges_open_by_expiry"
|
|
add_index :goal_pledges, :matched_transaction_id, unique: true, where: "matched_transaction_id IS NOT NULL"
|
|
|
|
add_check_constraint :goal_pledges, "amount > 0", name: "chk_goal_pledges_amount_positive"
|
|
end
|
|
end
|