Files
sure/app/models/lunchflow_entry/processor.rb
AdamWHY2K 3f5fff27ea feat: process pending transactions from lunchflow (#731)
* feat(config): add Lunchflow runtime configuration flags

* feat(api): add include_pending parameter to Lunchflow API

* feat(processor): add pending metadata support to Lunchflow processor

* feat(processor): generate temporary IDs for pending transactions

* feat(importer): integrate pending transaction support in sync

* fix(importer): improve deduplication for transactions without IDs

* feat(model): add Lunchflow pending support to Transaction scopes

* test: add Lunchflow processor pending metadata tests

* docs: update AGENTS.md for Lunchflow pending support

* chore: remove unused variable

* fix: simplify key check

* fix: dotenv-linter key order

* fix: avoid collapsing distinct pending transactions

* fix: prevent unbounded raw payload growth for blank IDs
2026-01-23 00:53:24 +01:00

197 lines
6.8 KiB
Ruby

require "digest/md5"
class LunchflowEntry::Processor
include CurrencyNormalizable
include LunchflowTransactionHash
# lunchflow_transaction is the raw hash fetched from Lunchflow API and converted to JSONB
# Transaction structure: { id, accountId, amount, currency, date, merchant, description, isPending }
def initialize(lunchflow_transaction, lunchflow_account:)
@lunchflow_transaction = lunchflow_transaction
@lunchflow_account = lunchflow_account
end
def process
# Validate that we have a linked account before processing
unless account.present?
Rails.logger.warn "LunchflowEntry::Processor - No linked account for lunchflow_account #{lunchflow_account.id}, skipping transaction #{external_id}"
return nil
end
# Wrap import in error handling to catch validation and save errors
begin
import_adapter.import_transaction(
external_id: external_id,
amount: amount,
currency: currency,
date: date,
name: name,
source: "lunchflow",
merchant: merchant,
notes: notes,
extra: extra_metadata
)
rescue ArgumentError => e
# Re-raise validation errors (missing required fields, invalid data)
Rails.logger.error "LunchflowEntry::Processor - Validation error for transaction #{external_id}: #{e.message}"
raise
rescue ActiveRecord::RecordInvalid, ActiveRecord::RecordNotSaved => e
# Handle database save errors
Rails.logger.error "LunchflowEntry::Processor - Failed to save transaction #{external_id}: #{e.message}"
raise StandardError.new("Failed to import transaction: #{e.message}")
rescue => e
# Catch unexpected errors with full context
Rails.logger.error "LunchflowEntry::Processor - Unexpected error processing transaction #{external_id}: #{e.class} - #{e.message}"
Rails.logger.error e.backtrace.join("\n")
raise StandardError.new("Unexpected error importing transaction: #{e.message}")
end
end
private
attr_reader :lunchflow_transaction, :lunchflow_account
def import_adapter
@import_adapter ||= Account::ProviderImportAdapter.new(account)
end
def account
@account ||= lunchflow_account.current_account
end
def data
@data ||= lunchflow_transaction.with_indifferent_access
end
def external_id
id = data[:id].presence
# For pending transactions, Lunchflow may return blank/nil IDs
# Generate a stable temporary ID based on transaction attributes
if id.blank?
# Create a deterministic hash from key transaction attributes
# This ensures the same pending transaction gets the same ID across syncs
base_temp_id = content_hash_for_transaction(data)
temp_id_with_prefix = "lunchflow_pending_#{base_temp_id}"
# Handle collisions: if this external_id already exists for this account,
# append a counter to make it unique. This prevents multiple pending transactions
# with identical attributes (e.g., two same-day Uber rides) from colliding.
# We check both the account's entries and the current raw payload being processed.
final_id = temp_id_with_prefix
counter = 1
while entry_exists_with_external_id?(final_id)
final_id = "#{temp_id_with_prefix}_#{counter}"
counter += 1
end
if counter > 1
Rails.logger.debug "Lunchflow: Collision detected, using #{final_id} for pending transaction: #{data[:merchant]} #{data[:amount]} #{data[:currency]}"
else
Rails.logger.debug "Lunchflow: Generated temporary ID #{final_id} for pending transaction: #{data[:merchant]} #{data[:amount]} #{data[:currency]}"
end
return final_id
end
"lunchflow_#{id}"
end
def entry_exists_with_external_id?(external_id)
return false unless account.present?
# Check if an entry with this external_id already exists in the account
account.entries.exists?(external_id: external_id, source: "lunchflow")
end
def name
data[:merchant].presence || "Unknown transaction"
end
def notes
data[:description].presence
end
def merchant
return nil unless data[:merchant].present?
# Create a stable merchant ID from the merchant name
# Using digest to ensure uniqueness while keeping it deterministic
merchant_name = data[:merchant].to_s.strip
return nil if merchant_name.blank?
merchant_id = Digest::MD5.hexdigest(merchant_name.downcase)
@merchant ||= begin
import_adapter.find_or_create_merchant(
provider_merchant_id: "lunchflow_merchant_#{merchant_id}",
name: merchant_name,
source: "lunchflow"
)
rescue ActiveRecord::RecordInvalid => e
Rails.logger.error "LunchflowEntry::Processor - Failed to create merchant '#{merchant_name}': #{e.message}"
nil
end
end
def amount
parsed_amount = case data[:amount]
when String
BigDecimal(data[:amount])
when Numeric
BigDecimal(data[:amount].to_s)
else
BigDecimal("0")
end
# Lunchflow likely uses standard convention where negative is expense, positive is income
# Maybe expects opposite convention (expenses positive, income negative)
# So we negate the amount to convert from Lunchflow to Maybe format
-parsed_amount
rescue ArgumentError => e
Rails.logger.error "Failed to parse Lunchflow transaction amount: #{data[:amount].inspect} - #{e.message}"
raise
end
def currency
parse_currency(data[:currency]) || account&.currency || "USD"
end
def log_invalid_currency(currency_value)
Rails.logger.warn("Invalid currency code '#{currency_value}' in LunchFlow transaction #{external_id}, falling back to account currency")
end
def date
case data[:date]
when String
Date.parse(data[:date])
when Integer, Float
# Unix timestamp
Time.at(data[:date]).to_date
when Time, DateTime
data[:date].to_date
when Date
data[:date]
else
Rails.logger.error("Lunchflow transaction has invalid date value: #{data[:date].inspect}")
raise ArgumentError, "Invalid date format: #{data[:date].inspect}"
end
rescue ArgumentError, TypeError => e
Rails.logger.error("Failed to parse Lunchflow transaction date '#{data[:date]}': #{e.message}")
raise ArgumentError, "Unable to parse transaction date: #{data[:date].inspect}"
end
# Build extra metadata hash with pending status
# Lunchflow API field: isPending (boolean)
def extra_metadata
metadata = {}
# Store pending status from Lunchflow API when present
if data.key?(:isPending)
metadata[:lunchflow] = { pending: ActiveModel::Type::Boolean.new.cast(data[:isPending]) }
end
metadata
end
end