mirror of
https://github.com/we-promise/sure.git
synced 2026-07-12 21:05:20 +00:00
9487e6cbfb
* feat(api): allow multiple active API keys per user Previously a user could hold only one active API key; creating a new one silently revoked the existing key, breaking any app using it. Allow multiple named active keys instead. - Drop the one-active-key-per-source validation; add name uniqueness among the user's active visible keys (revoked names are reusable, same name allowed across users). - Rewrite Settings::ApiKeysController as a RESTful collection (index/show/new/create/destroy); create no longer revokes existing keys, and key lookup is scoped to the current user's active keys. - resource :api_key -> resources :api_keys. - Add an API keys list view with per-key revoke and an empty state; rewrite the show page for a single key. - Update i18n (remove single-key copy, pluralise nav label) and tests. * refactor(api): address review on multiple API keys - Remove unreachable destroy branches (cannot_revoke is guarded by the .visible 404; revoke! raises rather than returning false) and document that .visible is the demo-key revocation guard. - Delete the orphaned created.html.erb / created.turbo_stream.erb templates (no action renders them) and their unused locale keys. - Extract shared partials (_scope_badges, _status_indicator, _key_meta, _key_reveal, _usage) to de-duplicate the index and show views; unify the active-status indicator on the standard dot. - Carry forward the @container / @lg:flex-row / min-w-0 responsive fixes from #2079 into the shared key-reveal partial. * test(api): cover newly-created API key confirmation render * refactor(api): harden demo-key guard and address review nits - Document the demo-key revocation guard on ApiKey's `visible` scope (the authoritative spot) and add a model test locking the invariant that `.visible` excludes the demo monitoring key. - _scope_badges: use an i18n lookup with a humanize fallback instead of bypassing translation for unknown scopes. - _key_reveal: drop the hard-coded `id` from the shared partial; the system test now locates the key via its data-clipboard-target. * refactor(api-keys): migrate hand-rolled badges to DS::Pill Replace raw span elements in scope badges and status indicator with DS::Pill to align with the design system migration convention. * fix(loans): opening anchor now uses current balance, not original principal When creating a loan manually, the opening anchor valuation was being set to `initial_balance` (the original loan principal) instead of `account.balance` (the current outstanding balance). After the sync job ran, `account.balance` was overwritten to match the anchor, making every manually-created loan show its original principal as the current balance. Fix by always using `account.balance` for the opening anchor in `create_and_sync`, and reading `Loan#original_balance` from the `loans.initial_balance` column directly (with a fallback to `first_valuation_amount` for provider-synced loans that may not have the column populated). * fix(api-keys): strip accidental loan changes; rescue revoke! failures The fix(loans) commit was accidentally committed into this branch. Remove the loan-related changes from account.rb, loan.rb, and both test files, restoring them to their pre-loan-commit state. Also fix the destroy action: revoke! uses update! internally which raises ActiveRecord::RecordInvalid on failure rather than returning false. Add rescue for RecordInvalid and RecordNotDestroyed so failures produce a flash alert instead of a 500. Re-adds the revoke_failed locale key that was dropped from settings.api_keys.destroy. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
73 lines
2.4 KiB
Plaintext
73 lines
2.4 KiB
Plaintext
<%= content_for :page_title, t(".title") %>
|
|
<% unless @api_keys.empty? %>
|
|
<%= content_for :page_actions do %>
|
|
<%= render DS::Link.new(
|
|
text: t(".new_key"),
|
|
href: new_settings_api_key_path,
|
|
variant: "primary",
|
|
icon: "plus"
|
|
) %>
|
|
<% end %>
|
|
<% end %>
|
|
|
|
<% if @api_keys.empty? %>
|
|
<div class="bg-container rounded-xl shadow-border-xs p-4">
|
|
<div class="bg-surface-inset rounded-xl p-8 text-center">
|
|
<div class="flex justify-center mb-4">
|
|
<%= render DS::FilledIcon.new(
|
|
icon: "key",
|
|
rounded: true,
|
|
size: "lg"
|
|
) %>
|
|
</div>
|
|
<h3 class="font-medium text-primary"><%= t(".empty_heading") %></h3>
|
|
<p class="text-secondary text-sm mt-1 mb-4"><%= t(".empty_description") %></p>
|
|
<div class="flex justify-center">
|
|
<%= render DS::Link.new(
|
|
text: t(".new_key"),
|
|
href: new_settings_api_key_path,
|
|
variant: "primary",
|
|
icon: "plus"
|
|
) %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% else %>
|
|
<div class="space-y-3">
|
|
<% @api_keys.each do |api_key| %>
|
|
<div class="bg-container rounded-xl shadow-border-xs p-4">
|
|
<div class="flex items-start justify-between gap-3">
|
|
<div class="flex items-start gap-3 min-w-0">
|
|
<%= render DS::FilledIcon.new(
|
|
icon: "key",
|
|
rounded: true,
|
|
size: "lg"
|
|
) %>
|
|
<div class="text-sm space-y-1 min-w-0">
|
|
<%= link_to api_key.name, settings_api_key_path(api_key), class: "text-primary font-medium hover:underline break-all" %>
|
|
<%= render "settings/api_keys/key_meta", api_key: api_key %>
|
|
<div class="pt-1">
|
|
<%= render "settings/api_keys/scope_badges", scopes: api_key.scopes %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="flex items-center gap-3 shrink-0">
|
|
<%= render "settings/api_keys/status_indicator" %>
|
|
<%= render DS::Button.new(
|
|
text: t(".revoke_key"),
|
|
href: settings_api_key_path(api_key),
|
|
method: :delete,
|
|
variant: "destructive",
|
|
size: "sm",
|
|
data: {
|
|
turbo_confirm: t(".revoke_confirmation", name: api_key.name)
|
|
}
|
|
) %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|