Files
sure/test/controllers/oidc_accounts_controller_test.rb
LPW b23711ae0d Add configurable multi-provider SSO, SSO-only mode, and JIT controls via auth.yml (#441)
* Add configuration and logic for dynamic SSO provider support and stricter JIT account creation

- Introduced `config/auth.yml` for centralized auth configuration and documentation.
- Added support for multiple SSO providers, including Google, GitHub, and OpenID Connect.
- Implemented stricter JIT SSO account creation modes (`create_and_link` vs `link_only`).
- Enabled optional restriction of JIT creation by allowed email domains.
- Enhanced OmniAuth initializer for dynamic provider setup and better configurability.
- Refined login UI to handle local login disabling and emergency super-admin override.
- Updated account creation flow to respect JIT mode and domain checks.
- Added tests for SSO account creation, login form visibility, and emergency overrides.

# Conflicts:
#	app/controllers/sessions_controller.rb

* remove non-translation

* Refactor authentication views to use translation keys and update locale files

- Extracted hardcoded strings in `oidc_accounts/link.html.erb` and `sessions/new.html.erb` into translation keys for better localization support.
- Added missing translations for English and Spanish in `sessions` and `oidc_accounts` locale files.

* Enhance OmniAuth provider configuration and refine local login override logic

- Updated OmniAuth initializer to support dynamic provider configuration with `name` and scoped parameters for Google and GitHub.
- Improved local login logic to enforce stricter handling of super-admin override when local login is disabled.
- Added test for invalid super-admin override credentials.

* Document Google sign-in configuration for local development and self-hosted environments

---------

Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
2025-12-24 00:15:53 +01:00

195 lines
5.5 KiB
Ruby

require "test_helper"
class OidcAccountsControllerTest < ActionController::TestCase
setup do
@user = users(:family_admin)
end
def pending_auth
{
"provider" => "openid_connect",
"uid" => "new-uid-12345",
"email" => @user.email,
"name" => "Bob Dylan",
"first_name" => "Bob",
"last_name" => "Dylan"
}
end
test "should show link page when pending auth exists" do
session[:pending_oidc_auth] = pending_auth
get :link
assert_response :success
end
test "should redirect to login when no pending auth" do
get :link
assert_redirected_to new_session_path
assert_equal "No pending OIDC authentication found", flash[:alert]
end
test "should create OIDC identity with valid password" do
session[:pending_oidc_auth] = pending_auth
assert_difference "OidcIdentity.count", 1 do
post :create_link,
params: {
email: @user.email,
password: user_password_test
}
end
assert_redirected_to root_path
assert_not_nil @user.oidc_identities.find_by(
provider: pending_auth["provider"],
uid: pending_auth["uid"]
)
end
test "should reject linking with invalid password" do
session[:pending_oidc_auth] = pending_auth
assert_no_difference "OidcIdentity.count" do
post :create_link,
params: {
email: @user.email,
password: "wrongpassword"
}
end
assert_response :unprocessable_entity
assert_equal "Invalid email or password", flash[:alert]
end
test "should redirect to MFA when user has MFA enabled" do
@user.setup_mfa!
@user.enable_mfa!
session[:pending_oidc_auth] = pending_auth
post :create_link,
params: {
email: @user.email,
password: user_password_test
}
assert_redirected_to verify_mfa_path
end
test "should reject create_link when no pending auth" do
post :create_link, params: {
email: @user.email,
password: user_password_test
}
assert_redirected_to new_session_path
assert_equal "No pending OIDC authentication found", flash[:alert]
end
# New user registration tests
def new_user_auth
{
"provider" => "openid_connect",
"uid" => "new-uid-99999",
"email" => "newuser@example.com",
"name" => "New User",
"first_name" => "New",
"last_name" => "User"
}
end
test "should show create account option for new user" do
session[:pending_oidc_auth] = new_user_auth
get :link
assert_response :success
assert_select "h3", text: "Create New Account"
assert_select "strong", text: new_user_auth["email"]
end
test "does not show create account button when JIT link-only mode" do
session[:pending_oidc_auth] = new_user_auth
AuthConfig.stubs(:jit_link_only?).returns(true)
AuthConfig.stubs(:allowed_oidc_domain?).returns(true)
get :link
assert_response :success
assert_select "h3", text: "Create New Account"
# No create account button rendered
assert_select "button", text: "Create Account", count: 0
assert_select "p", text: /New account creation via single sign-on is disabled/
end
test "create_user redirects when JIT link-only mode" do
session[:pending_oidc_auth] = new_user_auth
AuthConfig.stubs(:jit_link_only?).returns(true)
AuthConfig.stubs(:allowed_oidc_domain?).returns(true)
assert_no_difference [ "User.count", "OidcIdentity.count", "Family.count" ] do
post :create_user
end
assert_redirected_to new_session_path
assert_equal "SSO account creation is disabled. Please contact an administrator.", flash[:alert]
end
test "create_user redirects when email domain not allowed" do
disallowed_auth = new_user_auth.merge("email" => "newuser@notallowed.com")
session[:pending_oidc_auth] = disallowed_auth
AuthConfig.stubs(:jit_link_only?).returns(false)
AuthConfig.stubs(:allowed_oidc_domain?).with(disallowed_auth["email"]).returns(false)
assert_no_difference [ "User.count", "OidcIdentity.count", "Family.count" ] do
post :create_user
end
assert_redirected_to new_session_path
assert_equal "SSO account creation is disabled. Please contact an administrator.", flash[:alert]
end
test "should create new user account via OIDC" do
session[:pending_oidc_auth] = new_user_auth
assert_difference [ "User.count", "OidcIdentity.count", "Family.count" ], 1 do
post :create_user
end
assert_redirected_to root_path
assert_equal "Welcome! Your account has been created.", flash[:notice]
# Verify user was created with correct details
new_user = User.find_by(email: new_user_auth["email"])
assert_not_nil new_user
assert_equal new_user_auth["first_name"], new_user.first_name
assert_equal new_user_auth["last_name"], new_user.last_name
assert_equal "admin", new_user.role
# Verify OIDC identity was created
oidc_identity = new_user.oidc_identities.first
assert_not_nil oidc_identity
assert_equal new_user_auth["provider"], oidc_identity.provider
assert_equal new_user_auth["uid"], oidc_identity.uid
end
test "should create session after OIDC registration" do
session[:pending_oidc_auth] = new_user_auth
post :create_user
# Verify session was created
new_user = User.find_by(email: new_user_auth["email"])
assert Session.exists?(user_id: new_user.id)
end
test "should reject create_user when no pending auth" do
post :create_user
assert_redirected_to new_session_path
assert_equal "No pending OIDC authentication found", flash[:alert]
end
end