Files
sure/app/views/settings/providers/_ibkr_panel.html.erb
Guillem Arias Fauste cdce00c71e refactor(design-system): migrate 38 hand-rolled provider buttons to DS::Button / DS::Link (#1715 §5 part B) (#1860)
* refactor(design-system): migrate 9 hand-rolled buttons with orphan btn-- classes to DS::Button / DS::Link

Part of #1715 §5. The `btn`, `btn--primary`, `btn--outline`, `btn--ghost`,
`btn--sm` CSS classes have no backing styles anywhere in the codebase
(no .btn definition in app/assets/, no Bootstrap dependency). These
callsites have been rendering unstyled buttons / links since the
underlying CSS was last removed.

Migrate the 9 broken callsites:

- `app/views/transactions/show.html.erb` — duplicate-merge action
  buttons (×2): `button_to ... class: "btn btn--primary btn--sm"` /
  `class: "btn btn--outline btn--sm"` → DS::Button with href +
  variant + size + `data: { turbo_method: :post }`.
- `app/views/snaptrade_items/select_existing_account.html.erb` —
  "Go to Provider Settings" link → DS::Link primary sm.
- `app/views/indexa_capital_items/select_existing_account.html.erb` —
  same pattern → DS::Link primary sm.
- `app/views/import/confirms/show.html.erb` — Publish button +
  Cancel link → DS::Button primary full-width + DS::Link ghost
  full-width.
- `app/views/simplefin_items/new.html.erb` — Cancel link
  (`class: "btn"` only) + Connect submit → DS::Link secondary +
  bare `f.submit` (already routes to DS::Button via
  StyledFormBuilder).
- `app/views/settings/providers/_ibkr_panel.html.erb`,
  `_snaptrade_panel.html.erb`,
  `_indexa_capital_panel.html.erb` — strip the orphan
  `class: "btn btn--primary"` from `f.submit` callers; the submit
  is already a styled DS::Button via the form builder.

The next PR in this chain (Phase B) will tackle the larger inline-
button cluster (~29 files, 38 instances) — provider panels and
provider-item flows hand-rolling the same
`inline-flex items-center justify-center rounded-lg px-4 py-2
text-sm font-medium text-inverse bg-inverse hover:bg-inverse-hover
focus:outline-none focus:ring-2 focus:ring-primary transition-colors`
string.

* refactor(design-system): migrate 38 hand-rolled provider buttons to DS::Button / DS::Link (#1715 §5 part B)

Bulk sweep of the second cluster from §5. 29 files, 38 button
instances — each one hand-rolled the same long Tailwind string for
the primary action button:

  inline-flex items-center justify-center rounded-lg px-4 py-2
  text-sm font-medium text-inverse bg-inverse hover:bg-inverse-hover
  focus:outline-none focus:ring-2 focus:ring-primary transition-colors

(some variations used `button-bg-primary hover:button-bg-primary-hover`
instead of `bg-inverse hover:bg-inverse-hover` — same intent).

Every instance is now a DS::Button / DS::Link with `variant: :primary`,
which:

- Picks up the new focus-ring + touch-target work from #1840 once
  that merges.
- Stops duplicating the long Tailwind string across 29 files —
  single source of truth in `DS::Buttonish::VARIANTS[:primary]`.
- Picks up consistent `aria-label` derivation for icon-only forms.
- Removes the misnamed `focus:ring-primary` (no token) — the new
  ring comes from `base.css` automatically.

Migration patterns applied:

- `f.submit text, class: "inline-flex …"` inside `styled_form_with`
  → bare `<%= f.submit text %>`. StyledFormBuilder routes through
  DS::Button.
- `link_to text, path, class: "inline-flex …"` → DS::Link primary.
- `button_to text, path, method: :X, class: "inline-flex …"` →
  DS::Button with `href: path` and `data: { turbo_method: :X }`.
- `submit_tag text, class: "inline-flex …"` inside raw `form_with`
  → DS::Button with `type: :submit`.

Notable adjustments:

- `holdings/show.html.erb` — the form was `form_with` (not styled).
  Switched to `styled_form_with` so `f.submit` routes through
  DS::Button. `f.combobox` (hotwire_combobox) still works through
  the styled builder.
- Two `link_to settings_providers_path` callsites in
  `coinstats_items/new.html.erb` + `enable_banking_items/new.html.erb`
  had `w-full inline-flex … hidden md:inline-flex` — the responsive
  pair conflicted (both `inline-flex` and `hidden md:inline-flex`
  on the same element). Migrated to `full_width: true` without the
  responsive split; the buttons now render at all breakpoints
  consistently. (Pre-existing copy-paste bug, fixed in passing.)
- `enable_banking_panel` add-connection button gained
  `icon: "plus"` via the DS::Button API; the explicit `gap-2 …
  icon "plus"` markup is now redundant.

Sibling buttons that don't match the primary spec (destructive
trash, secondary outline-bordered, button-bg-secondary-strong on
holdings/show.html.erb, etc.) are intentionally left alone — they
need their own audit pass once #1840 lands and the focus-ring
behavior on those variants is stable.

* fix(review): restore SimpleFIN submit styling + i18n provider_form label

- SimpleFIN new modal: switch form_with -> styled_form_with so f.submit
  picks up the DS::Button render via styled builder (Codex #1860).
- _provider_form: replace hardcoded "Save and connect" with t(".save_and_connect")
  and add scoped key under settings.providers.provider_form (CodeRabbit).
2026-05-20 18:15:15 +02:00

153 lines
6.6 KiB
Plaintext

<div id="ibkr-providers-panel" class="space-y-4">
<% error_msg = local_assigns[:error_message] || @error_message %>
<% if error_msg.present? %>
<%= render DS::Alert.new(message: error_msg, variant: :error) %>
<% end %>
<%= render "settings/providers/setup_steps",
steps: [
t(".steps.step_1"),
t(".steps.step_2"),
t(".steps.step_3"),
t(".steps.step_4"),
t(".steps.step_5")
] %>
<details class="group bg-surface-inset rounded-xl p-4">
<summary class="list-none cursor-pointer [&::-webkit-details-marker]:hidden">
<div class="flex items-start justify-between gap-3">
<div>
<p class="text-xs font-medium uppercase text-subdued tracking-wider mb-2"><%= t(".flex_query_details.eyebrow") %></p>
<p class="text-sm font-medium text-primary"><%= t(".flex_query_details.title") %></p>
<p class="text-xs text-secondary mt-1"><%= t(".flex_query_details.summary") %></p>
</div>
<%= icon "chevron-down", class: "mt-0.5 text-secondary transition-transform group-open:rotate-180" %>
</div>
</summary>
<div class="mt-4 space-y-4 text-sm text-secondary">
<div class="space-y-2">
<p class="font-medium text-primary"><%= t(".flex_query_details.sections_heading") %></p>
<ul class="list-disc list-inside space-y-2">
<li>
<span class="text-primary"><%= t(".sections.account_information") %></span>
</li>
<li>
<span class="text-primary"><%= t(".sections.cash_report") %></span>
<ul class="list-disc list-inside mt-1 ml-4 space-y-1">
<li><%= t(".sections.cash_report_options") %></li>
<li><%= t(".sections.cash_report_fields") %></li>
</ul>
</li>
<li>
<span class="text-primary"><%= t(".sections.cash_transactions") %></span>
<ul class="list-disc list-inside mt-1 ml-4 space-y-1">
<li><%= t(".sections.cash_transactions_options") %></li>
<li><%= t(".sections.cash_transactions_fields") %></li>
</ul>
</li>
<li>
<span class="text-primary"><%= t(".sections.change_in_position_value_summary") %></span>
</li>
<li>
<span class="text-primary"><%= t(".sections.net_asset_value") %></span>
<ul class="list-disc list-inside mt-1 ml-4 space-y-1">
<li><%= t(".sections.net_asset_value_options") %></li>
<li><%= t(".sections.net_asset_value_fields") %></li>
</ul>
</li>
<li>
<span class="text-primary"><%= t(".sections.open_positions") %></span>
<ul class="list-disc list-inside mt-1 ml-4 space-y-1">
<li><%= t(".sections.open_positions_options") %></li>
<li><%= t(".sections.open_positions_fields") %></li>
</ul>
</li>
<li>
<span class="text-primary"><%= t(".sections.trades") %></span>
<ul class="list-disc list-inside mt-1 ml-4 space-y-1">
<li><%= t(".sections.trades_options") %></li>
<li><%= t(".sections.trades_fields") %></li>
</ul>
</li>
</ul>
</div>
<div class="space-y-2">
<p class="font-medium text-primary"><%= t(".flex_query_details.configuration_heading") %></p>
<ul class="list-disc list-inside space-y-1">
<li><%= t(".configuration.models") %></li>
<li><%= t(".configuration.format") %></li>
<li><%= t(".configuration.period") %></li>
<li><%= t(".configuration.date_format") %></li>
<li><%= t(".configuration.time_format") %></li>
<li><%= t(".configuration.date_time_separator") %></li>
<li><%= t(".configuration.profit_and_loss") %></li>
<li><%= t(".configuration.all_other_options") %></li>
</ul>
</div>
<p class="text-xs text-secondary"><%= t(".report_window_note") %></p>
</div>
</details>
<%
ibkr_item = Current.family.ibkr_items.first_or_initialize(name: "Interactive Brokers")
is_new_record = ibkr_item.new_record?
%>
<% if ibkr_item.persisted? %>
<div class="flex flex-wrap justify-end gap-2">
<%= button_to sync_ibkr_item_path(ibkr_item),
method: :post,
class: "inline-flex items-center gap-1 px-3 py-1.5 text-sm font-medium text-secondary hover:text-primary border border-secondary rounded-lg hover:border-primary",
disabled: ibkr_item.syncing? do %>
<%= icon "refresh-cw", size: "sm" %>
<%= t(".sync") %>
<% end %>
<%= button_to ibkr_item_path(ibkr_item),
method: :delete,
class: "inline-flex items-center gap-1 px-3 py-1.5 text-sm font-medium text-destructive hover:bg-destructive/10 rounded-lg",
data: { turbo_confirm: t(".disconnect_confirm") } do %>
<%= icon "trash-2", size: "sm" %>
<% end %>
</div>
<% end %>
<%= styled_form_with model: ibkr_item,
url: is_new_record ? ibkr_items_path : ibkr_item_path(ibkr_item),
scope: :ibkr_item,
method: is_new_record ? :post : :patch,
data: { turbo: true },
class: "space-y-3" do |form| %>
<%= form.text_field :query_id,
label: t(".query_id_label"),
placeholder: is_new_record ? t(".query_id_placeholder_new") : t(".query_id_placeholder_existing"),
type: :password %>
<%= form.text_field :token,
label: t(".token_label"),
placeholder: is_new_record ? t(".token_placeholder_new") : t(".token_placeholder_existing"),
type: :password %>
<div class="flex flex-wrap justify-end gap-2">
<%= form.submit(is_new_record ? t(".save_configuration") : t(".update_configuration")) %>
</div>
<% end %>
<div class="flex items-center gap-2">
<% if ibkr_item.persisted? && ibkr_item.credentials_configured? %>
<div class="w-2 h-2 bg-success rounded-full"></div>
<p class="text-sm text-secondary">
<%= t(".status_configured_prefix", summary: ibkr_item.sync_status_summary) %>
<%= link_to t(".accounts_tab"), accounts_path, class: "link" %>
<%= t(".status_configured_suffix") %>
</p>
<% else %>
<div class="w-2 h-2 bg-gray-400 rounded-full"></div>
<p class="text-sm text-secondary"><%= t(".not_configured") %></p>
<% end %>
</div>
</div>