mirror of
https://github.com/we-promise/sure.git
synced 2026-04-10 15:54:48 +00:00
* Initial split transaction support * Add support to unsplit and edit split * Update show.html.erb * FIX address reviews * Improve UX * Update show.html.erb * Reviews * Update edit.html.erb * Add parent category to dialog * Update en.yml * Add UI indication to totals * FIX ui update * Add category select like rest of app --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
232 lines
8.1 KiB
Ruby
232 lines
8.1 KiB
Ruby
class Transaction < ApplicationRecord
|
|
include Entryable, Transferable, Ruleable, Splittable
|
|
|
|
belongs_to :category, optional: true
|
|
belongs_to :merchant, optional: true
|
|
|
|
has_many :taggings, as: :taggable, dependent: :destroy
|
|
has_many :tags, through: :taggings
|
|
|
|
# File attachments (receipts, invoices, etc.) using Active Storage
|
|
# Supports images (JPEG, PNG, GIF, WebP) and PDFs up to 10MB each
|
|
# Maximum 10 attachments per transaction, family-scoped access
|
|
has_many_attached :attachments do |attachable|
|
|
attachable.variant :thumbnail, resize_to_limit: [ 150, 150 ]
|
|
end
|
|
|
|
# Attachment validation constants
|
|
MAX_ATTACHMENTS_PER_TRANSACTION = 10
|
|
MAX_ATTACHMENT_SIZE = 10.megabytes
|
|
ALLOWED_CONTENT_TYPES = %w[
|
|
image/jpeg image/jpg image/png image/gif image/webp
|
|
application/pdf
|
|
].freeze
|
|
|
|
validate :validate_attachments, if: -> { attachments.attached? }
|
|
|
|
accepts_nested_attributes_for :taggings, allow_destroy: true
|
|
|
|
after_save :clear_merchant_unlinked_association, if: :merchant_id_previously_changed?
|
|
|
|
enum :kind, {
|
|
standard: "standard", # A regular transaction, included in budget analytics
|
|
funds_movement: "funds_movement", # Movement of funds between accounts, excluded from budget analytics
|
|
cc_payment: "cc_payment", # A CC payment, excluded from budget analytics (CC payments offset the sum of expense transactions)
|
|
loan_payment: "loan_payment", # A payment to a Loan account, treated as an expense in budgets
|
|
one_time: "one_time", # A one-time expense/income, excluded from budget analytics
|
|
investment_contribution: "investment_contribution" # Transfer to investment/crypto account, treated as an expense in budgets
|
|
}
|
|
|
|
# All kinds where money moves between accounts (transfer? returns true).
|
|
# Used for search filters, rule conditions, and UI display.
|
|
TRANSFER_KINDS = %w[funds_movement cc_payment loan_payment investment_contribution].freeze
|
|
|
|
# Kinds excluded from budget/income-statement analytics.
|
|
# loan_payment and investment_contribution are intentionally NOT here —
|
|
# they represent real cash outflow from a budgeting perspective.
|
|
BUDGET_EXCLUDED_KINDS = %w[funds_movement one_time cc_payment].freeze
|
|
|
|
# All valid investment activity labels (for UI dropdown)
|
|
ACTIVITY_LABELS = [
|
|
"Buy", "Sell", "Sweep In", "Sweep Out", "Dividend", "Reinvestment",
|
|
"Interest", "Fee", "Transfer", "Contribution", "Withdrawal", "Exchange", "Other"
|
|
].freeze
|
|
|
|
# Internal movement labels that should be excluded from budget (auto cash management)
|
|
INTERNAL_MOVEMENT_LABELS = [ "Transfer", "Sweep In", "Sweep Out", "Exchange" ].freeze
|
|
|
|
# Providers that support pending transaction flags
|
|
PENDING_PROVIDERS = %w[simplefin plaid lunchflow].freeze
|
|
|
|
# Pending transaction scopes - filter based on provider pending flags in extra JSONB
|
|
# Works with any provider that stores pending status in extra["provider_name"]["pending"]
|
|
scope :pending, -> {
|
|
conditions = PENDING_PROVIDERS.map { |provider| "(transactions.extra -> '#{provider}' ->> 'pending')::boolean = true" }
|
|
where(conditions.join(" OR "))
|
|
}
|
|
|
|
scope :excluding_pending, -> {
|
|
conditions = PENDING_PROVIDERS.map { |provider| "(transactions.extra -> '#{provider}' ->> 'pending')::boolean IS DISTINCT FROM true" }
|
|
where(conditions.join(" AND "))
|
|
}
|
|
|
|
# Family-scoped query for Enrichable#clear_ai_cache
|
|
def self.family_scope(family)
|
|
joins(entry: :account).where(accounts: { family_id: family.id })
|
|
end
|
|
|
|
# Overarching grouping method for all transfer-type transactions
|
|
def transfer?
|
|
TRANSFER_KINDS.include?(kind)
|
|
end
|
|
|
|
def set_category!(category)
|
|
if category.is_a?(String)
|
|
category = entry.account.family.categories.find_or_create_by!(
|
|
name: category
|
|
)
|
|
end
|
|
|
|
update!(category: category)
|
|
end
|
|
|
|
def pending?
|
|
extra_data = extra.is_a?(Hash) ? extra : {}
|
|
PENDING_PROVIDERS.any? do |provider|
|
|
ActiveModel::Type::Boolean.new.cast(extra_data.dig(provider, "pending"))
|
|
end
|
|
rescue
|
|
false
|
|
end
|
|
|
|
# Potential duplicate matching methods
|
|
# These help users review and resolve fuzzy-matched pending/posted pairs
|
|
|
|
def has_potential_duplicate?
|
|
potential_posted_match_data.present? && !potential_duplicate_dismissed?
|
|
end
|
|
|
|
def potential_duplicate_entry
|
|
return nil unless has_potential_duplicate?
|
|
Entry.find_by(id: potential_posted_match_data["entry_id"])
|
|
end
|
|
|
|
def potential_duplicate_reason
|
|
potential_posted_match_data&.dig("reason")
|
|
end
|
|
|
|
def potential_duplicate_confidence
|
|
potential_posted_match_data&.dig("confidence") || "medium"
|
|
end
|
|
|
|
def low_confidence_duplicate?
|
|
potential_duplicate_confidence == "low"
|
|
end
|
|
|
|
def potential_duplicate_posted_amount
|
|
potential_posted_match_data&.dig("posted_amount")&.to_d
|
|
end
|
|
|
|
def potential_duplicate_dismissed?
|
|
potential_posted_match_data&.dig("dismissed") == true
|
|
end
|
|
|
|
# Merge this pending transaction with its suggested posted match
|
|
# This DELETES the pending entry since the posted version is canonical
|
|
def merge_with_duplicate!
|
|
return false unless has_potential_duplicate?
|
|
|
|
posted_entry = potential_duplicate_entry
|
|
return false unless posted_entry
|
|
|
|
pending_entry_id = entry.id
|
|
pending_entry_name = entry.name
|
|
|
|
# Delete this pending entry completely (no need to keep it around)
|
|
entry.destroy!
|
|
|
|
Rails.logger.info("User merged pending entry #{pending_entry_id} (#{pending_entry_name}) with posted entry #{posted_entry.id}")
|
|
true
|
|
end
|
|
|
|
# Dismiss the duplicate suggestion - user says these are NOT the same transaction
|
|
def dismiss_duplicate_suggestion!
|
|
return false unless potential_posted_match_data.present?
|
|
|
|
updated_extra = (extra || {}).deep_dup
|
|
updated_extra["potential_posted_match"]["dismissed"] = true
|
|
update!(extra: updated_extra)
|
|
|
|
Rails.logger.info("User dismissed duplicate suggestion for entry #{entry.id}")
|
|
true
|
|
end
|
|
|
|
# Clear the duplicate suggestion entirely
|
|
def clear_duplicate_suggestion!
|
|
return false unless potential_posted_match_data.present?
|
|
|
|
updated_extra = (extra || {}).deep_dup
|
|
updated_extra.delete("potential_posted_match")
|
|
update!(extra: updated_extra)
|
|
true
|
|
end
|
|
|
|
# Find potential posted transactions that might be duplicates of this pending transaction
|
|
# Returns entries (not transactions) for UI consistency with transfer matcher
|
|
# Lists recent posted transactions from the same account for manual merging
|
|
def pending_duplicate_candidates(limit: 20, offset: 0)
|
|
return Entry.none unless pending? && entry.present?
|
|
|
|
account = entry.account
|
|
currency = entry.currency
|
|
|
|
# Find recent posted transactions from the same account
|
|
conditions = PENDING_PROVIDERS.map { |provider| "(transactions.extra -> '#{provider}' ->> 'pending')::boolean IS NOT TRUE" }
|
|
|
|
account.entries
|
|
.joins("INNER JOIN transactions ON transactions.id = entries.entryable_id AND entries.entryable_type = 'Transaction'")
|
|
.where.not(id: entry.id)
|
|
.where(currency: currency)
|
|
.where(conditions.join(" AND "))
|
|
.order(date: :desc, created_at: :desc)
|
|
.limit(limit)
|
|
.offset(offset)
|
|
end
|
|
|
|
private
|
|
|
|
def validate_attachments
|
|
# Check attachment count limit
|
|
if attachments.size > MAX_ATTACHMENTS_PER_TRANSACTION
|
|
errors.add(:attachments, :too_many, max: MAX_ATTACHMENTS_PER_TRANSACTION)
|
|
end
|
|
|
|
# Validate each attachment
|
|
attachments.each_with_index do |attachment, index|
|
|
# Check file size
|
|
if attachment.byte_size > MAX_ATTACHMENT_SIZE
|
|
errors.add(:attachments, :too_large, index: index + 1, max_mb: MAX_ATTACHMENT_SIZE / 1.megabyte)
|
|
end
|
|
|
|
# Check content type
|
|
unless ALLOWED_CONTENT_TYPES.include?(attachment.content_type)
|
|
errors.add(:attachments, :invalid_format, index: index + 1, file_format: attachment.content_type)
|
|
end
|
|
end
|
|
end
|
|
|
|
def potential_posted_match_data
|
|
return nil unless extra.is_a?(Hash)
|
|
extra["potential_posted_match"]
|
|
end
|
|
|
|
def clear_merchant_unlinked_association
|
|
return unless merchant_id.present? && merchant.is_a?(ProviderMerchant)
|
|
|
|
family = entry&.account&.family
|
|
return unless family
|
|
|
|
FamilyMerchantAssociation.where(family: family, merchant: merchant).delete_all
|
|
end
|
|
end
|