mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
93 lines
2.7 KiB
Ruby
93 lines
2.7 KiB
Ruby
require "test_helper"
|
|
|
|
class PlaidEntry::ProcessorTest < ActiveSupport::TestCase
|
|
setup do
|
|
@plaid_account = plaid_accounts(:one)
|
|
@category_matcher = mock("PlaidAccount::Transactions::CategoryMatcher")
|
|
end
|
|
|
|
test "creates new entry transaction" do
|
|
plaid_transaction = {
|
|
"transaction_id" => "123",
|
|
"merchant_name" => "Amazon", # this is used for merchant and entry name
|
|
"amount" => 100,
|
|
"date" => Date.current,
|
|
"iso_currency_code" => "USD",
|
|
"personal_finance_category" => {
|
|
"detailed" => "Food"
|
|
},
|
|
"merchant_entity_id" => "123"
|
|
}
|
|
|
|
@category_matcher.expects(:match).with("Food").returns(categories(:food_and_drink))
|
|
|
|
processor = PlaidEntry::Processor.new(
|
|
plaid_transaction,
|
|
plaid_account: @plaid_account,
|
|
category_matcher: @category_matcher
|
|
)
|
|
|
|
assert_difference [ "Entry.count", "Transaction.count", "ProviderMerchant.count" ], 1 do
|
|
processor.process
|
|
end
|
|
|
|
entry = Entry.order(created_at: :desc).first
|
|
|
|
assert_equal 100, entry.amount
|
|
assert_equal "USD", entry.currency
|
|
assert_equal Date.current, entry.date
|
|
assert_equal "Amazon", entry.name
|
|
assert_equal categories(:food_and_drink).id, entry.transaction.category_id
|
|
|
|
provider_merchant = ProviderMerchant.order(created_at: :desc).first
|
|
|
|
assert_equal "Amazon", provider_merchant.name
|
|
end
|
|
|
|
test "updates existing entry transaction" do
|
|
existing_plaid_id = "existing_plaid_id"
|
|
|
|
plaid_transaction = {
|
|
"transaction_id" => existing_plaid_id,
|
|
"merchant_name" => "Amazon", # this is used for merchant and entry name
|
|
"amount" => 200, # Changed amount will be updated
|
|
"date" => 1.day.ago.to_date, # Changed date will be updated
|
|
"iso_currency_code" => "USD",
|
|
"personal_finance_category" => {
|
|
"detailed" => "Food"
|
|
}
|
|
}
|
|
|
|
@category_matcher.expects(:match).with("Food").returns(categories(:food_and_drink))
|
|
|
|
# Create an existing entry
|
|
@plaid_account.current_account.entries.create!(
|
|
external_id: existing_plaid_id,
|
|
source: "plaid",
|
|
amount: 100,
|
|
currency: "USD",
|
|
date: Date.current,
|
|
name: "Amazon",
|
|
entryable: Transaction.new
|
|
)
|
|
|
|
processor = PlaidEntry::Processor.new(
|
|
plaid_transaction,
|
|
plaid_account: @plaid_account,
|
|
category_matcher: @category_matcher
|
|
)
|
|
|
|
assert_no_difference [ "Entry.count", "Transaction.count", "ProviderMerchant.count" ] do
|
|
processor.process
|
|
end
|
|
|
|
entry = Entry.order(created_at: :desc).first
|
|
|
|
assert_equal 200, entry.amount
|
|
assert_equal "USD", entry.currency
|
|
assert_equal 1.day.ago.to_date, entry.date
|
|
assert_equal "Amazon", entry.name
|
|
assert_equal categories(:food_and_drink).id, entry.transaction.category_id
|
|
end
|
|
end
|