mirror of
https://github.com/we-promise/sure.git
synced 2026-05-24 21:14:56 +00:00
* feat(sync): add Brex provider schema Adds Brex item and account tables with per-family credentials, scoped upstream account uniqueness, encrypted token storage, and sanitized provider payload columns. * feat(sync): add Brex provider core Adds Brex item/account models, provider client and adapter support, family connection helpers, and provider enum registration for read-only Brex cash and card data. * feat(sync): add Brex import pipeline Adds Brex account discovery, linked-account sync, cash/card balance processors, transaction import, sanitized metadata handling, and idempotent provider entry processing. * feat(sync): add Brex connection flows Adds Mercury-style Brex connection management, explicit item-scoped account selection and linking, settings provider UI, account index visibility, localized copy, and per-item cache handling. * test(sync): cover Brex provider workflows Adds targeted coverage for Brex provider requests, adapter config, item/account guards, importer behavior, entry processing, and Mercury-style controller flows. * fix(sync): align Brex API edge cases Tightens Brex account fetching against the official card-account response shape, sends transaction start filters as RFC3339 date-times, and keeps provider error bodies out of user-facing messages while expanding provider client guard coverage. * fix(sync): harden Brex provider integration Restrict Brex API base URLs to official hosts, tighten account-selection UI behavior, and add tests for invalid credentials, cache scoping, and provider setup edge cases. * test(sync): avoid Brex secret-shaped fixtures * refactor(sync): extract Brex account flows * fix(sync): address Brex provider review feedback * fix(sync): address Brex review follow-ups Move remaining Brex review cleanup into focused model behavior, tighten link/setup edge cases, localize summaries, and add regression coverage from CodeRabbit feedback. Also records the security-review pass as no-findings after diff-scoped inspection and Brakeman validation. * refactor(sync): split Brex account flow controllers Route Brex account selection and setup actions through small namespaced controllers while keeping existing URLs and helpers stable. Business flow remains in BrexItem::AccountFlow; the main Brex item controller now only handles connection CRUD, provider-panel rendering, destroy, and sync. * fix(sync): address Brex CodeRabbit review * fix(sync): address Brex follow-up review * fix(sync): address Brex review follow-ups * fix(sync): address Brex sync review findings * fix(sync): polish Brex review copy and errors * fix(sync): register Brex provider health * fix(sync): polish Brex bank sync presentation * fix(sync): address Brex review follow-ups * fix(sync): tighten Brex setup params * test(api): stabilize usage rate-limit window * fix(sync): polish Brex setup flow nits * fix(sync): harden Brex setup params * fix(sync): finalize Brex review cleanup --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
110 lines
3.5 KiB
Ruby
110 lines
3.5 KiB
Ruby
class BrexItems::AccountSetupsController < ApplicationController
|
|
before_action :require_admin!
|
|
before_action :set_brex_item
|
|
|
|
def setup_accounts
|
|
flow = brex_account_flow
|
|
@api_error = flow.import_accounts_with_user_facing_error
|
|
@brex_accounts = flow.unlinked_brex_accounts
|
|
@account_type_options = flow.account_type_options
|
|
@displayable_account_type_options = flow.displayable_account_type_options
|
|
@subtype_options = flow.subtype_options
|
|
|
|
render "brex_items/setup_accounts"
|
|
end
|
|
|
|
def complete_account_setup
|
|
result = brex_account_flow.complete_setup_result(
|
|
account_types: sanitized_account_types,
|
|
account_subtypes: sanitized_account_subtypes
|
|
)
|
|
|
|
unless result.success?
|
|
redirect_to accounts_path, alert: result.message, status: :see_other
|
|
return
|
|
end
|
|
|
|
flash[:notice] = result.message
|
|
|
|
if turbo_frame_request?
|
|
render_accounts_update_after_setup
|
|
else
|
|
redirect_to accounts_path, status: :see_other
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def set_brex_item
|
|
@brex_item = Current.family.brex_items.find(params[:id])
|
|
end
|
|
|
|
def brex_account_flow
|
|
@brex_account_flow ||= BrexItem::AccountFlow.new(family: Current.family, brex_item: @brex_item)
|
|
end
|
|
|
|
def render_accounts_update_after_setup
|
|
@manual_accounts = Account.uncached { Current.family.accounts.visible_manual.order(:name).to_a }
|
|
@brex_items = Current.family.brex_items.ordered
|
|
|
|
manual_accounts_stream = if @manual_accounts.any?
|
|
turbo_stream.update(
|
|
"manual-accounts",
|
|
partial: "accounts/index/manual_accounts",
|
|
locals: { accounts: @manual_accounts }
|
|
)
|
|
else
|
|
turbo_stream.replace("manual-accounts", view_context.tag.div(id: "manual-accounts"))
|
|
end
|
|
|
|
render turbo_stream: [
|
|
manual_accounts_stream,
|
|
turbo_stream.replace(
|
|
ActionView::RecordIdentifier.dom_id(@brex_item),
|
|
partial: "brex_items/brex_item",
|
|
locals: { brex_item: @brex_item }
|
|
)
|
|
] + Array(flash_notification_stream_items)
|
|
end
|
|
|
|
def sanitized_account_types
|
|
supported_types = Provider::BrexAdapter.supported_account_types
|
|
|
|
setup_param_hash(:account_types, allowed_account_ids).each_with_object({}) do |(account_id, selected_type), sanitized|
|
|
next unless allowed_account_ids.include?(account_id.to_s)
|
|
|
|
normalized_type = selected_type.to_s
|
|
sanitized[account_id.to_s] = supported_types.include?(normalized_type) ? normalized_type : "skip"
|
|
end
|
|
end
|
|
|
|
def sanitized_account_subtypes
|
|
allowed_subtypes = (Depository::SUBTYPES.keys + CreditCard::SUBTYPES.keys).map(&:to_s)
|
|
|
|
setup_param_hash(:account_subtypes, allowed_account_ids).each_with_object({}) do |(account_id, selected_subtype), sanitized|
|
|
next unless allowed_account_ids.include?(account_id.to_s)
|
|
next if selected_subtype.blank?
|
|
next unless allowed_subtypes.include?(selected_subtype.to_s)
|
|
|
|
sanitized[account_id.to_s] = selected_subtype.to_s
|
|
end
|
|
end
|
|
|
|
def setup_param_hash(key, allowed_keys)
|
|
raw_params = params.fetch(key, {})
|
|
return {} if raw_params.blank?
|
|
|
|
if raw_params.is_a?(ActionController::Parameters)
|
|
raw_params.permit(*allowed_keys).to_h
|
|
elsif raw_params.is_a?(Hash)
|
|
raw_params.slice(*allowed_keys)
|
|
else
|
|
{}
|
|
end
|
|
end
|
|
|
|
def allowed_account_ids
|
|
@allowed_account_ids ||= @brex_item.brex_accounts.pluck(:id).map(&:to_s)
|
|
end
|
|
end
|