mirror of
https://github.com/we-promise/sure.git
synced 2026-04-10 07:44:48 +00:00
560c9fbff3
* Initial account sharing changes * Update schema.rb * Update schema.rb * Change sharing UI to modal * UX fixes and sharing controls * Scope include in finances better * Update totals.rb * Update totals.rb * Scope reports to finance account scope * Update impersonation_sessions_controller_test.rb * Review fixes * Update schema.rb * Update show.html.erb * FIX db validation * Refine edit permissions * Review items * Review * Review * Add application level helper * Critical review * Address remaining review items * Fix modals * more scoping * linter * small UI fix * Fix: Sync broadcasts push unscoped balance sheet to all users * Update sync_complete_event.rb The fix removes the sidebar broadcasts (which rendered unscoped account groups using family.balance_sheet without user context) along with the now-unused sidebar_targets, account_group, and family_balance_sheet private methods. The sidebar will still update correctly — when the sync completes, Family::SyncCompleteEvent#broadcast fires family.broadcast_refresh, which triggers a morph-based page refresh for each user with their own authenticated session, rendering properly scoped sidebar content.
80 lines
2.8 KiB
Ruby
80 lines
2.8 KiB
Ruby
class TransferMatchesController < ApplicationController
|
|
before_action :set_entry
|
|
|
|
def new
|
|
@accounts = accessible_accounts.visible.alphabetically.where.not(id: @entry.account_id)
|
|
@transfer_match_candidates = @entry.transaction.transfer_match_candidates
|
|
end
|
|
|
|
def create
|
|
permission = @entry.account.permission_for(Current.user)
|
|
unless permission.in?([ :owner, :full_control ])
|
|
redirect_back_or_to transactions_path, alert: t("accounts.not_authorized")
|
|
return
|
|
end
|
|
|
|
@transfer = build_transfer
|
|
Transfer.transaction do
|
|
@transfer.save!
|
|
|
|
# Use DESTINATION (inflow) account for kind, matching Transfer::Creator logic
|
|
destination_account = @transfer.inflow_transaction.entry.account
|
|
outflow_kind = Transfer.kind_for_account(destination_account)
|
|
outflow_attrs = { kind: outflow_kind }
|
|
|
|
if outflow_kind == "investment_contribution"
|
|
category = destination_account.family.investment_contributions_category
|
|
outflow_attrs[:category] = category if category.present? && @transfer.outflow_transaction.category_id.blank?
|
|
end
|
|
|
|
@transfer.outflow_transaction.update!(outflow_attrs)
|
|
@transfer.inflow_transaction.update!(kind: "funds_movement")
|
|
end
|
|
|
|
@transfer.sync_account_later
|
|
|
|
redirect_back_or_to transactions_path, notice: "Transfer created"
|
|
end
|
|
|
|
private
|
|
def set_entry
|
|
@entry = Current.accessible_entries.find(params[:transaction_id])
|
|
end
|
|
|
|
def transfer_match_params
|
|
params.require(:transfer_match).permit(:method, :matched_entry_id, :target_account_id)
|
|
end
|
|
|
|
def build_transfer
|
|
if transfer_match_params[:method] == "new"
|
|
target_account = accessible_accounts.find(transfer_match_params[:target_account_id])
|
|
|
|
missing_transaction = Transaction.new(
|
|
entry: target_account.entries.build(
|
|
amount: @entry.amount * -1,
|
|
currency: @entry.currency,
|
|
date: @entry.date,
|
|
name: "Transfer to #{@entry.amount.negative? ? @entry.account.name : target_account.name}",
|
|
user_modified: true,
|
|
)
|
|
)
|
|
|
|
transfer = Transfer.find_or_initialize_by(
|
|
inflow_transaction: @entry.amount.positive? ? missing_transaction : @entry.transaction,
|
|
outflow_transaction: @entry.amount.positive? ? @entry.transaction : missing_transaction
|
|
)
|
|
transfer.status = "confirmed"
|
|
transfer
|
|
else
|
|
target_transaction = Current.accessible_entries.find(transfer_match_params[:matched_entry_id])
|
|
|
|
transfer = Transfer.find_or_initialize_by(
|
|
inflow_transaction: @entry.amount.negative? ? @entry.transaction : target_transaction.transaction,
|
|
outflow_transaction: @entry.amount.negative? ? target_transaction.transaction : @entry.transaction
|
|
)
|
|
transfer.status = "confirmed"
|
|
transfer
|
|
end
|
|
end
|
|
end
|