mirror of
https://github.com/we-promise/sure.git
synced 2026-07-18 15:55:22 +00:00
169fd139b5
* fix(chat): surface and recover from undelivered assistant responses When the background worker that runs AssistantResponseJob is down or not polling the high_priority queue, the eager "pending" assistant message had no safeguard: chat hung on "Thinking…" forever with no error, timeout, or retry, and the LLM provider was never even called. Add three layers of resilience: - Client watchdog (chat_controller.js): a pending "Thinking…" bubble that waits past a threshold (default 90s) with no response asks the server to fail it. Keyed on the pending marker — which disappears the instant a real response streams — so a slow-but-working response is never falsely timed out. - Server failure capture (Chat#handle_undelivered_response! + MessagesController#report_timeout): clears the dead bubble, records a friendly "the assistant didn't respond" error with Retry, and writes a DebugLogEntry so support can see it in /settings/debug. - Worker liveness signal (BackgroundJobHealth + warning banner): reads Sidekiq's process/queue state directly from Redis in the web process — so a down worker is detectable even though the worker is the thing that's broken — and warns self-hosted users when no worker polls high_priority or it's badly backed up. Fails open so a Sidekiq/Redis blip never blocks chat. Tests: Chat model (3), MessagesController (2), BackgroundJobHealth (5). * fix(chat): address review — server-side timeout guard + watchdog retry safety - Chat#handle_undelivered_response!: gate the state change behind a row lock and a server-side minimum age (UNDELIVERED_RESPONSE_TIMEOUT = 60s). The browser watchdog is untrusted, so re-read the row under lock and only fail a bubble that is still pending AND has genuinely waited past the timeout — never racing a worker that is finishing a slow response. (Codex P2 + CodeRabbit) - chat_controller.js: only mark a report URL as reported on response.ok (fetch resolves on HTTP 4xx/5xx, rejecting only on network errors), and guard concurrent duplicate POSTs with an in-flight set, so a failed report retries instead of stranding the bubble. (CodeRabbit) - _worker_health_warning: drop the unused `chat:` local + its render arg. (CodeRabbit)
33 lines
1.3 KiB
Plaintext
33 lines
1.3 KiB
Plaintext
<%# locals: (assistant_message:) %>
|
|
|
|
<div id="<%= dom_id(assistant_message) %>">
|
|
<% if assistant_message.pending? %>
|
|
<div class="flex items-start gap-3 mb-6"
|
|
data-chat-target="pendingResponse"
|
|
data-pending-response-created-at="<%= assistant_message.created_at&.iso8601 %>"
|
|
data-pending-response-timeout-url="<%= report_timeout_chat_message_path(assistant_message.chat, assistant_message) %>">
|
|
<%= render "chats/ai_avatar" %>
|
|
<p class="text-sm text-secondary animate-pulse"><%= t("chats.thinking") %></p>
|
|
</div>
|
|
<% elsif assistant_message.reasoning? %>
|
|
<details class="group mb-1">
|
|
<summary class="flex items-center gap-2">
|
|
<p class="text-secondary text-sm"><%= t(".assistant_reasoning") %></p>
|
|
<%= icon("chevron-down", class: "group-open:transform group-open:rotate-180") %>
|
|
</summary>
|
|
|
|
<div class="prose prose--ai-chat"><%= markdown(assistant_message.content) %></div>
|
|
</details>
|
|
<% else %>
|
|
<% if assistant_message.chat.debug_mode? && assistant_message.tool_calls.any? %>
|
|
<%= render "assistant_messages/tool_calls", message: assistant_message %>
|
|
<% end %>
|
|
|
|
<div class="flex items-start gap-3 mb-6">
|
|
<%= render "chats/ai_avatar" %>
|
|
|
|
<div class="prose prose--ai-chat"><%= markdown(assistant_message.content) %></div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|