mirror of
https://github.com/we-promise/sure.git
synced 2026-07-17 23:35:23 +00:00
0fa7ca5824
PropertyTest#open_account_edit_dialog already retried the menu→Edit flow
because the account page issues a Turbo morph refresh shortly after load
(turbo_refreshes_with :morph). But the naive retry had two gaps that can
still flake under a slow CI browser:
- It re-clicked the DS::Menu trigger every iteration. The trigger toggles
(menu_controller#toggle), so a retry after a slow-but-successful modal
load would close the open menu and hide "Edit". Now it opens the menu
only when it is closed.
- It did not tolerate the menu node detaching mid-click ("Node with given
id does not belong to the document"), an inspector error Capybara does
not auto-retry. Now it rescues the transient detach/stale errors and
retries, re-raising anything else.
Mirrors the same guard applied to AccountsTest#open_account_edit_dialog.
101 lines
3.5 KiB
Ruby
101 lines
3.5 KiB
Ruby
require "application_system_test_case"
|
|
|
|
class PropertiesEditTest < ApplicationSystemTestCase
|
|
setup do
|
|
sign_in @user = users(:family_admin)
|
|
|
|
Family.any_instance.stubs(:get_link_token).returns("test-link-token")
|
|
|
|
visit root_url
|
|
open_new_account_modal
|
|
create_new_property_account
|
|
end
|
|
|
|
test "can persist property subtype" do
|
|
click_link "[system test] Property Account"
|
|
open_account_edit_dialog
|
|
assert_equal "single_family_home", find("#account_accountable_attributes_subtype").value
|
|
end
|
|
|
|
private
|
|
|
|
# The account page issues a Turbo morph refresh shortly after it loads
|
|
# (`turbo_refreshes_with method: :morph` reacting to a family-stream
|
|
# broadcast). If the edit modal is opened while that refresh is in flight,
|
|
# the morph re-renders the page and wipes the just-loaded `#modal`
|
|
# turbo-frame before the dialog is interactive — and can detach the menu
|
|
# node mid-click ("Node with given id does not belong to the document"),
|
|
# which Capybara does not auto-retry. Open via the account menu and retry
|
|
# until the edit form is present so the test is deterministic instead of
|
|
# racing the broadcast.
|
|
def open_account_edit_dialog
|
|
3.times do
|
|
# A prior (slow) attempt may have already opened the edit form.
|
|
return if has_selector?("#account_accountable_attributes_subtype", wait: 0)
|
|
|
|
begin
|
|
within_testid("account-menu") do
|
|
# Open the menu only when it's closed. DS::Menu's trigger toggles
|
|
# (menu_controller#toggle), so blindly re-clicking an already-open
|
|
# menu would close it and hide "Edit", turning a slow-but-successful
|
|
# modal load into a fresh flake.
|
|
unless has_selector?("[role='menu']", visible: true, wait: 0)
|
|
find("button").click
|
|
end
|
|
click_on "Edit"
|
|
end
|
|
rescue Selenium::WebDriver::Error::WebDriverError => e
|
|
raise unless e.message.match?(
|
|
/does not belong to the document|stale element reference/i,
|
|
)
|
|
next
|
|
end
|
|
return if has_selector?("#account_accountable_attributes_subtype", wait: 2)
|
|
end
|
|
assert_selector "#account_accountable_attributes_subtype"
|
|
end
|
|
|
|
def open_new_account_modal
|
|
within "[data-controller='DS--tabs']" do
|
|
click_button "All"
|
|
click_link "New account"
|
|
end
|
|
end
|
|
|
|
def create_new_property_account
|
|
click_link "Property"
|
|
|
|
account_name = "[system test] Property Account"
|
|
fill_in "Name*", with: account_name
|
|
select "Single Family Home", from: "Property type*"
|
|
fill_in "Year Built (optional)", with: 2005
|
|
fill_in "Area (optional)", with: 2250
|
|
|
|
click_button "Next"
|
|
|
|
# Step 2: Enter balance information
|
|
assert_text "Value"
|
|
fill_in "account[balance]", with: 500000
|
|
click_button "Next"
|
|
|
|
# Step 3: Enter address information
|
|
assert_text "Address"
|
|
fill_in "Address Line 1", with: "123 Main St"
|
|
fill_in "City", with: "San Francisco"
|
|
fill_in "State/Region", with: "CA"
|
|
fill_in "Postal Code", with: "94101"
|
|
fill_in "Country", with: "US"
|
|
|
|
click_button "Save"
|
|
|
|
# Verify account was created and is now active
|
|
assert_text account_name
|
|
|
|
created_account = Account.order(:created_at).last
|
|
assert_equal "active", created_account.status
|
|
assert_equal 500000, created_account.balance
|
|
assert_equal "123 Main St", created_account.property.address.line1
|
|
assert_equal "San Francisco", created_account.property.address.locality
|
|
end
|
|
end
|