mirror of
https://github.com/we-promise/sure.git
synced 2026-05-12 23:25:00 +00:00
0c2026680c
* Add `investment_activity_label` to trades and enhance activity label handling - Introduced `investment_activity_label` column to the `trades` table with a migration. - Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`). - Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels. - Updated views and controllers to display and manage activity labels for trades. - Added localized badge components for displaying and editing labels dynamically. - Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically. - Added investment flows section to reports for tracking contributions and withdrawals. - Refactored related tests and models for consistency and to ensure proper validation and filtering. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Add safeguard for `dropdownTarget` existence in quick edit controller - Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility. * Fix undefined method 'category' for Trade on mobile view Trade model uses investment_activity_label, not category. The upstream merge introduced a call to trade.category which doesn't exist. Use the activity label badge on mobile instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix activity label logic for zero/blank quantity and sell inference - Return `nil` for blank or zero quantity in `investment_activity_label_for`. - Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`. * Fix i18n key paths in transactions controller for convert_to_trade - Update flash message translations to use full i18n paths. - Use `BigDecimal` for quantity and price calculations to improve precision. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: luckyPipewrench <luckypipewrench@proton.me> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
120 lines
5.2 KiB
Plaintext
120 lines
5.2 KiB
Plaintext
<%# locals: (investment_statement:, period:, **args) %>
|
|
|
|
<% if investment_statement.investment_accounts.any? %>
|
|
<div id="investment-summary" class="space-y-4">
|
|
<div class="flex justify-between gap-4 px-4">
|
|
<div class="space-y-2">
|
|
<div class="flex items-center gap-2">
|
|
<h2 class="text-lg font-medium"><%= t(".title") %></h2>
|
|
</div>
|
|
|
|
<p class="text-primary text-3xl font-medium">
|
|
<%= format_money(investment_statement.portfolio_value_money) %>
|
|
</p>
|
|
|
|
<% trend = investment_statement.unrealized_gains_trend %>
|
|
<% if trend %>
|
|
<div class="flex items-center gap-2 text-sm">
|
|
<span class="text-secondary"><%= t(".total_return") %>:</span>
|
|
<span class="font-medium" style="color: <%= trend.color %>">
|
|
<%= format_money(Money.new(trend.value, Current.family.currency)) %>
|
|
(<%= trend.percent_formatted %>)
|
|
</span>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
|
|
<% holdings = investment_statement.top_holdings(limit: 5) %>
|
|
<% if holdings.any? %>
|
|
<div class="bg-container-inset rounded-xl p-1 mx-4">
|
|
<div class="px-4 py-2 flex items-center uppercase text-xs font-medium text-secondary">
|
|
<div class="flex-1"><%= t(".holding") %></div>
|
|
<div class="w-20 text-right"><%= t(".weight") %></div>
|
|
<div class="w-28 text-right"><%= t(".value") %></div>
|
|
<div class="w-24 text-right"><%= t(".return") %></div>
|
|
</div>
|
|
|
|
<div class="shadow-border-xs rounded-lg bg-container font-medium text-sm">
|
|
<% holdings.each_with_index do |holding, idx| %>
|
|
<div class="p-4 flex items-center <%= idx < holdings.size - 1 ? "border-b border-primary" : "" %>">
|
|
<div class="flex-1 flex items-center gap-3">
|
|
<% if holding.security.logo_url.present? %>
|
|
<img src="<%= holding.security.logo_url %>" alt="<%= holding.ticker %>" class="w-8 h-8 rounded-full">
|
|
<% else %>
|
|
<div class="w-8 h-8 rounded-full bg-container-inset flex items-center justify-center text-xs font-medium text-secondary">
|
|
<%= holding.ticker[0..1] %>
|
|
</div>
|
|
<% end %>
|
|
<div>
|
|
<p class="font-medium"><%= holding.ticker %></p>
|
|
<p class="text-xs text-secondary"><%= truncate(holding.name, length: 20) %></p>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="w-20 text-right text-secondary">
|
|
<%= number_to_percentage(holding.weight || 0, precision: 1) %>
|
|
</div>
|
|
|
|
<div class="w-28 text-right">
|
|
<%= format_money(holding.amount_money) %>
|
|
</div>
|
|
|
|
<div class="w-24 text-right">
|
|
<% if holding.trend %>
|
|
<span style="color: <%= holding.trend.color %>">
|
|
<%= holding.trend.percent_formatted %>
|
|
</span>
|
|
<% else %>
|
|
<span class="text-secondary">-</span>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Investment Activity Summary %>
|
|
<% totals = investment_statement.totals(period: period) %>
|
|
<% if totals.trades_count > 0 || totals.contributions.to_f > 0 || totals.withdrawals.to_f > 0 %>
|
|
<div class="bg-container-inset rounded-xl p-1 mx-4">
|
|
<div class="px-4 py-2 flex items-center uppercase text-xs font-medium text-secondary">
|
|
<%= t(".period_activity", period: period.label) %>
|
|
</div>
|
|
<div class="shadow-border-xs rounded-lg bg-container font-medium text-sm">
|
|
<div class="p-4 flex items-center justify-between gap-4">
|
|
<div class="flex items-center gap-2">
|
|
<div class="w-8 h-8 rounded-full bg-green-500/10 flex items-center justify-center">
|
|
<%= icon "trending-up", size: "sm", color: "green" %>
|
|
</div>
|
|
<div>
|
|
<p class="text-xs text-secondary"><%= t(".contributions") %></p>
|
|
<p class="font-medium text-green-600"><%= format_money(totals.contributions) %></p>
|
|
</div>
|
|
</div>
|
|
<div class="flex items-center gap-2">
|
|
<div class="w-8 h-8 rounded-full bg-orange-500/10 flex items-center justify-center">
|
|
<%= icon "trending-down", size: "sm", color: "orange" %>
|
|
</div>
|
|
<div>
|
|
<p class="text-xs text-secondary"><%= t(".withdrawals") %></p>
|
|
<p class="font-medium text-orange-600"><%= format_money(totals.withdrawals) %></p>
|
|
</div>
|
|
</div>
|
|
<div class="flex items-center gap-2">
|
|
<div class="w-8 h-8 rounded-full bg-blue-500/10 flex items-center justify-center">
|
|
<%= icon "arrow-left-right", size: "sm", color: "blue" %>
|
|
</div>
|
|
<div>
|
|
<p class="text-xs text-secondary"><%= t(".trades") %></p>
|
|
<p class="font-medium text-primary"><%= totals.trades_count %></p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|