mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 12:04:08 +00:00
* SimpleFin: metadata + merge fixes; holdings (incl. crypto) + Day Change; Sync Summary; ops rakes; lint # Conflicts: # db/schema.rb # Conflicts: # app/controllers/simplefin_items_controller.rb * fix testing * fix linting * xfix linting x2 * Review PR #267 on we-promise/sure (SimpleFin enhancements v2). Address all 15 actionable CodeRabbit comments: Add UUID validations in rakes (e.g., simplefin_unlink), swap Ruby pattern matching/loops for efficient DB queries (e.g., where LOWER(name) LIKE ?), generate docstrings for low-coverage areas (31%), consolidate routes for simplefin_items, move view logic to helpers (e.g., format_transaction_extra), strengthen tests with exact assertions/fixtures for dedup/relink failures. Also, check for overlaps with merged #262 (merchants fix): Ensure merchant creation in simplefin_entry/processor.rb aligns with new payee-based flow and MD5 IDs; add tests for edge cases like empty payees or over-merging pendings. Prioritize security (PII redaction in logs, no hardcoded secrets). * SimpleFin: address CodeRabbit comments (batch 1) - Consolidate simplefin_items routes under a single resources block; keep URLs stable - Replace inline JS with Stimulus auto-relink controller; auto-load relink modal via global modal frame - Improve a11y in relink modal by wrapping rows in labels - Harden unlink rake: default dry_run=true, UUID validation, redact PII in outputs, clearer errors - Backfill rake: default dry_run=true, UUID validation; groundwork for per-SFA counters - Fix-was-merged rake: default dry_run=true, UUID validation; clearer outputs - Idempotent transfer auto-match (find_or_create_by! + RecordNotUnique rescue) - Extract SimpleFin error tooltip assembly into helper and use it in view RuboCop: maintain 2-space indentation, spaces inside array brackets, spaces after commas, and no redundant returns * Linter noise * removed filed commited by mistake. * manual relink flow and tighten composite matching * enforce manual relink UI; fix adapter keywords; guarantee extra.simplefin hash * refactor(simplefin): extract relink service; enforce manual relink UI; tighten composite match; migration 7.2 * add provider date parser; refactor rake; move view queries; partial resilience * run balances-only import in background job. make update flow enqueue balances-only job * persists across all update redirects and initialize used_manual_ids to prevent NameError in relink candidate computation. * SimpleFin: metadata + merge fixes; holdings (incl. crypto) + Day Change; Sync Summary; ops rakes; lint * Fixed failed test after rebase. * scan_ruby fix * Calming the rabbit: Fix AccountProvider linking when accounts change Drop the legacy unique index instead of duplicating it Fix dynamic constant assignment Use fixtures consistently; avoid rescue for control flow. Replace bare rescue with explicit exception class. Move business logic out of the view. Critical: Transaction boundary excludes recompute phase, risking data loss. Inconsistency between documentation and implementation for zero-error case. Refactor to use the compute_unlinked_count helper for consistency. Fix cleanup task default: it deletes by default. Move sync stats computation to controller to avoid N+1 queries. Consolidate duplicate sync query. Clarify the intent of setting flash notice on the error path. Fix Date/Time comparison in should_be_inactive?. Move stats retrieval logic to controller. Remove duplicate Sync summary section. Remove the unnecessary sleep statement; use Capybara's built-in waiting. Add label wrappers for accessibility and consistency. * FIX SimpleFIN new account modal Now new account properly loads as a Modal, instead of new page. Fixes also form showing dashboard instead of settings page. * Remove SimpleFin legacy UI components, migrate schema, and refine linking behavior. # Conflicts: # app/helpers/settings_helper.rb * Extract SimpleFin-related logic to `prepare_show_context` helper and refactor for consistency. Adjust conditional checks and ensure controller variables are properly initialized. * Remove unused SimpleFin maps from prepare_show_context; select IDs to avoid N+1 Replace Tailwind bg-green-500 with semantic bg-success in _simplefin_panel/_provider_form Add f.label :setup_token in simplefin_items/new for a11y Remove duplicate require in AccountsControllerSimplefinCtaTest * Remove unnecessary blank lines * Reduce unnecessary changes This reduces the diff against main * Simplefin Account Setup: Display in modal This fixes an issue with the `X` dismiss button in the top right corner * Removed unnecessary comment. * removed unnecessary function. * fixed broken links * Removed unnecessary file * changed to database query * set to use UTC and gaurd against null * set dry_run=true * Fixed comment * Changed to use a database-level query * matched test name to test behavior. * Eliminate code duplication and Time.zone dependency * make final summary surface failures * lint fix * Revised timezone comment. better handle missing selectors. * sanitized LIKE wildcards * Fixed SimpleFin import to avoid “Currency can’t be blank” validation failures when providers return an empty currency string. * Added helper methods for admin and self-hosted checks * Specify exception types in rescue clauses. * Refined logic to determine transaction dates for credit accounts. * Refined stats calculation for `total_accounts` to track the maximum unique accounts per run instead of accumulating totals. * Moved `unlink_all!` logic to `SimplefinItem::Unlinking` concern and deprecated `SimplefinItem::Unlinker`. Updated related references. * Refined legacy unlinking logic, improved `current_holdings` formatting, and added ENV-based overrides for self-hosted checks. * Enhanced `unlink_all!` with explicit error handling, improved transaction safety, and refined ENV-based self-hosted checks. Adjusted exception types and cleaned up private method handling. * Improved currency assignment logic by adding fallback to `current_account` and `family` currencies. * Enhanced error tracking during SimpleFin account imports by adding categorized error buckets, limiting stored errors to the last 5, and improving `stats` calculations. * typo fix * Didn't realize rabbit was still mad... Refactored SimpleFin error handling and CTA logic: centralized duplicate detection and relink visibility into controller, improved task counters, adjusted redirect notices, and fixed form indexing. * Dang rabbit never stops... Centralized SimpleFin maps logic into `MapsHelper` concern and integrated it into relevant controllers and rake tasks. Optimized queries, reduced redundancy, and improved unlinked counts and manual account checks with batch processing. Adjusted task arguments for clarity. * Persistent rabbit. Optimized SimpleFin maps logic by implementing batch queries for manual account and unlinked count checks, reducing N+1 issues. Improved clarity of rake task argument descriptions and error messages for better usability. * Lost a commit somehow, resolved here. Refactored transaction extra details logic by introducing `build_transaction_extra_details` helper to improve clarity, reusability, and reduce view complexity. Enhanced rake tasks with strict dry-run validation and better error handling. Updated schema to allow nullable `merchant_id` and added conditional unique indexes for recurring transactions. * Refactored sensitive data redaction in `simplefin_unlink` task for recursive handling, optimized SQL sanitization in `simplefin_holdings_backfill`, improved error handling in `transactions_helper`, and streamlined day change calculation logic in `Holding` model. * Lint fix * Removed per PR comments. * Also removing per PR comment. * git commit -m "SimpleFIN polish: preserve #manual-accounts wrapper, unify \"manual\" scope, and correct unlinked counts - Preserve #manual-accounts wrapper: switch non-empty updates to turbo_stream.update and background broadcast_update_to; keep empty-path replace to render <div id=\"manual-accounts\"></div> - Unify definition of manual accounts via Account.visible_manual (visible + legacy-nil + no AccountProvider); reuse in controllers, jobs, and helper - Correct setup/unlinked counts: SimplefinItem::Syncer#finalize_setup_counts and maps now consider AccountProvider links (legacy account AND provider must be absent) Deleted: - app/models/simplefin_item/relink_service.rb - app/controllers/concerns/simplefin_items/relink_helpers.rb - app/javascript/controllers/auto_relink_controller.js - app/views/simplefin_items/_relink_modal.html.erb - app/views/simplefin_items/manual_relink.html.erb - app/views/simplefin_items/relink.html.erb - test/services/simplefin_item/relink_service_test.rb Refs: PR #318 unified link/unlink; PR #267 SimpleFIN; follow-up to fix wrapper ID loss and counting drift." * Extend unlinked account check to include "Investment" type * set SimpleFIN item for `balances`, remove redundant unpacking, and improve holdings task error * SimpleFIN: add `errors` action + modal; do not reintroduce legacy relink actions; removed dead helper * FIX simpleFIN linking * Add delay back, tests benefit from it * Put cache back in * Remove empty `rake` task * Small spelling fixes. --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: sokie <sokysrm@gmail.com> Co-authored-by: Dylan Corrales <deathcamel58@gmail.com>
250 lines
12 KiB
Plaintext
250 lines
12 KiB
Plaintext
<%# locals: (simplefin_item:) %>
|
||
|
||
<%= tag.div id: dom_id(simplefin_item) do %>
|
||
<details open class="group bg-container p-4 shadow-border-xs rounded-xl">
|
||
<summary class="flex items-center justify-between gap-2 focus-visible:outline-hidden">
|
||
<div class="flex items-center gap-2">
|
||
<%= icon "chevron-right", class: "group-open:transform group-open:rotate-90" %>
|
||
|
||
<div class="flex items-center justify-center h-8 w-8 bg-success/10 rounded-full">
|
||
<% if simplefin_item.logo.attached? %>
|
||
<%= image_tag simplefin_item.logo, class: "rounded-full h-full w-full", loading: "lazy" %>
|
||
<% else %>
|
||
<div class="flex items-center justify-center">
|
||
<%= tag.p simplefin_item.name.first.upcase, class: "text-success text-xs font-medium" %>
|
||
</div>
|
||
<% end %>
|
||
</div>
|
||
|
||
<div class="pl-1 text-sm">
|
||
<div class="flex items-center gap-2">
|
||
<%= tag.p simplefin_item.name, class: "font-medium text-primary" %>
|
||
<% if simplefin_item.scheduled_for_deletion? %>
|
||
<p class="text-destructive text-sm animate-pulse"><%= t(".deletion_in_progress") %></p>
|
||
<% end %>
|
||
</div>
|
||
<% if simplefin_item.accounts.any? %>
|
||
<p class="text-xs text-secondary">
|
||
<%= simplefin_item.institution_summary %>
|
||
</p>
|
||
<%# Extra inline badges from latest sync stats %>
|
||
<% stats = (@simplefin_sync_stats_map || {})[simplefin_item.id] || {} %>
|
||
<% if stats.present? %>
|
||
<div class="flex items-center gap-2 mt-1">
|
||
<% if stats["unlinked_accounts"].to_i > 0 %>
|
||
<%= render DS::Tooltip.new(text: "Accounts need setup", icon: "link-2", size: "sm") %>
|
||
<span class="text-xs text-secondary">Unlinked: <%= stats["unlinked_accounts"].to_i %></span>
|
||
<% end %>
|
||
|
||
<% if stats["accounts_skipped"].to_i > 0 %>
|
||
<%= render DS::Tooltip.new(text: "Some accounts were skipped due to errors during sync", icon: "alert-triangle", size: "sm", color: "warning") %>
|
||
<span class="text-xs text-warning">Skipped: <%= stats["accounts_skipped"].to_i %></span>
|
||
<% end %>
|
||
|
||
<% if stats["rate_limited"].present? || stats["rate_limited_at"].present? %>
|
||
<% ts = stats["rate_limited_at"] %>
|
||
<% ago = (ts.present? ? (begin; time_ago_in_words(Time.parse(ts)); rescue StandardError; nil; end) : nil) %>
|
||
<%= render DS::Tooltip.new(
|
||
text: (ago ? "Rate limited (" + ago + " ago)" : "Rate limited recently"),
|
||
icon: "clock",
|
||
size: "sm",
|
||
color: "warning"
|
||
) %>
|
||
<% end %>
|
||
|
||
<% if stats["total_errors"].to_i > 0 || (stats["errors"].is_a?(Array) && stats["errors"].any?) %>
|
||
<% tooltip_text = simplefin_error_tooltip(stats) %>
|
||
<% if tooltip_text.present? %>
|
||
<%= render DS::Tooltip.new(text: tooltip_text, icon: "alert-octagon", size: "sm", color: "warning") %>
|
||
<% end %>
|
||
<%= render DS::Link.new(text: "View errors", icon: "alert-octagon", variant: "secondary", href: errors_simplefin_item_path(simplefin_item), frame: "modal") %>
|
||
<% end %>
|
||
|
||
<% if stats["total_accounts"].to_i > 0 %>
|
||
<span class="text-xs text-secondary">Total: <%= stats["total_accounts"].to_i %></span>
|
||
<% end %>
|
||
</div>
|
||
<% end %>
|
||
<% end %>
|
||
<%# Determine if all reported errors are benign duplicate-skips (suppress scary banner). Computed in controller for testability. %>
|
||
<% duplicate_only_errors = (@simplefin_duplicate_only_map || {})[simplefin_item.id] || false %>
|
||
<% if simplefin_item.syncing? %>
|
||
<div class="text-secondary flex items-center gap-1">
|
||
<%= icon "loader", size: "sm", class: "animate-spin" %>
|
||
<%= tag.span t(".syncing") %>
|
||
</div>
|
||
<% elsif simplefin_item.requires_update? %>
|
||
<div class="text-warning flex items-center gap-1">
|
||
<%= icon "alert-triangle", size: "sm", color: "warning" %>
|
||
<%= tag.span t(".requires_update") %>
|
||
</div>
|
||
<% elsif simplefin_item.rate_limited_message.present? %>
|
||
<div class="text-warning flex items-center gap-1">
|
||
<%= icon "clock", size: "sm", color: "warning" %>
|
||
<%= tag.span simplefin_item.rate_limited_message %>
|
||
</div>
|
||
<% elsif simplefin_item.sync_error.present? && !duplicate_only_errors %>
|
||
<div class="text-secondary flex items-center gap-1">
|
||
<%= render DS::Tooltip.new(text: simplefin_item.sync_error, icon: "alert-circle", size: "sm", color: "destructive") %>
|
||
<%= tag.span t(".error"), class: "text-destructive" %>
|
||
</div>
|
||
<% elsif duplicate_only_errors %>
|
||
<div class="text-secondary flex items-center gap-1">
|
||
<%= icon "info", size: "sm" %>
|
||
<%= tag.span "Some accounts were skipped as duplicates — use ‘Link existing accounts’ to merge.", class: "text-secondary" %>
|
||
</div>
|
||
<% else %>
|
||
<p class="text-secondary">
|
||
<% if simplefin_item.last_synced_at %>
|
||
<% if simplefin_item.sync_status_summary %>
|
||
<%= t(".status_with_summary", timestamp: time_ago_in_words(simplefin_item.last_synced_at), summary: simplefin_item.sync_status_summary) %>
|
||
<% else %>
|
||
<%= t(".status", timestamp: time_ago_in_words(simplefin_item.last_synced_at)) %>
|
||
<% end %>
|
||
<% else %>
|
||
<%= t(".status_never") %>
|
||
<% end %>
|
||
</p>
|
||
<% end %>
|
||
</div>
|
||
</div>
|
||
|
||
<div class="flex items-center gap-2">
|
||
<% if simplefin_item.requires_update? %>
|
||
<%= render DS::Link.new(
|
||
text: t(".update"),
|
||
icon: "refresh-cw",
|
||
variant: "secondary",
|
||
href: edit_simplefin_item_path(simplefin_item),
|
||
frame: "modal"
|
||
) %>
|
||
<% elsif Rails.env.development? %>
|
||
<%= icon(
|
||
"refresh-cw",
|
||
as_button: true,
|
||
href: sync_simplefin_item_path(simplefin_item)
|
||
) %>
|
||
<% end %>
|
||
|
||
|
||
|
||
<%= render DS::Menu.new do |menu| %>
|
||
<% menu.with_item(
|
||
variant: "button",
|
||
text: t(".delete"),
|
||
icon: "trash-2",
|
||
href: simplefin_item_path(simplefin_item),
|
||
method: :delete,
|
||
confirm: CustomConfirm.for_resource_deletion(simplefin_item.name, high_severity: true)
|
||
) %>
|
||
<% end %>
|
||
</div>
|
||
</summary>
|
||
|
||
<% unless simplefin_item.scheduled_for_deletion? %>
|
||
<div class="space-y-4 mt-4">
|
||
<% if simplefin_item.accounts.any? %>
|
||
<%= render "accounts/index/account_groups", accounts: simplefin_item.accounts %>
|
||
<% end %>
|
||
|
||
|
||
<%# Sync summary (collapsible) %>
|
||
<% stats = (@simplefin_sync_stats_map || {})[simplefin_item.id] || {} %>
|
||
<% if stats.present? %>
|
||
<details class="group bg-surface rounded-lg border border-surface-inset/50">
|
||
<summary class="flex items-center justify-between gap-2 p-3 cursor-pointer">
|
||
<div class="flex items-center gap-2">
|
||
<%= icon "chevron-right", class: "group-open:transform group-open:rotate-90" %>
|
||
<span class="text-sm text-primary font-medium">Sync summary</span>
|
||
</div>
|
||
<div class="flex items-center gap-2 text-xs text-secondary">
|
||
<% if simplefin_item.last_synced_at %>
|
||
<span>Last sync: <%= time_ago_in_words(simplefin_item.last_synced_at) %> ago</span>
|
||
<% end %>
|
||
</div>
|
||
</summary>
|
||
<div class="p-3 text-sm text-secondary grid grid-cols-1 md:grid-cols-2 gap-3">
|
||
<div>
|
||
<h4 class="text-primary font-medium mb-1">Accounts</h4>
|
||
<div class="flex items-center gap-3">
|
||
<span>Total: <%= stats["total_accounts"].to_i %></span>
|
||
<span>Linked: <%= stats["linked_accounts"].to_i %></span>
|
||
<span>Unlinked: <%= stats["unlinked_accounts"].to_i %></span>
|
||
<% institutions = simplefin_item.connected_institutions %>
|
||
<span>Institutions: <%= institutions.size %></span>
|
||
</div>
|
||
</div>
|
||
<div>
|
||
<h4 class="text-primary font-medium mb-1">Transactions</h4>
|
||
<div class="flex items-center gap-3">
|
||
<span>Seen: <%= stats["tx_seen"].to_i %></span>
|
||
<span>Imported: <%= stats["tx_imported"].to_i %></span>
|
||
<span>Updated: <%= stats["tx_updated"].to_i %></span>
|
||
<span>Skipped: <%= stats["tx_skipped"].to_i %></span>
|
||
</div>
|
||
</div>
|
||
<div>
|
||
<h4 class="text-primary font-medium mb-1">Holdings</h4>
|
||
<div class="flex items-center gap-3">
|
||
<span>Processed: <%= stats["holdings_processed"].to_i %></span>
|
||
</div>
|
||
</div>
|
||
<div>
|
||
<h4 class="text-primary font-medium mb-1">Health</h4>
|
||
<div class="flex items-center gap-3">
|
||
<% if stats["rate_limited"].present? || stats["rate_limited_at"].present? %>
|
||
<% ts = stats["rate_limited_at"] %>
|
||
<% ago = (ts.present? ? (begin; time_ago_in_words(Time.parse(ts)); rescue StandardError; nil; end) : nil) %>
|
||
<span class="text-warning">Rate limited <%= ago ? "(#{ago} ago)" : "recently" %></span>
|
||
<% end %>
|
||
<% total_errors = stats["total_errors"].to_i %>
|
||
<% if total_errors > 0 %>
|
||
<span class="text-destructive">Errors: <%= total_errors %></span>
|
||
<% else %>
|
||
<span>Errors: 0</span>
|
||
<% end %>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
</details>
|
||
<% end %>
|
||
|
||
<%# Compute unlinked SimpleFin accounts (no legacy account and no AccountProvider link)
|
||
# Prefer controller-provided map; fallback to a local query so the card stays accurate after Turbo broadcasts %>
|
||
<% unlinked_count = if defined?(@simplefin_unlinked_count_map) && @simplefin_unlinked_count_map
|
||
@simplefin_unlinked_count_map[simplefin_item.id] || 0
|
||
else
|
||
begin
|
||
simplefin_item.simplefin_accounts
|
||
.left_joins(:account, :account_provider)
|
||
.where(accounts: { id: nil }, account_providers: { id: nil })
|
||
.count
|
||
rescue => e
|
||
Rails.logger.warn("SimpleFin card: unlinked_count fallback failed: #{e.class} - #{e.message}")
|
||
0
|
||
end
|
||
end %>
|
||
|
||
<% if unlinked_count.to_i > 0 %>
|
||
<div class="p-4 flex flex-col gap-3 items-center justify-center">
|
||
<p class="text-primary font-medium text-sm"><%= t(".setup_needed") %></p>
|
||
<p class="text-secondary text-sm"><%= t(".setup_description") %></p>
|
||
<%= render DS::Link.new(
|
||
text: t(".setup_action"),
|
||
icon: "settings",
|
||
variant: "primary",
|
||
href: setup_accounts_simplefin_item_path(simplefin_item),
|
||
frame: :modal
|
||
) %>
|
||
</div>
|
||
<% elsif simplefin_item.accounts.empty? %>
|
||
<div class="p-4 flex flex-col gap-3 items-center justify-center">
|
||
<p class="text-primary font-medium text-sm"><%= t(".no_accounts_title") %></p>
|
||
<p class="text-secondary text-sm"><%= t(".no_accounts_description") %></p>
|
||
</div>
|
||
<% end %>
|
||
</div>
|
||
<% end %>
|
||
</details>
|
||
<% end %>
|