mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
* Implement API v1 Imports controller - Add Api::V1::ImportsController with index, show, and create actions - Add Jbuilder views for index and show - Add integration tests - Implement row generation logic in create action - Update routes * Validate import account belongs to family - Add validation to Import model to ensure account belongs to the same family - Add regression test case in Api::V1::ImportsControllerTest * updating docs to be more detailed * Rescue StandardError instead of bare rescue in ImportsController * Optimize Imports API and fix documentation - Implement rows_count counter cache for Imports - Preload rows in Api::V1::ImportsController#show - Update documentation to show correct OAuth scopes * Fix formatting in ImportsControllerTest * Permit all import parameters and fix unknown attribute error * Restore API routes for auth, chats, and messages * removing pr summary * Fix trailing whitespace and configured? test failure - Update Import#configured? to use rows_count for performance and consistency - Mock rows_count in TransactionImportTest - Fix trailing whitespace in migration * Harden security and fix mass assignment in ImportsController - Handle type and account_id explicitly in create action - Rename import_params to import_config_params for clarity - Validate type against Import::TYPES * Fix MintImport rows_count update and migration whitespace - Update MintImport#generate_rows_from_csv to update rows_count counter cache - Fix trailing whitespace and final newline in AddRowsCountToImports migration * Implement full-screen Drag and Drop CSV import on Transactions page - Add DragAndDropImport Stimulus controller listening on document - Add full-screen overlay with icon and text to Transactions index - Update ImportsController to handle direct file uploads via create action - Add system test for drag and drop functionality * Implement Drag and Drop CSV upload on Import Upload page - Add drag-and-drop-import controller to import/uploads/show - Add full-screen overlay to import/uploads/show - Annotate upload form and input with drag-and-drop targets - Add PR_SUMMARY.md * removing pr summary * Add file validation to ImportsController - Validate file size (max 10MB) and MIME type in create action - Prevent memory exhaustion and invalid file processing - Defined MAX_CSV_SIZE and ALLOWED_MIME_TYPES in Import model * Refactor dragLeave logic with counter pattern to prevent flickering * Extract shared drag-and-drop overlay partial - Create app/views/imports/_drag_drop_overlay.html.erb - Update transactions/index and import/uploads/show to use the partial - Reduce code duplication in views * Update Brakeman and harden ImportsController security - Update brakeman to 7.1.2 - Explicitly handle type assignment in ImportsController#create to avoid mass assignment - Remove :type from permitted import parameters * Fix trailing whitespace in DragAndDropImportTest * Don't commit LLM comments as file * FIX add api validation --------- Co-authored-by: Carlos Adames <cj@Carloss-MacBook-Air.local> Co-authored-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: sokie <sokysrm@gmail.com>
331 lines
9.4 KiB
Ruby
331 lines
9.4 KiB
Ruby
class RuleImport < Import
|
|
def import!
|
|
transaction do
|
|
rows.each do |row|
|
|
create_or_update_rule_from_row(row)
|
|
end
|
|
end
|
|
end
|
|
|
|
def column_keys
|
|
%i[name resource_type active effective_date conditions actions]
|
|
end
|
|
|
|
def required_column_keys
|
|
%i[resource_type conditions actions]
|
|
end
|
|
|
|
def mapping_steps
|
|
[]
|
|
end
|
|
|
|
def dry_run
|
|
{ rules: rows_count }
|
|
end
|
|
|
|
def csv_template
|
|
csv_string = CSV.generate do |csv|
|
|
csv << %w[name resource_type* active effective_date conditions* actions*]
|
|
|
|
csv << [
|
|
"Categorize groceries",
|
|
"transaction",
|
|
"true",
|
|
"2024-01-01",
|
|
'[{"condition_type":"transaction_name","operator":"like","value":"grocery"}]',
|
|
'[{"action_type":"set_transaction_category","value":"Groceries"}]'
|
|
]
|
|
|
|
csv << [
|
|
"Auto-categorize transactions",
|
|
"transaction",
|
|
"true",
|
|
"",
|
|
'[{"condition_type":"transaction_name","operator":"like","value":"amazon"}]',
|
|
'[{"action_type":"auto_categorize"}]'
|
|
]
|
|
end
|
|
|
|
CSV.parse(csv_string, headers: true)
|
|
end
|
|
|
|
def generate_rows_from_csv
|
|
rows.destroy_all
|
|
|
|
csv_rows.each do |row|
|
|
normalized_row = normalize_rule_row(row)
|
|
|
|
rows.create!(
|
|
name: normalized_row[:name].to_s.strip,
|
|
resource_type: normalized_row[:resource_type].to_s.strip,
|
|
active: parse_boolean(normalized_row[:active]),
|
|
effective_date: normalized_row[:effective_date].to_s.strip,
|
|
conditions: normalized_row[:conditions].to_s.strip,
|
|
actions: normalized_row[:actions].to_s.strip,
|
|
currency: default_currency
|
|
)
|
|
end
|
|
end
|
|
|
|
def parsed_csv
|
|
@parsed_csv ||= Import.parse_csv_str(raw_file_str, col_sep: col_sep)
|
|
end
|
|
|
|
private
|
|
|
|
def normalize_rule_row(row)
|
|
fields = row.fields
|
|
name, resource_type, active, effective_date = fields[0..3]
|
|
conditions, actions = extract_conditions_and_actions(fields[4..])
|
|
|
|
{
|
|
name: row["name"].presence || name,
|
|
resource_type: row["resource_type"].presence || resource_type,
|
|
active: row["active"].presence || active,
|
|
effective_date: row["effective_date"].presence || effective_date,
|
|
conditions: conditions,
|
|
actions: actions
|
|
}
|
|
end
|
|
|
|
def extract_conditions_and_actions(fragments)
|
|
pieces = Array(fragments).compact
|
|
return [ "", "" ] if pieces.empty?
|
|
|
|
combined = pieces.join(col_sep)
|
|
|
|
# If the CSV was split incorrectly because of unescaped quotes in the JSON
|
|
# payload, re-assemble the last two logical columns by splitting on the
|
|
# boundary between the two JSON arrays: ...]","[...
|
|
parts = combined.split(/(?<=\])"\s*,\s*"(?=\[)/, 2)
|
|
parts = [ pieces[0], pieces[1] ] if parts.length < 2
|
|
|
|
parts.map do |part|
|
|
next "" unless part
|
|
|
|
# Remove any stray leading/trailing quotes left from CSV parsing
|
|
part.to_s.strip.gsub(/\A"+|"+\z/, "")
|
|
end
|
|
end
|
|
|
|
def create_or_update_rule_from_row(row)
|
|
rule_name = row.name.to_s.strip.presence
|
|
resource_type = row.resource_type.to_s.strip
|
|
|
|
# Validate resource type
|
|
unless resource_type == "transaction"
|
|
errors.add(:base, "Unsupported resource type: #{resource_type}")
|
|
raise ActiveRecord::RecordInvalid.new(self)
|
|
end
|
|
|
|
# Parse conditions and actions from JSON
|
|
begin
|
|
conditions_data = parse_json_safely(row.conditions, "conditions")
|
|
actions_data = parse_json_safely(row.actions, "actions")
|
|
rescue JSON::ParserError => e
|
|
errors.add(:base, "Invalid JSON in conditions or actions: #{e.message}")
|
|
raise ActiveRecord::RecordInvalid.new(self)
|
|
end
|
|
|
|
# Validate we have at least one action
|
|
if actions_data.empty?
|
|
errors.add(:base, "Rule must have at least one action")
|
|
raise ActiveRecord::RecordInvalid.new(self)
|
|
end
|
|
|
|
# Find or create rule
|
|
rule = if rule_name.present?
|
|
family.rules.find_or_initialize_by(name: rule_name, resource_type: resource_type)
|
|
else
|
|
family.rules.build(resource_type: resource_type)
|
|
end
|
|
|
|
rule.active = row.active || false
|
|
rule.effective_date = parse_date(row.effective_date)
|
|
|
|
# Clear existing conditions and actions
|
|
rule.conditions.destroy_all
|
|
rule.actions.destroy_all
|
|
|
|
# Create conditions
|
|
conditions_data.each do |condition_data|
|
|
build_condition(rule, condition_data)
|
|
end
|
|
|
|
# Create actions
|
|
actions_data.each do |action_data|
|
|
build_action(rule, action_data)
|
|
end
|
|
|
|
rule.save!
|
|
end
|
|
|
|
def build_condition(rule, condition_data, parent: nil)
|
|
condition_type = condition_data["condition_type"]
|
|
operator = condition_data["operator"]
|
|
value = resolve_import_condition_value(condition_data)
|
|
|
|
condition = if parent
|
|
parent.sub_conditions.build(
|
|
condition_type: condition_type,
|
|
operator: operator,
|
|
value: value
|
|
)
|
|
else
|
|
rule.conditions.build(
|
|
condition_type: condition_type,
|
|
operator: operator,
|
|
value: value
|
|
)
|
|
end
|
|
|
|
# Handle compound conditions with sub_conditions
|
|
if condition_data["sub_conditions"].present?
|
|
condition_data["sub_conditions"].each do |sub_condition_data|
|
|
build_condition(rule, sub_condition_data, parent: condition)
|
|
end
|
|
end
|
|
|
|
condition
|
|
end
|
|
|
|
def build_action(rule, action_data)
|
|
action_type = action_data["action_type"]
|
|
value = resolve_import_action_value(action_data)
|
|
|
|
rule.actions.build(
|
|
action_type: action_type,
|
|
value: value
|
|
)
|
|
end
|
|
|
|
def resolve_import_condition_value(condition_data)
|
|
condition_type = condition_data["condition_type"]
|
|
value = condition_data["value"]
|
|
|
|
return value unless value.present?
|
|
|
|
# Map category names to UUIDs
|
|
if condition_type == "transaction_category"
|
|
category = family.categories.find_by(name: value)
|
|
unless category
|
|
category = family.categories.create!(
|
|
name: value,
|
|
color: Category::UNCATEGORIZED_COLOR,
|
|
classification: "expense",
|
|
lucide_icon: "shapes"
|
|
)
|
|
end
|
|
return category.id
|
|
end
|
|
|
|
# Map merchant names to UUIDs
|
|
if condition_type == "transaction_merchant"
|
|
merchant = family.merchants.find_by(name: value)
|
|
unless merchant
|
|
merchant = family.merchants.create!(name: value)
|
|
end
|
|
return merchant.id
|
|
end
|
|
|
|
value
|
|
end
|
|
|
|
def resolve_import_action_value(action_data)
|
|
action_type = action_data["action_type"]
|
|
value = action_data["value"]
|
|
|
|
return value unless value.present?
|
|
|
|
# Map category names to UUIDs
|
|
if action_type == "set_transaction_category"
|
|
category = family.categories.find_by(name: value)
|
|
# Create category if it doesn't exist
|
|
unless category
|
|
category = family.categories.create!(
|
|
name: value,
|
|
color: Category::UNCATEGORIZED_COLOR,
|
|
classification: "expense",
|
|
lucide_icon: "shapes"
|
|
)
|
|
end
|
|
return category.id
|
|
end
|
|
|
|
# Map merchant names to UUIDs
|
|
if action_type == "set_transaction_merchant"
|
|
merchant = family.merchants.find_by(name: value)
|
|
# Create merchant if it doesn't exist
|
|
unless merchant
|
|
merchant = family.merchants.create!(name: value)
|
|
end
|
|
return merchant.id
|
|
end
|
|
|
|
# Map tag names to UUIDs
|
|
if action_type == "set_transaction_tags"
|
|
tag = family.tags.find_by(name: value)
|
|
# Create tag if it doesn't exist
|
|
unless tag
|
|
tag = family.tags.create!(name: value)
|
|
end
|
|
return tag.id
|
|
end
|
|
|
|
value
|
|
end
|
|
|
|
def parse_boolean(value)
|
|
return true if value.to_s.downcase.in?(%w[true 1 yes y])
|
|
return false if value.to_s.downcase.in?(%w[false 0 no n])
|
|
false
|
|
end
|
|
|
|
def parse_date(value)
|
|
return nil if value.blank?
|
|
Date.parse(value.to_s)
|
|
rescue ArgumentError
|
|
nil
|
|
end
|
|
|
|
def parse_json_safely(json_string, field_name)
|
|
return [] if json_string.blank?
|
|
|
|
# Clean up the JSON string - remove extra escaping that might come from CSV parsing
|
|
cleaned = json_string.to_s.strip
|
|
|
|
# Remove surrounding quotes if present (both single and double)
|
|
cleaned = cleaned.gsub(/\A["']+|["']+\z/, "")
|
|
|
|
# Handle multiple levels of escaping iteratively
|
|
# Keep unescaping until no more changes occur
|
|
loop do
|
|
previous = cleaned.dup
|
|
|
|
# Unescape quotes - handle patterns like \" or \\\" or \\\\\" etc.
|
|
# Replace any number of backslashes followed by a quote with just a quote
|
|
cleaned = cleaned.gsub(/\\+"/, '"')
|
|
cleaned = cleaned.gsub(/\\+'/, "'")
|
|
|
|
# Unescape backslashes (\\\\ becomes \)
|
|
cleaned = cleaned.gsub(/\\\\/, "\\")
|
|
|
|
break if cleaned == previous
|
|
end
|
|
|
|
# Handle unicode escapes like \u003e (but only if not over-escaped)
|
|
# Try to find and decode unicode escapes
|
|
cleaned = cleaned.gsub(/\\u([0-9a-fA-F]{4})/i) do |match|
|
|
code_point = $1.to_i(16)
|
|
[ code_point ].pack("U")
|
|
rescue
|
|
match # If decoding fails, keep the original
|
|
end
|
|
|
|
# Try parsing
|
|
JSON.parse(cleaned)
|
|
rescue JSON::ParserError => e
|
|
raise JSON::ParserError.new("Invalid JSON in #{field_name}: #{e.message}. Raw value: #{json_string.inspect}")
|
|
end
|
|
end
|