Files
sure/test/system/account_activity_test.rb
Copilot 3199c9b76d Prevent long category labels from overflowing or crowding adjacent controls (#1498)
* Initial plan

* Fix category delete dialog dropdown overflow

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/200da7a4-fd59-4ae4-a709-f631ccf21e8c

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Tighten category deletion regression test

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/200da7a4-fd59-4ae4-a709-f631ccf21e8c

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Fix deletion button text overflow

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/e802e01f-079e-4322-ba03-b222ab5d4b84

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Preserve category menu spacing on mobile

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/74b5dd1e-7935-4356-806a-759bff911930

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Prevent account activity label overlap on mobile

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/e94027d6-e230-44c8-99a1-6e5645bec82b

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Fix wide account activity category overflow

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/4ad79894-2935-47a3-8d37-037e2bd14376

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Linter

* Fix flaky system tests in CI

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/3507447f-363f-4759-807c-c62a2858d270

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Reset system test viewport between tests

Agent-Logs-Url: https://github.com/we-promise/sure/sessions/357a43b1-11c5-49be-972d-0592a37d97b1

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
2026-04-19 18:40:50 +02:00

119 lines
3.9 KiB
Ruby

require "application_system_test_case"
class AccountActivityTest < ApplicationSystemTestCase
DEFAULT_VIEWPORT_WIDTH = 1400
DEFAULT_VIEWPORT_HEIGHT = 1400
setup do
ensure_tailwind_build
sign_in users(:family_admin)
reset_viewport
@account = accounts(:depository)
@transaction_entry = @account.entries.create!(
name: "Duplicate source",
date: Date.current,
amount: 42.50,
currency: "USD",
entryable: Transaction.new(category: categories(:food_and_drink))
)
@valuation_entry = @account.entries.create!(
name: "Current balance",
date: 1.day.ago.to_date,
amount: 1000,
currency: "USD",
entryable: Valuation.new
)
end
test "account activity shows duplicate action for a selected transaction" do
visit account_url(@account, tab: "activity")
find("#" + dom_id(@transaction_entry, "selection")).check
within "#entry-selection-bar" do
assert_selector "a[title='Duplicate']:not(.hidden)"
end
end
test "account activity hides duplicate action for a selected valuation" do
visit account_url(@account, tab: "activity")
find("#" + dom_id(@valuation_entry, "selection")).check
within "#entry-selection-bar" do
assert_selector "a[title='Duplicate'].hidden", visible: false
end
end
test "account activity keeps long category names from overflowing the amount on mobile" do
category = categories(:food_and_drink)
category.update!(name: "Super Long Category Name That Should Stop Before The Amount On Mobile")
page.current_window.resize_to(315, 643)
visit account_url(@account, tab: "activity")
row = find("##{dom_id(@transaction_entry)}")
amount = row.find("p.privacy-sensitive", visible: true)
category_name = row.find("#category_name_mobile_#{@transaction_entry.entryable.id}", visible: true)
assert amount.visible?
assert category_name.visible?
row_rect = row.native.rect
amount_rect = amount.native.rect
viewport_width = page.evaluate_script("window.innerWidth")
page_scroll_width = page.evaluate_script("document.documentElement.scrollWidth")
assert_operator amount_rect.x + amount_rect.width, :<=, row_rect.x + row_rect.width
assert_operator page_scroll_width, :<=, viewport_width
end
test "account activity keeps long category names from overlapping the amount on wide screens" do
category = categories(:food_and_drink)
category.update!(name: "Super Long Category Name That Should Stop Before The Amount On Wide Screens Too")
page.current_window.resize_to(1280, 900)
visit account_url(@account, tab: "activity")
metrics = page.evaluate_script(<<~JS)
(() => {
const row = document.getElementById("#{dom_id(@transaction_entry)}");
const categoryButton = row.querySelector("##{dom_id(@transaction_entry.entryable, "category_menu_desktop")} button");
const categoryName = categoryButton.querySelector("[data-testid='category-name']");
const amount = row.querySelector(".privacy-sensitive");
const categoryRect = categoryButton.getBoundingClientRect();
const amountRect = amount.getBoundingClientRect();
return {
categoryRight: categoryRect.right,
amountLeft: amountRect.left,
categoryOverflow: categoryName.scrollWidth > categoryName.clientWidth
};
})()
JS
assert_operator metrics["categoryRight"], :<=, metrics["amountLeft"]
assert metrics["categoryOverflow"]
end
private
def ensure_tailwind_build
return if self.class.instance_variable_defined?(:@tailwind_css_built)
system({ "RAILS_ENV" => "test" }, "bin/rails", "tailwindcss:build", exception: true)
self.class.instance_variable_set(:@tailwind_css_built, true)
end
def teardown
reset_viewport
super
end
def reset_viewport
page.current_window.resize_to(DEFAULT_VIEWPORT_WIDTH, DEFAULT_VIEWPORT_HEIGHT) if page&.current_window
end
end