mirror of
https://github.com/we-promise/sure.git
synced 2026-09-04 06:11:12 +00:00
Blaž Dular
826c4a356e
* feat(wise): add Wise integration with JAR savings account and activity support - Add WiseItem/WiseAccount models with full sync pipeline (importer, syncer, processor) - Detect income vs expense using targetAccount == recipientId from borderless accounts API - Support JAR (SAVINGS) accounts with totalWorth balance and savings subtype - Fetch JAR activity via profile activities API (INTERBALANCE, BALANCE_CASHBACK, BALANCE_ASSET_FEE) - Route INTERBALANCE activities to both JAR and STANDARD accounts and link as Transfer records - Add provider connection status registration, routes, views, and i18n - Add migration for wise_items and wise_accounts tables - Add tests for WiseAccount, WiseEntry::Processor, WiseActivity::Processor, WiseItem::Importer, and WiseItem#link_jar_transfers! * chore(lint): add ignore to security scan (false positive) * fix(wise): address PR review feedback on activity routing, HTML stripping, rate limiting, and scope extraction - Replace title string matching in activity_for_account? with resource.id vs balance_id comparison to avoid breakage when users rename JAR accounts on Wise - Replace gsub(/<[^>]+>/, "") with ActionController::Base.helpers.strip_tags to safely handle user-controlled HTML-like content - Wrap paginated API calls in with_rate_limit_retry (up to 3 attempts, exponential backoff) to handle 429 responses during fetch_jar_activities and fetch_transfers - Extract WiseAccount.unlinked scope and remove duplicated left_joins query from controller * fix(wise): address PR #2433 review feedback - Wire @wise_items into AccountsController#index so linked accounts appear on /accounts - Fix find_wise_account_for_linking to preserve .active scope via .merge instead of .then - Fix cross-currency incoming transfer amount to use targetValue instead of sourceValue - Add missing select_profiles.session_expired locale key - Add missing account_name interpolation to link_existing_account success notice - Use i18n for profile type labels in profile_display_name - Trigger wise_item.sync_later after account linking in all three linking actions - Isolate fee transaction failure so it no longer aborts the main transfer import - Use bare raise in WiseActivity/WiseEntry processors to preserve original backtrace - Re-raise in WiseItem::Unlinking to prevent silently orphaned Holdings - Fix avatar badge to use design system tokens (bg-container-inset, text-primary) * fix(wise): fix INTERBALANCE routing and encrypt pending token in session * fix(wise): replace hand-rolled buttons/links with DS::Button and DS::Link Address repeated sure-design DS drift findings: migrate all manual Tailwind button_to and link_to calls in Wise views to DS::Button (outline/outline_destructive variants) and DS::Link (secondary variant). Add missing provider_panel.disconnect locale key for the disconnect button text. * fix(wise): use render_provider_panel_error in create instead of missing new template * fix(wise): add missing comma in PROVIDERS array CI failed with a SyntaxError because the questrade entry wasn't comma-terminated before the wise entry. * chore(wise): re-add pipelock:ignore for pending token param Lost when the token source moved from session to an encrypted params field in 0b5dc886, causing the CI secret scanner to flag a false positive. * fix(test): widen random ticker suffix to avoid rare collision flake hex(2) only yields 65536 possible tickers, so create_trade's 4 calls per test run had a small but nonzero chance of colliding on the unique ticker+exchange index. hex(8) makes collisions practically impossible.
66 lines
2.6 KiB
ERB
66 lines
2.6 KiB
ERB
<%= turbo_frame_tag "modal" do %>
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: t(".title")) %>
|
|
|
|
<% dialog.with_body do %>
|
|
<div class="space-y-4">
|
|
<p class="text-sm text-secondary"><%= t(".description", product_name: product_name) %></p>
|
|
|
|
<% if @available_accounts.empty? %>
|
|
<div class="p-6 flex flex-col gap-3 items-center justify-center text-center">
|
|
<%= icon "check-circle", size: "lg", class: "text-success" %>
|
|
<p class="text-primary font-medium"><%= t(".no_accounts_found") %></p>
|
|
</div>
|
|
<div class="flex justify-end">
|
|
<%= render DS::Link.new(
|
|
text: t(".cancel"),
|
|
variant: :secondary,
|
|
href: @return_to || new_account_path,
|
|
frame: "_top"
|
|
) %>
|
|
</div>
|
|
<% else %>
|
|
<%= form_with url: link_accounts_wise_items_path,
|
|
method: :post,
|
|
data: { turbo_frame: "_top" },
|
|
class: "space-y-4" do %>
|
|
<%= hidden_field_tag :wise_item_id, @wise_item.id %>
|
|
<%= hidden_field_tag :accountable_type, @accountable_type %>
|
|
<%= hidden_field_tag :return_to, @return_to %>
|
|
|
|
<div class="space-y-2">
|
|
<% @available_accounts.each do |wise_account| %>
|
|
<label class="flex items-start gap-3 p-3 border border-primary rounded-lg hover:bg-subtle cursor-pointer transition-colors">
|
|
<%= radio_button_tag "wise_account_id", wise_account.id, false, class: "mt-1" %>
|
|
<div class="flex-1">
|
|
<p class="font-medium text-sm text-primary"><%= wise_account.name %></p>
|
|
<p class="text-xs text-secondary mt-0.5">
|
|
<%= format_money(Money.new(wise_account.current_balance || 0, wise_account.currency)) %>
|
|
·
|
|
<%= wise_account.currency %>
|
|
</p>
|
|
</div>
|
|
</label>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="flex gap-2 justify-end pt-4">
|
|
<%= render DS::Link.new(
|
|
text: t(".cancel"),
|
|
variant: :secondary,
|
|
href: @return_to || new_account_path,
|
|
frame: "_top"
|
|
) %>
|
|
<%= render DS::Button.new(
|
|
text: t(".link_account"),
|
|
variant: :primary,
|
|
type: :submit
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|