mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 16:42:18 +00:00
ec38a89d0c
A user wants to manage patrimonial history — a document-backed record of a family's wealth where every figure traces back to the statement it came from — by pointing an external agent harness at Sure. That model belongs in the harness, not in Sure: it needs numbered build deltas, golden tests and closed periods that a mutable Postgres row cannot provide. What Sure was missing was the seam. The Statement Vault already does most of the work — original bytes retained, SHA-256 dedup, period detection, account matching with a confidence score, reconciliation against ledger balances, and a month-by-month coverage map — but it is reachable only from the web UI. An agent could not archive a document, cite one, or check for gaps. Adds five preview MCP tools over what already exists, plus a citation grammar for values the agent writes: - upload_account_statement, list_account_statements, get_account_statement, get_statement_coverage - record_valuation, whose source citation is parsed rather than trusted: ["estimated: "] citation [" (grade: A|B|C)"]. An uncited or free-styled value is rejected at the write boundary instead of landing in the ledger looking authoritative. link and reject are deliberately not exposed. Attaching a statement to an account is the human's decision, and the vault UI is where it is made; the agent reports the suggested match and stops there. Assistant.function_classes now takes a user so preview tools stay out of the default surface. They are hidden from tools/list and not callable by name without the preference enabled, and the vault tools re-check the manager role and per-account permissions, since MCP calls never pass through a controller. Docs: the blueprint this implements, and a guide covering which side owns which layer, the vocabulary map between the two, the monthly runbook, and the gaps (non-user holders, non-statement documents, one value per date). No migrations, no API endpoints, no UI. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFDp9HhXDeswadu4cxFojn
74 lines
2.3 KiB
Ruby
74 lines
2.3 KiB
Ruby
require "test_helper"
|
|
|
|
class Assistant::Function::GetAccountStatementTest < ActiveSupport::TestCase
|
|
setup do
|
|
@user = users(:family_admin)
|
|
@account = accounts(:depository)
|
|
@function = Assistant::Function::GetAccountStatement.new(@user)
|
|
end
|
|
|
|
test "returns statement identity and reconciliation checks" do
|
|
statement = create_statement(account: @account)
|
|
statement.update!(
|
|
period_start_on: Date.new(2024, 1, 1),
|
|
period_end_on: Date.new(2024, 1, 31),
|
|
opening_balance: 100,
|
|
closing_balance: 200,
|
|
currency: @account.currency
|
|
)
|
|
|
|
result = @function.call("statement_id" => statement.id)
|
|
|
|
assert result[:success]
|
|
assert_equal statement.id, result[:statement][:id]
|
|
assert_equal statement.content_sha256, result[:statement][:content_sha256]
|
|
assert_equal "2024-01-31", result[:statement][:period_end_on]
|
|
assert result[:statement].key?(:reconciliation_checks)
|
|
end
|
|
|
|
test "returns not_found for an unknown id" do
|
|
result = @function.call("statement_id" => SecureRandom.uuid)
|
|
|
|
assert_not result[:success]
|
|
assert_equal "not_found", result[:error]
|
|
end
|
|
|
|
test "returns not_found for a non-uuid id" do
|
|
result = @function.call("statement_id" => "nope")
|
|
|
|
assert_not result[:success]
|
|
assert_equal "not_found", result[:error]
|
|
end
|
|
|
|
test "returns not_found for a statement the user cannot view" do
|
|
statement = create_statement(account: accounts(:other_asset))
|
|
|
|
result = Assistant::Function::GetAccountStatement.new(users(:family_member)).call("statement_id" => statement.id)
|
|
|
|
assert_not result[:success]
|
|
assert_equal "not_found", result[:error]
|
|
end
|
|
|
|
test "refuses a user who cannot manage the vault" do
|
|
statement = create_statement(account: @account)
|
|
|
|
result = Assistant::Function::GetAccountStatement.new(family_guest).call("statement_id" => statement.id)
|
|
|
|
assert_not result[:success]
|
|
assert_equal "forbidden", result[:error]
|
|
end
|
|
|
|
private
|
|
def create_statement(account:)
|
|
AccountStatement.create_from_upload!(
|
|
family: @user.family,
|
|
account: account,
|
|
file: uploaded_file(
|
|
filename: "statement-#{SecureRandom.hex(4)}.csv",
|
|
content_type: "text/csv",
|
|
content: "date,amount\n2024-01-01,#{SecureRandom.random_number(1000)}\n"
|
|
)
|
|
)
|
|
end
|
|
end
|