`transactions_section_controller.js` was added by #454 for the upcoming
recurring-transactions section. #771 moved recurring transactions to a
dedicated tab and removed the only mount, so the controller and its whole
persistence chain have been dead since then:
`data-controller="transactions-section"` appears nowhere in app/views or
app/components, and `transactions_section_collapsed?` had no callers outside
its own definition.
Removed:
- app/javascript/controllers/transactions_section_controller.js
- User#update_transactions_preferences
- User#transactions_section_collapsed?
- TransactionsController#update_preferences + #preferences_params
- the `patch :update_preferences` route on the transactions collection
The only caller of /transactions/update_preferences was the dead controller
itself. No tests referenced any of it — the `update_preferences` cases in
pages_controller_test cover the dashboard's route — which is how it stayed
dead unnoticed.
No migration: users who collapsed a section before #771 keep a stale
`transactions_collapsed_sections` key in `users.preferences`, and nothing
reads it after this.
The dashboard and reports section-layout preferences are untouched.
Guillem Arias Fauste
7f0a6fb6dc