Files
sure/app/helpers/budgets_helper.rb
Tao Chen aacbb5ef3b Budget page refactor: split into(All - Over Budget - On Track) (#1195)
* Optimize UI in budget

* update locales

* Optimize UI

* optimize suggested_daily_spending

* try over_budget and on_track

* update locale

* optimize

* add budgets_helper.rb

* fix

* hide no buget and no expense sub-catogory

* Optimize

* Optimize button on phone

* Fix Pipelock CI noise

* using section to render both overbudget and onTrack

* hide last ruler

* fix

* update test

---------

Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
2026-04-13 20:03:55 +02:00

71 lines
2.7 KiB
Ruby

module BudgetsHelper
def budget_has_over_budget?(budget)
return false unless budget.initialized?
budget.budget_categories.any?(&:any_over_budget?)
end
def budget_categories_view_state(budget)
@budget_categories_view_state ||= {}
@budget_categories_view_state[budget.object_id] ||= build_budget_categories_view_state(budget)
end
private
def build_budget_categories_view_state(budget)
uncategorized_budget_category = budget.uncategorized_budget_category
all_category_groups = BudgetCategory::Group.for(budget.budget_categories)
over_budget_groups = if budget.initialized?
filtered_groups_for(all_category_groups) { |budget_category| budget_category.any_over_budget? }
else
[]
end
show_over_budget_uncategorized = budget.initialized? && uncategorized_budget_category.any_over_budget?
over_budget_count = visible_count_for(over_budget_groups) { |budget_category| budget_category.any_over_budget? }
over_budget_count += 1 if show_over_budget_uncategorized
on_track_groups = if budget.initialized?
filtered_groups_for(all_category_groups) { |budget_category| budget_category.visible_on_track? }
else
all_category_groups
end
show_on_track_uncategorized = all_category_groups.any? && (!budget.initialized? || uncategorized_budget_category.on_track?)
on_track_count = visible_count_for(on_track_groups) { |budget_category| parent_visible_for_on_track?(budget, budget_category) }
on_track_count += 1 if show_on_track_uncategorized
visible_expenses_empty = on_track_count.zero?
{
uncategorized_budget_category: uncategorized_budget_category,
visible_expenses_empty: visible_expenses_empty,
over_budget_groups: over_budget_groups,
show_over_budget_uncategorized: show_over_budget_uncategorized,
over_budget_count: over_budget_count,
on_track_groups: on_track_groups,
show_on_track_uncategorized: show_on_track_uncategorized,
on_track_count: on_track_count
}
end
def parent_visible_for_on_track?(budget, budget_category)
budget.initialized? ? budget_category.visible_on_track? : true
end
def filtered_groups_for(groups)
groups.each_with_object([]) do |group, filtered_groups|
visible_subcategories = group.budget_subcategories.select { |budget_category| yield(budget_category) }
next unless yield(group.budget_category) || visible_subcategories.any?
filtered_groups << BudgetCategory::Group.new(group.budget_category, visible_subcategories)
end
end
def visible_count_for(groups)
groups.sum do |group|
(yield(group.budget_category) ? 1 : 0) + group.budget_subcategories.count
end
end
end