mirror of
https://github.com/we-promise/sure.git
synced 2026-05-08 13:14:58 +00:00
* SimpleFIN: setup UX + same-provider relink + card-replacement detection Fixes three bugs and adds auto-detection for credit-card fraud replacement. Bugs: - Importer: per-institution auth errors no longer flip the whole item to requires_update. Partial errors stay on sync_stats so other institutions keep syncing. - Setup page: new activity badges (recent / dormant / empty / likely-closed) via SimplefinAccount::ActivitySummary. Likely-closed (dormant + near-zero balance + prior history) defaults to "skip" in the type picker. - Relink: link_existing_account allows SimpleFIN to SimpleFIN swaps by atomically detaching the old AccountProvider inside a transaction. Adds "Change SimpleFIN account" menu item on linked-account dropdowns. Feature (credit-card scope only): - SimplefinItem::ReplacementDetector runs post-sync. Pairs a linked dormant zero-balance sfa with an unlinked active sfa at the same institution and account type. Persists suggestions on Sync#sync_stats. - Inline banner on the SimpleFIN item card prompts relink via CustomConfirm. Per-pair dismiss button scoped to the current sync (resurfaces on next sync if still applicable). Auto-suppresses once the relink has landed. Dev tooling: - bin/rails simplefin:seed_fraud_scenario[email] creates a realistic broken pair for manual QA; cleanup_fraud_scenario reverses it. * Address review feedback on #1493 - ReplacementDetector: symmetric one-to-one matching. Two dormant cards pointing at the same active card are now both skipped — previously the detector could emit two suggestions that would clobber each other if the user accepted both. - ReplacementDetector: require non-blank institution names on both sides before matching. Blank-vs-blank was accidentally treated as equal, risking cross-provider false matches when SimpleFIN omitted org_data. - ActivitySummary: fall back to "posted" when "transacted_at" is 0 (SimpleFIN's "unknown" sentinel). Integer 0 is truthy in Ruby, so the previous `|| fallback` short-circuited and ignored posted. - Controller: dismiss key is now the (dormant, active) pair so dismissing one candidate for a dormant card doesn't suppress others. - Helper test: freeze time around "6.hours.ago" and "5.days.ago" assertions so they don't flake when the suite runs before 06:00. * Address second review pass on #1493 - ReplacementDetector: canonicalize account_type in one place so filtering (supported_type?) and matching (type_matches?) agree on "credit card" vs "credit_card" variants. - ReplacementDetector: skip candidates with nil current_balance. nil is "unknown," not "zero" — previously fell back to 0 and passed the near- zero gate, allowing suggestions without balance evidence.
143 lines
4.4 KiB
Ruby
143 lines
4.4 KiB
Ruby
class SimplefinAccount < ApplicationRecord
|
|
include Encryptable
|
|
|
|
# Encrypt raw payloads if ActiveRecord encryption is configured
|
|
if encryption_ready?
|
|
encrypts :raw_payload
|
|
encrypts :raw_transactions_payload
|
|
encrypts :raw_holdings_payload
|
|
end
|
|
|
|
belongs_to :simplefin_item
|
|
|
|
# Legacy association via foreign key (will be removed after migration)
|
|
has_one :account, dependent: :nullify, foreign_key: :simplefin_account_id
|
|
|
|
# New association through account_providers
|
|
has_one :account_provider, as: :provider, dependent: :destroy
|
|
has_one :linked_account, through: :account_provider, source: :account
|
|
|
|
validates :name, :account_type, :currency, presence: true
|
|
validates :account_id, uniqueness: { scope: :simplefin_item_id, allow_nil: true }
|
|
validate :has_balance
|
|
|
|
# Helper to get account using new system first, falling back to legacy
|
|
def current_account
|
|
linked_account || account
|
|
end
|
|
|
|
# Summary of transaction activity derived from raw_transactions_payload.
|
|
# Used by the setup UI and ReplacementDetector to distinguish live vs dormant
|
|
# accounts without re-parsing the payload at every call site.
|
|
def activity_summary
|
|
ActivitySummary.new(raw_transactions_payload)
|
|
end
|
|
|
|
# Ensure there is an AccountProvider link for this SimpleFin account and its current Account.
|
|
# Safe and idempotent; returns the AccountProvider or nil if no account is associated yet.
|
|
def ensure_account_provider!
|
|
acct = current_account
|
|
return nil unless acct
|
|
|
|
provider = AccountProvider
|
|
.find_or_initialize_by(provider_type: "SimplefinAccount", provider_id: id)
|
|
.tap do |p|
|
|
p.account = acct
|
|
p.save!
|
|
end
|
|
|
|
# Reload the association so future accesses don't return stale/nil value
|
|
reload_account_provider
|
|
|
|
provider
|
|
rescue => e
|
|
Rails.logger.warn("SimplefinAccount##{id}: failed to ensure AccountProvider link: #{e.class} - #{e.message}")
|
|
nil
|
|
end
|
|
|
|
def upsert_simplefin_snapshot!(account_snapshot)
|
|
# Convert to symbol keys or handle both string and symbol keys
|
|
snapshot = account_snapshot.with_indifferent_access
|
|
|
|
# Map SimpleFin field names to our field names
|
|
update!(
|
|
current_balance: parse_balance(snapshot[:balance]),
|
|
available_balance: parse_balance(snapshot[:"available-balance"]),
|
|
currency: parse_currency(snapshot[:currency]),
|
|
account_type: snapshot["type"] || "unknown",
|
|
account_subtype: snapshot["subtype"],
|
|
name: snapshot[:name],
|
|
account_id: snapshot[:id],
|
|
balance_date: parse_balance_date(snapshot[:"balance-date"]),
|
|
extra: snapshot[:extra],
|
|
org_data: snapshot[:org],
|
|
raw_payload: account_snapshot
|
|
)
|
|
end
|
|
|
|
def upsert_simplefin_transactions_snapshot!(transactions_snapshot)
|
|
assign_attributes(
|
|
raw_transactions_payload: transactions_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
private
|
|
|
|
def parse_balance(balance_value)
|
|
return nil if balance_value.nil?
|
|
|
|
case balance_value
|
|
when String
|
|
BigDecimal(balance_value)
|
|
when Numeric
|
|
BigDecimal(balance_value.to_s)
|
|
else
|
|
nil
|
|
end
|
|
rescue ArgumentError
|
|
nil
|
|
end
|
|
|
|
def parse_currency(currency_value)
|
|
return "USD" if currency_value.blank?
|
|
|
|
# SimpleFin currency can be a 3-letter code or a URL for custom currencies
|
|
if currency_value.start_with?("http")
|
|
# For custom currency URLs, we'll just use the last part as currency code
|
|
# This is a simplification - in production you might want to fetch the currency info
|
|
begin
|
|
URI.parse(currency_value).path.split("/").last.upcase
|
|
rescue URI::InvalidURIError => e
|
|
Rails.logger.warn("Invalid currency URI for SimpleFin account: #{currency_value}, error: #{e.message}")
|
|
"USD"
|
|
end
|
|
else
|
|
currency_value.upcase
|
|
end
|
|
end
|
|
|
|
def parse_balance_date(balance_date_value)
|
|
return nil if balance_date_value.nil?
|
|
|
|
case balance_date_value
|
|
when String
|
|
Time.parse(balance_date_value)
|
|
when Numeric
|
|
Time.at(balance_date_value)
|
|
when Time, DateTime
|
|
balance_date_value
|
|
else
|
|
nil
|
|
end
|
|
rescue ArgumentError, TypeError
|
|
Rails.logger.warn("Invalid balance date for SimpleFin account: #{balance_date_value}")
|
|
nil
|
|
end
|
|
def has_balance
|
|
return if current_balance.present? || available_balance.present?
|
|
errors.add(:base, "SimpleFin account must have either current or available balance")
|
|
end
|
|
end
|