mirror of
https://github.com/we-promise/sure.git
synced 2026-05-08 13:14:58 +00:00
0fe1e06645
* refactor(design-system): migrate fg-* utilities to text-* and remove namespace
The design system carried two parallel namespaces for foreground colors:
text-* (canonical, ~2,000 uses) and fg-* (32 uses). Most fg-* tokens
were 1:1 duplicates of a text-* counterpart. fg-gray was nearly
identical to text-secondary, with a one-step shade difference in dark
mode.
This PR migrates all 32 usages to their text-* equivalents and removes
the fg-* block from the design tokens. Closes #1606.
Mapping:
- fg-inverse -> text-inverse (20 usages, identical light/dark values)
- fg-gray -> text-secondary (7 usages; light values match, dark is
one step lighter: gray-300 vs gray-400)
- fg-primary -> text-primary (3 usages, identical values)
- fg-subdued -> text-subdued (2 usages, identical values)
The four other fg-* tokens (fg-contrast, fg-primary-variant,
fg-secondary, fg-secondary-variant) had zero usages despite being
defined; they are removed without replacement.
JSON / build:
- design/tokens/sure.tokens.json: $version 1.0.0 -> 2.0.0 (breaking
schema change per the policy added in #1620). 8 fg-* token
definitions removed.
- button-bg-ghost-hover's dark value still references "fg-inverse"
internally; rewritten to "bg-gray-800 text-inverse" so the cleanup
doesn't break that utility.
- _generated.css regenerated. 42 utility blocks now (was 50).
Lookbook tokens preview:
- The Text & foregrounds section dropped its split between text-*
(canonical) and fg-* (legacy). Now a single section listing the
five text-* utilities. The "(legacy)" framing is gone since there's
no legacy left.
README:
- design/tokens/README.md's button-bg-ghost-hover edge-case example
updated to reflect the new "bg-gray-800 text-inverse" dark value.
Visual review needed in dark mode:
- Anywhere icons use the application_helper#icon helper with
color: "default" (most icons in the app). The default class moved
from fg-gray (gray-400 dark) to text-secondary (gray-300 dark), so
default-color icons render slightly lighter in dark mode.
- DS::Buttonish icons in secondary buttons (same shade shift).
- DS::Link icons (same).
- Time series chart axes (same).
- All tooltips, account add flow, settings hostings buttons,
invitations, AI consent, family export, danger-zone buttons --
these used fg-inverse, which is identical to text-inverse, so no
visual change expected.
* fix(design-system): use inverse pair on tooltips for readable dark mode
* fix(lookbook): use semantic tokens in menu preview header text
* fix(lookbook): set text-primary on layout body so previews inherit theme
* fix(design-system): keep shadows dark-toned in dark mode
Inverting shadows to white|8% on dark surfaces produces a halo
effect rather than an elevation cue, and stacks redundantly with
the alpha-white 1px ring already in shadow-border-*.
Switch dark-mode shadows to black at progressively higher alpha
(25%/30%/35%/40%/50% for xs..xl) so they read as actual cast
shadows on near-black surfaces. Surface-tint differences and the
existing alpha-white border ring continue to handle elevation
hierarchy and edge definition.
Approach matches Material 3, Apple HIG, IBM Carbon, Refactoring UI,
and the dark-mode shadows used in Linear/Vercel/Stripe.
* fix(design-system): set text-primary on DS::Dialog element
Browser UA stylesheets apply color: black directly to <dialog>,
which overrides ancestor inheritance even when a body or html
ancestor sets a theme-aware color. Unstyled child content then
renders black regardless of theme.
Setting text-primary on the dialog element itself defeats the UA
override and lets descendants inherit the semantic token.
* fix(lookbook): use shadow css vars in effects preview so dark theme renders
* Revert "fix(design-system): keep shadows dark-toned in dark mode"
This reverts commit 3e9d76ed0b.
* fix(design-system): use opacity-70 instead of text-inverse/70 in value tooltip
The custom @utility text-inverse expands to @apply text-white and
isn't modifier-aware, so text-inverse/70 produced no CSS at all and
the muted labels fell through to inherited color (invisible on the
white pill in dark mode).
Replace with text-inverse + opacity-70. Same visual effect, works
with the existing utility definition.
93 lines
4.0 KiB
Plaintext
93 lines
4.0 KiB
Plaintext
<%# locals: (form:, amount_method:, currency_method:, **options) %>
|
|
|
|
<% currency_value = if options[:currency_value_override].present?
|
|
options[:currency_value_override]
|
|
elsif form.object && form.object.respond_to?(currency_method)
|
|
form.object.public_send(currency_method)
|
|
end
|
|
currency = Money::Currency.new(currency_value || options[:default_currency] || "USD") %>
|
|
|
|
<div class="form-field <%= options[:container_class] %>"
|
|
data-controller="money-field"
|
|
<% if options[:precision].present? %> data-money-field-precision-value="<%= options[:precision] %>"<% end %>
|
|
<% if options[:step].present? %> data-money-field-step-value="<%= options[:step] %>"<% end %>>
|
|
<% if options[:label_tooltip] %>
|
|
<div class="form-field__header">
|
|
<%= form.label options[:label] || t(".label"), class: "form-field__label" do %>
|
|
<%= options[:label] || t(".label") %>
|
|
<% if options[:required] %>
|
|
<span class="text-red-500 ml-0.5">*</span>
|
|
<% end %>
|
|
<% end %>
|
|
<div class="form-field__actions">
|
|
<div data-controller="tooltip">
|
|
<%= icon "help-circle", size: "sm", color: "default", class: "cursor-help" %>
|
|
<div role="tooltip" data-tooltip-target="tooltip" class="tooltip bg-inverse text-inverse text-sm p-2 rounded w-64">
|
|
<%= options[:label_tooltip] %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<div class="form-field__body">
|
|
<% unless options[:label_tooltip] %>
|
|
<%= form.label options[:label] || t(".label"), class: "form-field__label" do %>
|
|
<%= options[:label] || t(".label") %>
|
|
<% if options[:required] %>
|
|
<span class="text-red-500 ml-0.5">*</span>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|
|
|
|
<div class="flex items-center gap-1">
|
|
<div class="flex items-center grow gap-1">
|
|
<span class="text-subdued text-sm" data-money-field-target="symbol">
|
|
<%= currency.symbol %>
|
|
</span>
|
|
|
|
<%= form.number_field amount_method,
|
|
class: "form-field__input",
|
|
inline: true,
|
|
placeholder: "100",
|
|
value: if options[:value]
|
|
sprintf("%.#{options[:precision].presence || currency.default_precision}f", options[:value])
|
|
elsif form.object && form.object.respond_to?(amount_method)
|
|
val = form.object.public_send(amount_method)
|
|
sprintf("%.#{options[:precision].presence || currency.default_precision}f", val) if val.present?
|
|
end,
|
|
min: options[:min] || -99999999999999,
|
|
max: options[:max] || 99999999999999,
|
|
step: options[:step] || currency.step,
|
|
disabled: options[:disabled],
|
|
data: (options[:amount_data] || {}).merge({
|
|
"money-field-target": "amount",
|
|
"auto-submit-form-target": ("auto" if options[:auto_submit])
|
|
}.compact),
|
|
required: options[:required] %>
|
|
</div>
|
|
|
|
<% unless options[:hide_currency] %>
|
|
<div>
|
|
<% currency_data = (options[:currency_data] || {}).merge({
|
|
"money-field-target": "currency",
|
|
"auto-submit-form-target": ("auto" if options[:auto_submit])
|
|
}.compact)
|
|
# Preserve any existing action and append money-field handler
|
|
existing_action = currency_data.delete("action")
|
|
currency_data["action"] = ["change->money-field#handleCurrencyChange", existing_action].compact.join(" ")
|
|
%>
|
|
<%= form.select currency_method,
|
|
currency_picker_options_for_family(extra: currency.iso_code),
|
|
{ inline: true, selected: currency.iso_code },
|
|
{
|
|
class: "w-fit pr-5 disabled:text-subdued form-field__input",
|
|
disabled: options[:disable_currency],
|
|
data: currency_data
|
|
} %>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
</div>
|