pro3958 150e659846 fix(tags): return 404 for missing or cross-family tag deletion (#2703) ...

Tag::DeletionsController looked up the tag and its replacement with
find_by, so a missing id or a tag belonging to another family left
@tag nil. create then called @tag.replace_and_destroy!, raising
NoMethodError and returning a 500 instead of a 404.

Use find in set_tag and set_replacement_tag so an out-of-scope id
raises ActiveRecord::RecordNotFound, which is rendered as 404. The
replacement lookup keeps a presence guard so deleting without a
replacement still works. This mirrors Category::DeletionsController.

Fixes #2469

Co-authored-by: agentloop <agentloop@localhost>

2026-07-30 07:15:50 +02:00

..

admin

Fix SSO provider settings updates (#2210)

2026-06-06 09:14:50 +02:00

api/v1

update transactions_controller (#1953)

2026-07-26 01:42:18 +02:00

category

Prevent long category labels from overflowing or crowding adjacent controls (#1498)

2026-04-19 18:40:50 +02:00

concerns

Russian language support added (#2005)

2026-07-08 08:10:18 +02:00

import

feat(imports): add YNAB CSV import (#2361)

2026-06-16 08:32:17 +02:00

settings

fix(settings): allow clearing an encrypted provider API key (#2544)

2026-07-26 07:31:25 +02:00

tag

fix(tags): return 404 for missing or cross-family tag deletion (#2703)

2026-07-30 07:15:50 +02:00

transactions

fix(transactions): show full dates in the categorize wizard (#2633)

2026-07-17 07:19:57 +02:00

account_statements_controller_test.rb

feat(statements): add account statement vault (#1753)

2026-05-13 21:05:11 +02:00

accountable_sparklines_controller_test.rb

perf(sparklines): avoid full account loads for linked charts (#2128)

2026-06-02 18:47:09 +02:00

accounts_controller_test.rb

perf(accounts): preload transfer, category, and split-parent associations on show (#2441)

2026-07-30 03:42:50 +02:00

akahu_items_controller_test.rb

feat(provider): Akahu integration (#1921)

2026-06-02 21:44:57 +02:00

archived_exports_controller_test.rb

Add post-trial inactive Family cleanup with data archival (#1199)

2026-03-14 20:14:18 +01:00

binance_items_controller_test.rb

feat(binance): add full account sync and transaction processing (#1822)

2026-05-27 23:58:00 +02:00

brex_items_controller_test.rb

feat(sync): add Brex provider connections (#1752)

2026-05-13 18:13:48 +02:00

budget_categories_controller_test.rb

fix(budgets): stop auto-matched transfers leaking into category cards (#1059) (#1588)

2026-05-01 00:59:48 +02:00

categories_controller_test.rb

fix(categories): avoid index N+1 queries (#2089)

2026-06-01 21:59:46 +02:00

chats_controller_test.rb

feat(assistant): improve chat functionality and update tests - refactor configurable model, update OpenAI provider, enhance chat form UI, and improve test coverage (#2316)

2025-05-27 05:04:58 -05:00

coinbase_items_controller_test.rb

Add Coinbase exchange integration with CDP API support (#704)

2026-01-21 22:56:39 +01:00

coinstats_items_controller_test.rb

Prevent long category labels from overflowing or crowding adjacent controls (#1498)

2026-04-19 18:40:50 +02:00

credit_cards_controller_test.rb

feat(sync): add toggle to parse Enable Banking CC balance as available credit (#2512)

2026-07-21 09:15:24 +02:00

cryptos_controller_test.rb

Fix crypto subtype for trades api (#1022)

2026-02-19 19:51:42 +01:00

currencies_controller_test.rb

…

current_sessions_controller_test.rb

Improve account sync performance, handle concurrent market data syncing (#2236)

2025-05-15 10:19:56 -04:00

depositories_controller_test.rb

Add per-account toggle to disable automatic transaction categorization (#2636)

2026-07-17 07:22:50 +02:00

email_confirmations_controller_test.rb

…

enable_banking_items_controller_test.rb

feat(enable_banking): support MFA/decoupled banks and harden session handling (#2174)

2026-06-04 19:53:52 +02:00

exchange_rates_controller_test.rb

Add exchange rate feature with multi-currency transactions and transfers support (#1099)

2026-04-08 21:05:58 +02:00

family_exports_controller_test.rb

feat(sync): family-facing cancellation for syncs, imports, and exports (#2685)

2026-07-17 06:57:54 +02:00

family_merchants_controller_test.rb

fix(merchants): preserve user-selected merchant colors on save (#2760) (#2802)

2026-07-26 01:38:31 +02:00

goal_pledges_controller_test.rb

feat(goals): balance-derived + pledges (#1798)

2026-06-02 14:00:16 +02:00

goals_controller_test.rb

fix(goals): scope funding-account picker to the current user's accessible accounts (#2172)

2026-06-04 11:52:28 +02:00

holdings_controller_test.rb

feat: Enhance holding detail drawer with live price sync and enriched overview (#1086)

2026-03-06 10:05:52 +01:00

ibkr_items_controller_test.rb

Add Interactive Brokers Provider (#1722)

2026-05-12 23:45:19 +02:00

impersonation_sessions_controller_test.rb

Family sharing (#1272)

2026-03-25 10:50:23 +01:00

imports_controller_test.rb

feat(sync): family-facing cancellation for syncs, imports, and exports (#2685)

2026-07-17 06:57:54 +02:00

indexa_capital_items_controller_test.rb

Fix IndexaCapital sync, account setup, and balance/type bugs (#1562)

2026-04-27 18:33:22 +02:00

insights_controller_test.rb

feat(insights): gate the insights feed behind preview features (#2788)

2026-07-26 07:18:23 +02:00

investments_controller_test.rb

…

invitations_controller_test.rb

fix(invitations): allow re-inviting after an unaccepted invite expires (#2543)

2026-07-08 08:59:54 +02:00

invite_codes_controller_test.rb

Add default family selection for invite-only onboarding mode (#1174)

2026-03-10 18:12:53 +01:00

kraken_items_controller_test.rb

feat(providers): add Kraken exchange sync (#1759)

2026-05-12 00:22:37 +02:00

loans_controller_test.rb

Fix loan account subtype not persisting on create (#1491)

2026-04-18 00:06:24 +02:00

mcp_controller_test.rb

feat(mcp): OAuth 2.1 auth for MCP — connect Claude.ai with your Sure login (#2234)

2026-06-11 16:19:58 +02:00

mercury_items_controller_test.rb

fix(mercury): support named multiple API connections (#1627)

2026-05-03 10:56:31 +02:00

messages_controller_test.rb

fix(chat): surface and recover from undelivered assistant responses (#2436)

2026-06-25 05:44:44 +02:00

mfa_controller_test.rb

fix(auth): hash MFA backup codes (#1629)

2026-05-05 01:20:57 +02:00

oauth_metadata_controller_test.rb

feat(mcp): OAuth 2.1 auth for MCP — connect Claude.ai with your Sure login (#2234)

2026-06-11 16:19:58 +02:00

oauth_registration_controller_test.rb

fix: block unsafe OAuth redirect URIs in dynamic registration (#2638)

2026-07-22 00:41:58 +02:00

oidc_accounts_controller_test.rb

Share family accounts with invited members on every sign-up path (#2650)

2026-07-14 01:39:26 +02:00

onboardings_controller_test.rb

Fix SimpleFIN partial auth reconnect status (#2509)

2026-06-28 16:12:33 +02:00

other_assets_controller_test.rb

…

other_liabilities_controller_test.rb

…

pages_controller_test.rb

Feature/dashboard Add "Money In / Out" dashboard widget with monthly bar chart (#2594)

2026-07-25 04:59:29 +02:00

password_resets_controller_test.rb

Add security measures for SSO-only users: block password resets, enforce SSO authentication, and refactor validations for JIT provisioning. (#569)

2026-01-07 20:17:23 +01:00

pending_duplicate_merges_controller_test.rb

feat: add pending transaction manual merging tool (#1088)

2026-03-14 20:32:13 +01:00

plaid_items_controller_test.rb

fix(plaid): surface configuration/product-access errors from the Link flow (#1792) (#1991)

2026-05-28 14:55:21 +02:00

properties_controller_test.rb

Add RentCast & Realie integration for automatic property data and valuations (#2727)

2026-07-25 04:47:58 +02:00

pwa_controller_test.rb

fix(pwa): serve manifest for html accept headers (#1828)

2026-05-18 19:10:01 +02:00

questrade_items_controller_test.rb

feat(provider): add native Questrade brokerage provider integration (#2534)

2026-07-08 09:00:49 +02:00

redbark_items_controller_test.rb

feat(redbark): add australian bank sync (redbark) (#2794)

2026-07-26 07:40:25 +02:00

registrations_controller_test.rb

Share family accounts with invited members on every sign-up path (#2650)

2026-07-14 01:39:26 +02:00

reports_controller_test.rb

fix(reports): hide tax-advantaged transactions in breakdown (#2549)

2026-07-08 08:51:22 +02:00

rules_controller_test.rb

fix(rules): count blocked rule transactions (#1782)

2026-05-14 21:56:49 +02:00

sessions_controller_test.rb

feat: Introduce macOS app v0.1.0 (#2762)

2026-07-26 07:44:06 +02:00

simplefin_items_controller_test.rb

SimpleFIN: setup UX + same-provider relink + card-replacement detection (#1493)

2026-04-18 09:50:34 +02:00

snaptrade_items_controller_test.rb

feat(snaptrade): replace device-flow OAuth with authorization-code + PKCE flow (#2747)

2026-07-24 22:45:44 +02:00

sophtron_items_controller_test.rb

[codex] Add Sophtron manual sync fixes (#1714)

2026-05-09 21:55:20 +02:00

splits_controller_test.rb

feat(splits): add exclusion support for splits and improve rendering (#1661)

2026-05-09 12:36:41 +02:00

subscriptions_controller_test.rb

Hide contribution payments from demo user(s) (#738)

2026-01-23 12:35:49 +01:00

syncs_controller_test.rb

feat(sync): family-facing cancellation for syncs, imports, and exports (#2685)

2026-07-17 06:57:54 +02:00

tags_controller_test.rb

feat(transactions): add inline tag creation and search in txn form (#1719)

2026-06-01 21:46:32 +02:00

trades_controller_test.rb

Record dividends and interest as Trades in investment accounts (#1311)

2026-03-29 10:08:54 +02:00

trading212_controller_test.rb

Add support for trading212 integration in investments sync (#2513)

2026-07-25 04:54:30 +02:00

transaction_attachments_controller_test.rb

feat(transaction): add support for file attachments using Active Storage (#713)

2026-03-14 23:56:27 +01:00

transactions_controller_test.rb

fix: Transaction Pagination Skipping Entries (#2179)

2026-06-16 10:51:51 +02:00

transfer_matches_controller_test.rb

fix: Transfers were not syncing between accounts (#987)

2026-02-16 13:50:06 +01:00

transfers_controller_test.rb

Fix fee display consistency, derive fees from entries, clean schema churn

2026-06-28 19:47:53 +00:00

users_controller_test.rb

feat: add currency management for families with enabled currencies (#1419)

2026-04-13 19:53:04 +02:00

valuations_controller_test.rb

feat(entries): Add amount validation and robustify monetizable concern (#1680)

2026-05-05 20:07:40 +02:00

vehicles_controller_test.rb

Add instituion details & notes to Account model (#481)

2025-12-24 00:59:50 +01:00

webhooks_controller_test.rb

…

wise_items_controller_test.rb

fix(wise): redirect after token submission instead of rendering inline (#2730)

2026-07-21 01:28:53 +02:00