Files
sure/app/components/goals/card_component.rb
Guillem Arias 91baa62604 fix(goals): cover money displays with privacy-sensitive
Audit-driven sweep. The class was already on the obvious surfaces (KPI
strip, ring center, card balance, funding-accounts breakdown); these
were the secondary surfaces missed in the initial PR — money interpolated
into descriptive prose, account-picker balances, live previews, and the
projection chart tooltip.

- card_component: target divisor next to the masked balance, pace line,
  and behind-status footer (`footer_has_money?` helper keeps non-money
  branches unmasked so paused / archived / "Goal reached" copy stays
  readable in privacy mode).
- show: header_summary (target + date subtitle), to_go remaining,
  inactive recap body, celebration body, catch_up body.
- _status_callout: conditional on `goal.status == :behind` — only that
  branch carries an amount; on_track / no_target_date have date or
  static copy.
- _form_edit + _form_stepper: account balance shown in the linked-
  account picker rows.
- _form_stepper review section: reviewSummary + reviewSuggested ps
  (Stimulus injects target / suggested $X/mo into both).
- _pending_pledge_banner: banner title span (amount + account + days).
- goal_pledges/new: live preview p (Stimulus injects "Reaches X%, $A of
  $B" / "Hits your $B target").
- goal_projection_chart_controller: tooltip was inline-styled with
  hard-coded gray-900 + white (DS drift) and had no privacy class.
  Replaced cssText with className using bg-container + text-primary +
  border-secondary + rounded-lg + privacy-sensitive — mirrors the
  pattern in time_series_chart_controller and the post-#1996 sankey
  fix. Tooltip now respects theme and privacy mode.
2026-05-27 10:14:13 +02:00

121 lines
3.5 KiB
Ruby

class Goals::CardComponent < ApplicationComponent
RING_SIZE = 64
RING_STROKE = 6
def initialize(goal:, filterable: true)
@goal = goal
@filterable = filterable
end
attr_reader :goal, :filterable
def progress_percent
goal.progress_percent
end
def ring_color
case goal.status
when :reached, :on_track then "var(--color-success)"
when :behind then "var(--color-warning)"
else "var(--color-gray-400)"
end
end
def linked_accounts
@linked_accounts ||= goal.linked_accounts.to_a
end
# Open + unexpired pledges are preloaded on the index via the
# `.includes(:open_pledges, ...)` chain in GoalsController#index, so
# this is a hit on the in-memory association — no N+1.
def has_pending_pledge?
pending_pledges_count.positive?
end
def pending_pledges_count
@pending_pledges_count ||= goal.open_pledges.size
end
def linked_accounts_count_label
I18n.t("goals.goal_card.accounts", count: linked_accounts.size)
end
# Single screen-reader sentence for the card's title <a> aria-label.
# Without this, the whole-card link would inherit every nested text node
# as its accessible name (>15 strings on a typical card).
def aria_label
status_text = I18n.t("goals.status.#{goal.display_status}")
progress_text = I18n.t("goals.goal_card.aria_progress",
percent: progress_percent,
target: goal.target_amount_money.format(precision: 0))
[ goal.name, status_text, progress_text ].join(", ")
end
def secondary_line
if goal.completed?
I18n.t("goals.goal_card.completed")
elsif goal.target_date.nil?
I18n.t("goals.goal_card.no_target_date")
else
days = (goal.target_date - Date.current).to_i
if days >= 0
I18n.t("goals.goal_card.days_left_by", count: days, date: I18n.l(goal.target_date, format: :long))
else
I18n.t("goals.goal_card.past_due")
end
end
end
def ring_circumference
@ring_circumference ||= 2 * Math::PI * ring_radius
end
def ring_radius
@ring_radius ||= (RING_SIZE - RING_STROKE) / 2.0
end
def ring_offset
pct = [ [ progress_percent.to_i, 0 ].max, 100 ].min
ring_circumference * (1 - pct / 100.0)
end
def pace_line
return nil if goal.archived? || goal.paused? || goal.completed? || goal.status == :reached
avg = goal.pace_money.format(precision: 0)
target = goal.monthly_target_amount ? Money.new(goal.monthly_target_amount, goal.currency).format(precision: 0) : nil
if target
I18n.t("goals.goal_card.pace_with_target", avg: avg, target: target)
else
I18n.t("goals.goal_card.pace_no_target", avg: avg)
end
end
def footer_line
if goal.archived?
I18n.t("goals.goal_card.footer_archived")
elsif goal.paused?
I18n.t("goals.goal_card.footer_paused")
elsif goal.completed? || goal.status == :reached
I18n.t("goals.goal_card.footer_reached")
elsif goal.status == :behind && goal.monthly_target_amount
I18n.t("goals.goal_card.footer_catch_up", amount: goal.catch_up_delta_money.format(precision: 0))
elsif goal.status == :no_target_date
I18n.t("goals.goal_card.footer_no_deadline")
else
days = goal.last_matched_pledge_days_ago
if days.nil?
I18n.t("goals.goal_card.footer_no_pledges")
elsif days.zero?
I18n.t("goals.goal_card.footer_last_today")
else
I18n.t("goals.goal_card.footer_last_days", count: days)
end
end
end
def footer_has_money?
goal.status == :behind && goal.monthly_target_amount
end
end