Files
sure/test/models/account/entry_test.rb
web-dev0521 3311759ec2 fix(transactions): include enable_banking in pending/confirmed status filter (#1885)
* fix(transactions): include enable_banking in pending/confirmed status filter (#1668)

The transaction status filter hardcoded only simplefin/plaid/lunchflow in
its pending/confirmed SQL, even though Transaction::PENDING_PROVIDERS also
includes enable_banking. As a result, Enable Banking pending transactions
returned 0 results under the "Pending" filter and leaked into "Confirmed".

Source the provider list from the existing constant-driven helpers instead:
- Transaction::Search delegates to the `pending` / `excluding_pending` model
  scopes.
- EntrySearch interpolates Transaction::PENDING_CHECK_SQL into its EXISTS
  subqueries.

This keeps every status-filter path in sync with PENDING_PROVIDERS so adding
a future provider can't reintroduce the bug.

Fixes #1668

* test(entry): cover EntrySearch status filter across all pending providers

Adds a regression test for the EntrySearch#apply_status_filter path,
asserting pending transactions for every PENDING_PROVIDERS entry are
matched by the "pending" filter and excluded from "confirmed". Mirrors
the existing Transaction::Search coverage so both filter paths are
exercised.
2026-05-31 22:17:56 +02:00

112 lines
3.9 KiB
Ruby

require "test_helper"
class EntryTest < ActiveSupport::TestCase
include EntriesTestHelper
setup do
@entry = entries :transaction
end
test "entry cannot be older than 10 years ago" do
assert_raises ActiveRecord::RecordInvalid do
@entry.update! date: 50.years.ago.to_date
end
end
test "valuations cannot have more than one entry per day" do
existing_valuation = entries :valuation
new_valuation = Entry.new \
entryable: Valuation.new(kind: "reconciliation"),
account: existing_valuation.account,
date: existing_valuation.date, # invalid
currency: existing_valuation.currency,
amount: existing_valuation.amount
assert new_valuation.invalid?
end
test "triggers sync with correct start date when transaction is set to prior date" do
prior_date = @entry.date - 1
@entry.update! date: prior_date
@entry.account.expects(:sync_later).with(window_start_date: prior_date)
@entry.sync_account_later
end
test "triggers sync with correct start date when transaction is set to future date" do
prior_date = @entry.date
@entry.update! date: @entry.date + 1
@entry.account.expects(:sync_later).with(window_start_date: prior_date)
@entry.sync_account_later
end
test "triggers sync with correct start date when transaction deleted" do
@entry.destroy!
@entry.account.expects(:sync_later).with(window_start_date: nil)
@entry.sync_account_later
end
test "can search entries" do
family = families(:empty)
account = family.accounts.create! name: "Test", balance: 0, currency: "USD", accountable: Depository.new
category = family.categories.first
merchant = family.merchants.first
create_transaction(account: account, name: "a transaction")
create_transaction(account: account, name: "ignored")
create_transaction(account: account, name: "third transaction", category: category, merchant: merchant)
params = { search: "a" }
assert_equal 2, family.entries.search(params).size
params = { search: "%" }
assert_equal 0, family.entries.search(params).size
end
test "status filter matches pending transactions for every supported provider via EntrySearch" do
family = families(:empty)
account = family.accounts.create! name: "Test", balance: 0, currency: "USD", accountable: Depository.new
confirmed = create_transaction(account: account, amount: 50, kind: "standard")
pending_by_provider = Transaction::PENDING_PROVIDERS.index_with do |provider|
entry = create_transaction(account: account, amount: 50, kind: "standard")
entry.entryable.update!(extra: { provider => { "pending" => true } })
entry.id
end
pending_ids = family.entries.search(status: [ "pending" ]).pluck(:id)
confirmed_ids = family.entries.search(status: [ "confirmed" ]).pluck(:id)
pending_by_provider.each do |provider, entry_id|
assert_includes pending_ids, entry_id, "#{provider} pending entry should match the pending filter"
assert_not_includes confirmed_ids, entry_id, "#{provider} pending entry should be excluded from the confirmed filter"
end
assert_includes confirmed_ids, confirmed.id
assert_not_includes pending_ids, confirmed.id
end
test "visible scope only returns entries from visible accounts" do
# Create transactions for all account types
visible_transaction = create_transaction(account: accounts(:depository), name: "Visible transaction")
invisible_transaction = create_transaction(account: accounts(:credit_card), name: "Invisible transaction")
# Update account statuses
accounts(:credit_card).disable!
# Test the scope
visible_entries = Entry.visible
# Should include entry from active account
assert_includes visible_entries, visible_transaction
# Should not include entry from disabled account
assert_not_includes visible_entries, invisible_transaction
end
end