mirror of
https://github.com/we-promise/sure.git
synced 2026-04-10 15:54:48 +00:00
* Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
70 lines
2.1 KiB
Ruby
70 lines
2.1 KiB
Ruby
# Base class for all provider adapters
|
|
# Provides common interface for working with different third-party data providers
|
|
#
|
|
# To create a new provider adapter:
|
|
# 1. Inherit from Provider::Base
|
|
# 2. Implement #provider_name
|
|
# 3. Include optional modules (Provider::Syncable, Provider::InstitutionMetadata)
|
|
# 4. Register with Provider::Factory in the class body
|
|
#
|
|
# Example:
|
|
# class Provider::AcmeAdapter < Provider::Base
|
|
# Provider::Factory.register("AcmeAccount", self)
|
|
# include Provider::Syncable
|
|
# include Provider::InstitutionMetadata
|
|
#
|
|
# def provider_name
|
|
# "acme"
|
|
# end
|
|
# end
|
|
class Provider::Base
|
|
attr_reader :provider_account, :account
|
|
|
|
def initialize(provider_account, account: nil)
|
|
@provider_account = provider_account
|
|
@account = account || provider_account.account
|
|
end
|
|
|
|
# Provider identification - must be implemented by subclasses
|
|
# @return [String] The provider name (e.g., "plaid", "simplefin")
|
|
def provider_name
|
|
raise NotImplementedError, "#{self.class} must implement #provider_name"
|
|
end
|
|
|
|
# Returns the provider type (class name)
|
|
# @return [String] The provider account class name
|
|
def provider_type
|
|
provider_account.class.name
|
|
end
|
|
|
|
# Whether this provider allows deletion of holdings
|
|
# Override in subclass if provider supports holdings deletion
|
|
# @return [Boolean] True if holdings can be deleted, false otherwise
|
|
def can_delete_holdings?
|
|
false
|
|
end
|
|
|
|
# Provider-specific raw data payload
|
|
# @return [Hash, nil] The raw payload from the provider
|
|
def raw_payload
|
|
provider_account.raw_payload
|
|
end
|
|
|
|
# Returns metadata about this provider and account
|
|
# Automatically includes institution metadata if the adapter includes Provider::InstitutionMetadata
|
|
# @return [Hash] Metadata hash
|
|
def metadata
|
|
base_metadata = {
|
|
provider_name: provider_name,
|
|
provider_type: provider_type
|
|
}
|
|
|
|
# Include institution metadata if the module is included
|
|
if respond_to?(:institution_metadata)
|
|
base_metadata.merge!(institution: institution_metadata)
|
|
end
|
|
|
|
base_metadata
|
|
end
|
|
end
|