mirror of
https://github.com/we-promise/sure.git
synced 2026-04-16 10:34:09 +00:00
* Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
90 lines
2.9 KiB
Ruby
90 lines
2.9 KiB
Ruby
class SimplefinAccount::Processor
|
|
attr_reader :simplefin_account
|
|
|
|
def initialize(simplefin_account)
|
|
@simplefin_account = simplefin_account
|
|
end
|
|
|
|
# Each step represents different SimpleFin data processing
|
|
# Processing the account is the first step and if it fails, we halt
|
|
# Each subsequent step can fail independently, but we continue processing
|
|
def process
|
|
unless simplefin_account.current_account.present?
|
|
return
|
|
end
|
|
|
|
process_account!
|
|
process_transactions
|
|
process_investments
|
|
process_liabilities
|
|
end
|
|
|
|
private
|
|
|
|
def process_account!
|
|
# This should not happen in normal flow since accounts are created manually
|
|
# during setup, but keeping as safety check
|
|
if simplefin_account.current_account.blank?
|
|
Rails.logger.error("SimpleFin account #{simplefin_account.id} has no associated Account - this should not happen after manual setup")
|
|
return
|
|
end
|
|
|
|
# Update account balance and cash balance from latest SimpleFin data
|
|
account = simplefin_account.current_account
|
|
balance = simplefin_account.current_balance || simplefin_account.available_balance || 0
|
|
|
|
# SimpleFin returns negative balances for credit cards (liabilities)
|
|
# But Maybe expects positive balances for liabilities
|
|
if account.accountable_type == "CreditCard" || account.accountable_type == "Loan"
|
|
balance = balance.abs
|
|
end
|
|
|
|
# Calculate cash balance correctly for investment accounts
|
|
cash_balance = if account.accountable_type == "Investment"
|
|
calculator = SimplefinAccount::Investments::BalanceCalculator.new(simplefin_account)
|
|
calculator.cash_balance
|
|
else
|
|
balance
|
|
end
|
|
|
|
account.update!(
|
|
balance: balance,
|
|
cash_balance: cash_balance
|
|
)
|
|
end
|
|
|
|
def process_transactions
|
|
SimplefinAccount::Transactions::Processor.new(simplefin_account).process
|
|
rescue => e
|
|
report_exception(e, "transactions")
|
|
end
|
|
|
|
def process_investments
|
|
return unless simplefin_account.current_account&.accountable_type == "Investment"
|
|
SimplefinAccount::Investments::TransactionsProcessor.new(simplefin_account).process
|
|
SimplefinAccount::Investments::HoldingsProcessor.new(simplefin_account).process
|
|
rescue => e
|
|
report_exception(e, "investments")
|
|
end
|
|
|
|
def process_liabilities
|
|
case simplefin_account.current_account&.accountable_type
|
|
when "CreditCard"
|
|
SimplefinAccount::Liabilities::CreditProcessor.new(simplefin_account).process
|
|
when "Loan"
|
|
SimplefinAccount::Liabilities::LoanProcessor.new(simplefin_account).process
|
|
end
|
|
rescue => e
|
|
report_exception(e, "liabilities")
|
|
end
|
|
|
|
def report_exception(error, context)
|
|
Sentry.capture_exception(error) do |scope|
|
|
scope.set_tags(
|
|
simplefin_account_id: simplefin_account.id,
|
|
context: context
|
|
)
|
|
end
|
|
end
|
|
end
|