mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 20:14:08 +00:00
a92fd3b3e8
* Feat: Implement manual sync prices functionality and enhance holdings display * Feat: Enhance sync prices functionality with error handling and update UI components * Feat: Update sync prices error handling and enhance Spanish locale messages * Fix: Address CodeRabbit review feedback - Set fallback @provider_error when prices_updated == 0 so turbo stream never fails silently without a visible error message - Move attr_reader :provider_error to class header in Price::Importer for conventional placement alongside other attribute declarations - Precompute @last_price_updated in controller (show + sync_prices) instead of running a DB query directly inside ERB templates Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix: Replace bare rescue with explicit exception handling in turbo stream view Bare `rescue` silently swallows all exceptions, making debugging impossible. Match the pattern already used in show.html.erb: rescue ActiveRecord::RecordInvalid explicitly, then catch StandardError with logging (message + backtrace) before falling back to the unknown label. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix: Update test assertion to expect actual provider error message The stub returns "Yahoo Finance rate limit exceeded" as the provider error. After the @provider_error fallback fix, the controller now correctly surfaces the real provider error when present (using .presence || fallback), so the flash[:alert] is the actual error string, not the generic fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix: Assert scoped security_ids in sync_prices materializer test Replace loose stub with constructor expectation to verify that Balance::Materializer is instantiated with the single-security scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix: Assert holding remap in remap_security test Add assertion that @holding.security_id is updated to the target security after remap, covering the core command outcome. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix: CI test failure - Update disconnect external assistant test to use env overrides --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
57 lines
2.8 KiB
Plaintext
57 lines
2.8 KiB
Plaintext
<% unless @provider_error %>
|
|
<%= turbo_stream.replace dom_id(@holding, :current_market_price) do %>
|
|
<dd id="<%= dom_id(@holding, :current_market_price) %>" class="text-primary">
|
|
<% begin %>
|
|
<%= @holding.security.current_price ? format_money(@holding.security.current_price) : t("holdings.show.unknown") %>
|
|
<% rescue ActiveRecord::RecordInvalid %>
|
|
<%= t("holdings.show.unknown") %>
|
|
<% rescue StandardError => e %>
|
|
<% logger.error "Error fetching current price for security #{@holding.security.id}: #{e.message}" %>
|
|
<% logger.error e.backtrace.first(5).join("\n") %>
|
|
<%= t("holdings.show.unknown") %>
|
|
<% end %>
|
|
</dd>
|
|
<% end %>
|
|
<%= turbo_stream.replace dom_id(@holding, :market_value) do %>
|
|
<div id="<%= dom_id(@holding, :market_value) %>" class="flex items-center justify-between text-sm">
|
|
<dt class="text-secondary"><%= t("holdings.show.market_value_label") %></dt>
|
|
<dd class="text-primary"><%= format_money(@holding.amount_money) %></dd>
|
|
</div>
|
|
<% end %>
|
|
<%= turbo_stream.replace dom_id(@holding, :total_return) do %>
|
|
<div id="<%= dom_id(@holding, :total_return) %>" class="flex items-center justify-between text-sm">
|
|
<dt class="text-secondary"><%= t("holdings.show.total_return_label") %></dt>
|
|
<% if @holding.trend %>
|
|
<dd style="color: <%= @holding.trend.color %>;">
|
|
<%= render("shared/trend_change", trend: @holding.trend) %>
|
|
</dd>
|
|
<% else %>
|
|
<dd class="text-secondary"><%= t("holdings.show.unknown") %></dd>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<%= turbo_stream.replace dom_id(@holding, :market_data_section) do %>
|
|
<div id="<%= dom_id(@holding, :market_data_section) %>" class="flex items-center justify-between gap-2 p-3 border-b border-tertiary">
|
|
<div class="text-sm space-y-1">
|
|
<h4 class="text-primary"><%= t("holdings.show.market_data_label") %></h4>
|
|
<p class="text-secondary">
|
|
<%= t("holdings.show.last_price_update") %>: <%= @last_price_updated ? l(@last_price_updated, format: :long) : t("holdings.show.never") %>
|
|
</p>
|
|
<% if @provider_error %>
|
|
<p class="text-xs text-red-500"><%= @provider_error %></p>
|
|
<% end %>
|
|
</div>
|
|
<%= button_to t("holdings.show.market_data_sync_button"),
|
|
sync_prices_holding_path(@holding),
|
|
method: :post,
|
|
class: "inline-flex items-center gap-1 px-3 py-2 rounded-lg text-sm font-medium text-primary bg-gray-200 hover:bg-gray-300 theme-dark:bg-gray-700 theme-dark:hover:bg-gray-600",
|
|
data: { loading_button_target: "button" },
|
|
form: { data: {
|
|
controller: "loading-button",
|
|
action: "submit->loading-button#showLoading",
|
|
loading_button_loading_text_value: t("holdings.show.syncing")
|
|
} } %>
|
|
</div>
|
|
<% end %>
|