mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* SimpleFin: metadata + merge fixes; holdings (incl. crypto) + Day Change; Sync Summary; ops rakes; lint # Conflicts: # db/schema.rb # Conflicts: # app/controllers/simplefin_items_controller.rb * fix testing * fix linting * xfix linting x2 * Review PR #267 on we-promise/sure (SimpleFin enhancements v2). Address all 15 actionable CodeRabbit comments: Add UUID validations in rakes (e.g., simplefin_unlink), swap Ruby pattern matching/loops for efficient DB queries (e.g., where LOWER(name) LIKE ?), generate docstrings for low-coverage areas (31%), consolidate routes for simplefin_items, move view logic to helpers (e.g., format_transaction_extra), strengthen tests with exact assertions/fixtures for dedup/relink failures. Also, check for overlaps with merged #262 (merchants fix): Ensure merchant creation in simplefin_entry/processor.rb aligns with new payee-based flow and MD5 IDs; add tests for edge cases like empty payees or over-merging pendings. Prioritize security (PII redaction in logs, no hardcoded secrets). * SimpleFin: address CodeRabbit comments (batch 1) - Consolidate simplefin_items routes under a single resources block; keep URLs stable - Replace inline JS with Stimulus auto-relink controller; auto-load relink modal via global modal frame - Improve a11y in relink modal by wrapping rows in labels - Harden unlink rake: default dry_run=true, UUID validation, redact PII in outputs, clearer errors - Backfill rake: default dry_run=true, UUID validation; groundwork for per-SFA counters - Fix-was-merged rake: default dry_run=true, UUID validation; clearer outputs - Idempotent transfer auto-match (find_or_create_by! + RecordNotUnique rescue) - Extract SimpleFin error tooltip assembly into helper and use it in view RuboCop: maintain 2-space indentation, spaces inside array brackets, spaces after commas, and no redundant returns * Linter noise * removed filed commited by mistake. * manual relink flow and tighten composite matching * enforce manual relink UI; fix adapter keywords; guarantee extra.simplefin hash * refactor(simplefin): extract relink service; enforce manual relink UI; tighten composite match; migration 7.2 * add provider date parser; refactor rake; move view queries; partial resilience * run balances-only import in background job. make update flow enqueue balances-only job * persists across all update redirects and initialize used_manual_ids to prevent NameError in relink candidate computation. * SimpleFin: metadata + merge fixes; holdings (incl. crypto) + Day Change; Sync Summary; ops rakes; lint * Fixed failed test after rebase. * scan_ruby fix * Calming the rabbit: Fix AccountProvider linking when accounts change Drop the legacy unique index instead of duplicating it Fix dynamic constant assignment Use fixtures consistently; avoid rescue for control flow. Replace bare rescue with explicit exception class. Move business logic out of the view. Critical: Transaction boundary excludes recompute phase, risking data loss. Inconsistency between documentation and implementation for zero-error case. Refactor to use the compute_unlinked_count helper for consistency. Fix cleanup task default: it deletes by default. Move sync stats computation to controller to avoid N+1 queries. Consolidate duplicate sync query. Clarify the intent of setting flash notice on the error path. Fix Date/Time comparison in should_be_inactive?. Move stats retrieval logic to controller. Remove duplicate Sync summary section. Remove the unnecessary sleep statement; use Capybara's built-in waiting. Add label wrappers for accessibility and consistency. * FIX SimpleFIN new account modal Now new account properly loads as a Modal, instead of new page. Fixes also form showing dashboard instead of settings page. * Remove SimpleFin legacy UI components, migrate schema, and refine linking behavior. # Conflicts: # app/helpers/settings_helper.rb * Extract SimpleFin-related logic to `prepare_show_context` helper and refactor for consistency. Adjust conditional checks and ensure controller variables are properly initialized. * Remove unused SimpleFin maps from prepare_show_context; select IDs to avoid N+1 Replace Tailwind bg-green-500 with semantic bg-success in _simplefin_panel/_provider_form Add f.label :setup_token in simplefin_items/new for a11y Remove duplicate require in AccountsControllerSimplefinCtaTest * Remove unnecessary blank lines * Reduce unnecessary changes This reduces the diff against main * Simplefin Account Setup: Display in modal This fixes an issue with the `X` dismiss button in the top right corner * Removed unnecessary comment. * removed unnecessary function. * fixed broken links * Removed unnecessary file * changed to database query * set to use UTC and gaurd against null * set dry_run=true * Fixed comment * Changed to use a database-level query * matched test name to test behavior. * Eliminate code duplication and Time.zone dependency * make final summary surface failures * lint fix * Revised timezone comment. better handle missing selectors. * sanitized LIKE wildcards * Fixed SimpleFin import to avoid “Currency can’t be blank” validation failures when providers return an empty currency string. * Added helper methods for admin and self-hosted checks * Specify exception types in rescue clauses. * Refined logic to determine transaction dates for credit accounts. * Refined stats calculation for `total_accounts` to track the maximum unique accounts per run instead of accumulating totals. * Moved `unlink_all!` logic to `SimplefinItem::Unlinking` concern and deprecated `SimplefinItem::Unlinker`. Updated related references. * Refined legacy unlinking logic, improved `current_holdings` formatting, and added ENV-based overrides for self-hosted checks. * Enhanced `unlink_all!` with explicit error handling, improved transaction safety, and refined ENV-based self-hosted checks. Adjusted exception types and cleaned up private method handling. * Improved currency assignment logic by adding fallback to `current_account` and `family` currencies. * Enhanced error tracking during SimpleFin account imports by adding categorized error buckets, limiting stored errors to the last 5, and improving `stats` calculations. * typo fix * Didn't realize rabbit was still mad... Refactored SimpleFin error handling and CTA logic: centralized duplicate detection and relink visibility into controller, improved task counters, adjusted redirect notices, and fixed form indexing. * Dang rabbit never stops... Centralized SimpleFin maps logic into `MapsHelper` concern and integrated it into relevant controllers and rake tasks. Optimized queries, reduced redundancy, and improved unlinked counts and manual account checks with batch processing. Adjusted task arguments for clarity. * Persistent rabbit. Optimized SimpleFin maps logic by implementing batch queries for manual account and unlinked count checks, reducing N+1 issues. Improved clarity of rake task argument descriptions and error messages for better usability. * Lost a commit somehow, resolved here. Refactored transaction extra details logic by introducing `build_transaction_extra_details` helper to improve clarity, reusability, and reduce view complexity. Enhanced rake tasks with strict dry-run validation and better error handling. Updated schema to allow nullable `merchant_id` and added conditional unique indexes for recurring transactions. * Refactored sensitive data redaction in `simplefin_unlink` task for recursive handling, optimized SQL sanitization in `simplefin_holdings_backfill`, improved error handling in `transactions_helper`, and streamlined day change calculation logic in `Holding` model. * Lint fix * Removed per PR comments. * Also removing per PR comment. * git commit -m "SimpleFIN polish: preserve #manual-accounts wrapper, unify \"manual\" scope, and correct unlinked counts - Preserve #manual-accounts wrapper: switch non-empty updates to turbo_stream.update and background broadcast_update_to; keep empty-path replace to render <div id=\"manual-accounts\"></div> - Unify definition of manual accounts via Account.visible_manual (visible + legacy-nil + no AccountProvider); reuse in controllers, jobs, and helper - Correct setup/unlinked counts: SimplefinItem::Syncer#finalize_setup_counts and maps now consider AccountProvider links (legacy account AND provider must be absent) Deleted: - app/models/simplefin_item/relink_service.rb - app/controllers/concerns/simplefin_items/relink_helpers.rb - app/javascript/controllers/auto_relink_controller.js - app/views/simplefin_items/_relink_modal.html.erb - app/views/simplefin_items/manual_relink.html.erb - app/views/simplefin_items/relink.html.erb - test/services/simplefin_item/relink_service_test.rb Refs: PR #318 unified link/unlink; PR #267 SimpleFIN; follow-up to fix wrapper ID loss and counting drift." * Extend unlinked account check to include "Investment" type * set SimpleFIN item for `balances`, remove redundant unpacking, and improve holdings task error * SimpleFIN: add `errors` action + modal; do not reintroduce legacy relink actions; removed dead helper * FIX simpleFIN linking * Add delay back, tests benefit from it * Put cache back in * Remove empty `rake` task * Small spelling fixes. --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: sokie <sokysrm@gmail.com> Co-authored-by: Dylan Corrales <deathcamel58@gmail.com>
257 lines
10 KiB
Ruby
257 lines
10 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# Backfill and maintenance tasks for SimpleFin transactions metadata and demo cleanup
|
|
#
|
|
# Usage examples:
|
|
# # Preview (no writes) a 45-day backfill for a single item
|
|
# # NOTE: Use your real item id
|
|
# bin/rails 'sure:simplefin:backfill_extra[item_id=ec255931-62ff-4a68-abda-16067fad0429,days=45,dry_run=true]'
|
|
#
|
|
# # Execute the backfill (writes enabled)
|
|
# bin/rails 'sure:simplefin:backfill_extra[item_id=ec255931-62ff-4a68-abda-16067fad0429,days=45,dry_run=false]'
|
|
#
|
|
# # Limit to a single linked account by Account ID (UUID from your UI/db)
|
|
# bin/rails 'sure:simplefin:backfill_extra[account_id=8b46387c-5aa4-4a92-963a-4392c10999c9,days=30,dry_run=false]'
|
|
#
|
|
# # Clean up known demo entries for a specific account (dry-run first)
|
|
# bin/rails 'sure:simplefin:cleanup_demo_entries[account_id=8b46387c-5aa4-4a92-963a-4392c10999c9,dry_run=true]'
|
|
# bin/rails 'sure:simplefin:cleanup_demo_entries[account_id=8b46387c-5aa4-4a92-963a-4392c10999c9,dry_run=false]'
|
|
|
|
namespace :sure do
|
|
namespace :simplefin do
|
|
desc "Backfill transactions.extra for SimpleFin imports over a recent window. Args (named): item_id, account_id, days=30, dry_run=true, force=false"
|
|
task :backfill_extra, [ :item_id, :account_id, :days, :dry_run, :force ] => :environment do |_, args|
|
|
# Support both positional and named (key=value) args; prefer named
|
|
kv = {}
|
|
[ args[:item_id], args[:account_id], args[:days], args[:dry_run], args[:force] ].each do |raw|
|
|
next unless raw.is_a?(String) && raw.include?("=")
|
|
k, v = raw.split("=", 2)
|
|
kv[k.to_s] = v
|
|
end
|
|
|
|
item_id = (kv["item_id"] || args[:item_id]).presence
|
|
account_id = (kv["account_id"] || args[:account_id]).presence
|
|
days_i = (kv["days"] || args[:days] || 30).to_i
|
|
dry_raw = (kv["dry_run"] || args[:dry_run]).to_s.downcase
|
|
force_raw = (kv["force"] || args[:force]).to_s.downcase
|
|
|
|
# Default to dry_run=true unless explicitly disabled, and validate input strictly
|
|
if dry_raw.blank?
|
|
dry_run = true
|
|
elsif %w[1 true yes y].include?(dry_raw)
|
|
dry_run = true
|
|
elsif %w[0 false no n].include?(dry_raw)
|
|
dry_run = false
|
|
else
|
|
puts({ ok: false, error: "invalid_argument", message: "dry_run must be one of: true/yes/1 or false/no/0" }.to_json)
|
|
exit 1
|
|
end
|
|
force = %w[1 true yes y].include?(force_raw)
|
|
days_i = 30 if days_i <= 0
|
|
|
|
window_start = days_i.days.ago.to_date
|
|
window_end = Date.today
|
|
|
|
# Basic UUID validation when provided
|
|
uuid_rx = /\A[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\z/i
|
|
if item_id.present? && !item_id.match?(uuid_rx)
|
|
puts({ ok: false, error: "invalid_argument", message: "item_id must be a hyphenated UUID" }.to_json)
|
|
exit 1
|
|
end
|
|
if account_id.present? && !account_id.match?(uuid_rx)
|
|
puts({ ok: false, error: "invalid_argument", message: "account_id must be a hyphenated UUID" }.to_json)
|
|
exit 1
|
|
end
|
|
|
|
# Select SimplefinAccounts to process
|
|
sfas = if item_id.present?
|
|
item = SimplefinItem.find(item_id)
|
|
item.simplefin_accounts
|
|
elsif account_id.present?
|
|
acct = Account.find(account_id)
|
|
# Prefer new provider linkage, fallback to legacy foreign key
|
|
sfa = if acct.account_providers.where(provider_type: "SimplefinAccount").exists?
|
|
AccountProvider.find_by(account: acct, provider_type: "SimplefinAccount")&.provider
|
|
else
|
|
SimplefinAccount.find_by(account: acct)
|
|
end
|
|
Array.wrap(sfa)
|
|
else
|
|
puts({ ok: false, error: "usage", message: "Provide item_id or account_id" }.to_json)
|
|
exit 1
|
|
end
|
|
|
|
# Ensure sfas is an ActiveRecord::Relation so downstream can call find_each safely
|
|
unless sfas.respond_to?(:find_each)
|
|
sfa_ids = Array.wrap(sfas).compact.map { |x| x.is_a?(SimplefinAccount) ? x.id : x }
|
|
sfas = SimplefinAccount.where(id: sfa_ids)
|
|
end
|
|
|
|
total_seen = 0
|
|
total_matched = 0
|
|
total_updated = 0
|
|
total_skipped = 0
|
|
total_errors = 0
|
|
|
|
sfas.find_each do |sfa|
|
|
# Per-SFA counters (reset each iteration)
|
|
s_seen = s_matched = s_updated = s_skipped = s_errors = 0
|
|
|
|
acct = sfa.current_account
|
|
unless acct
|
|
puts({ warn: "no_linked_account", sfa_id: sfa.id, name: sfa.name }.to_json)
|
|
next
|
|
end
|
|
|
|
txs = Array(sfa.raw_transactions_payload).map { |t| t.with_indifferent_access }
|
|
if txs.empty?
|
|
puts({ info: "no_raw_transactions", sfa_id: sfa.id, name: sfa.name }.to_json)
|
|
next
|
|
end
|
|
|
|
txs.each do |t|
|
|
begin
|
|
posted = t[:posted]
|
|
trans = t[:transacted_at]
|
|
|
|
# convert to Date where possible for window filtering
|
|
posted_d = case posted
|
|
when String then Date.parse(posted) rescue nil
|
|
when Numeric then Time.zone.at(posted).to_date rescue nil
|
|
when Date then posted
|
|
when Time, DateTime then posted.to_date
|
|
else nil
|
|
end
|
|
trans_d = case trans
|
|
when String then Date.parse(trans) rescue nil
|
|
when Numeric then Time.zone.at(trans).to_date rescue nil
|
|
when Date then trans
|
|
when Time, DateTime then trans.to_date
|
|
else nil
|
|
end
|
|
|
|
best = posted_d || trans_d
|
|
# If neither date is available, skip (cannot window-match safely)
|
|
if best.nil? || best < window_start || best > window_end
|
|
s_skipped += 1
|
|
total_skipped += 1
|
|
next
|
|
end
|
|
|
|
s_seen += 1
|
|
total_seen += 1
|
|
|
|
# Build extra payload exactly like SimplefinEntry::Processor
|
|
sf = {}
|
|
sf["payee"] = t[:payee] if t.key?(:payee)
|
|
sf["memo"] = t[:memo] if t.key?(:memo)
|
|
sf["description"] = t[:description] if t.key?(:description)
|
|
sf["extra"] = t[:extra] if t[:extra].is_a?(Hash)
|
|
extra_hash = sf.empty? ? nil : { "simplefin" => sf }
|
|
|
|
# Skip if no metadata to add (unless forcing overwrite)
|
|
if extra_hash.nil? && !force
|
|
s_skipped += 1
|
|
total_skipped += 1
|
|
next
|
|
end
|
|
|
|
# Reuse the import adapter path so we merge onto the existing entry
|
|
adapter = Account::ProviderImportAdapter.new(acct)
|
|
external_id = t[:id].present? ? "simplefin_#{t[:id]}" : nil
|
|
|
|
if external_id.nil?
|
|
s_skipped += 1
|
|
total_skipped += 1
|
|
puts({ warn: "missing_transaction_id", sfa_id: sfa.id, account_id: acct.id, name: sfa.name }.to_json)
|
|
next
|
|
end
|
|
|
|
if dry_run
|
|
# Simulate: check if we can composite-match; we won't persist
|
|
entry = external_id && acct.entries.find_by(external_id: external_id, source: "simplefin")
|
|
processor = SimplefinEntry::Processor.new(t, simplefin_account: sfa)
|
|
window_days = (acct.accountable_type.in?([ "CreditCard", "Loan" ]) ? 5 : 3)
|
|
entry ||= adapter.composite_match(
|
|
source: "simplefin",
|
|
name: processor.send(:name),
|
|
amount: processor.send(:amount),
|
|
date: (posted_d || trans_d),
|
|
window_days: window_days
|
|
)
|
|
matched = entry.present?
|
|
if matched
|
|
s_matched += 1
|
|
total_matched += 1
|
|
end
|
|
else
|
|
processed = SimplefinEntry::Processor.new(t, simplefin_account: sfa).process
|
|
if processed&.transaction&.extra.present?
|
|
s_updated += 1
|
|
total_updated += 1
|
|
else
|
|
s_skipped += 1
|
|
total_skipped += 1
|
|
end
|
|
end
|
|
rescue => e
|
|
s_errors += 1
|
|
total_errors += 1
|
|
puts({ error: e.class.name, message: e.message }.to_json)
|
|
end
|
|
end
|
|
|
|
puts({ sfa_id: sfa.id, account_id: acct.id, name: sfa.name, seen: s_seen, matched: s_matched, updated: s_updated, skipped: s_skipped, errors: s_errors, window_start: window_start, window_end: window_end, dry_run: dry_run, force: force }.to_json)
|
|
end
|
|
|
|
puts({ ok: true, total_seen: total_seen, total_matched: total_matched, total_updated: total_updated, total_skipped: total_skipped, total_errors: total_errors, window_start: window_start, window_end: window_end, dry_run: dry_run, force: force }.to_json)
|
|
end
|
|
|
|
desc "List and optionally delete known demo SimpleFin entries for a given Account. Args (named): account_id, dry_run=true, pattern"
|
|
task :cleanup_demo_entries, [ :account_id, :dry_run, :pattern ] => :environment do |_, args|
|
|
kv = {}
|
|
[ args[:account_id], args[:dry_run], args[:pattern] ].each do |raw|
|
|
next unless raw.is_a?(String) && raw.include?("=")
|
|
k, v = raw.split("=", 2)
|
|
kv[k.to_s] = v
|
|
end
|
|
|
|
account_id = (kv["account_id"] || args[:account_id]).presence
|
|
dry_raw = (kv["dry_run"] || args[:dry_run]).to_s.downcase
|
|
pattern = (kv["pattern"] || args[:pattern]).presence || "simplefin_posted_demo_%|simplefin_posted_ui"
|
|
|
|
dry_run = dry_raw.blank? ? true : %w[1 true yes y].include?(dry_raw)
|
|
|
|
unless account_id.present?
|
|
puts({ ok: false, error: "usage", message: "Provide account_id" }.to_json)
|
|
exit 1
|
|
end
|
|
|
|
acct = Account.find(account_id)
|
|
|
|
patterns = pattern.split("|")
|
|
scope = acct.entries.where(source: "simplefin", entryable_type: "Transaction")
|
|
# Apply LIKE filters combined with OR
|
|
like_sql = patterns.map { |p| "external_id LIKE ?" }.join(" OR ")
|
|
like_vals = patterns.map { |p| p }
|
|
candidates = scope.where(like_sql, *like_vals)
|
|
|
|
out = candidates.order(date: :desc).map { |e| { id: e.id, external_id: e.external_id, date: e.date, name: e.name, amount: e.amount } }
|
|
puts({ account_id: acct.id, count: candidates.count, entries: out }.to_json)
|
|
|
|
if candidates.any? && !dry_run
|
|
deleted = 0
|
|
ActiveRecord::Base.transaction do
|
|
candidates.each do |e|
|
|
e.destroy!
|
|
deleted += 1
|
|
end
|
|
end
|
|
puts({ ok: true, deleted: deleted }.to_json)
|
|
else
|
|
puts({ ok: true, deleted: 0, dry_run: dry_run }.to_json)
|
|
end
|
|
end
|
|
end
|
|
end
|