Files
sure/test/models/assistant/function/get_bill_details_test.rb
T
Brandon ce92b36351 feat(bills): assistant and MCP tools for bills (#3203)
* feat(bills): assistant and MCP tools for bills

Last of three chunks carved out of #3083, stacked on the UI bundle. Exposes
bills to the builtin assistant and to MCP clients. Everything here is gated
behind preview features, so the tools are absent from tools/list until a user
opts in.

Seven tools:

- get_bills, get_bill_details and get_paycheck_plan for reads
- get_bill_audit, a deterministic review that surfaces likely duplicates, price
  changes, trials about to convert, upcoming renewals and long-overdue bills
- create_bill, update_bill and record_bill_payment for writes

Shared argument parsing, permission checks and error shapes live in
BillsSupport, so every tool answers with the same {error, hint} contract the
existing tools use, and a bad argument never aborts the turn.

The write tools mutate financial records on a model's say-so, so they refuse
rather than guess: a payment cannot exceed what its cycle still owes, a repeated
settle will not quietly close next month, an unrecognized frequency is an error
instead of a silent monthly default, and non-finite or negative amounts are
rejected before they reach the database.

The read tools say what they filtered. An empty result names the statuses that
do hold matches, the paycheck plan discloses the unconfirmed series it excluded
from spending headroom, and history and price-change windows report their real
totals rather than letting a caller sum a truncated list.

A not-found no longer returns the scoped relation's SQL, which handed any MCP
client the access-control schema for the cost of a guessed id.

The in-page AI helpers are not here. Smart fill and smart configuration are
buttons on the bills pages, so they ship with the UI bundle along with the
provider-side suggester they call.

Suite 7,854 runs, 0 failures. Rubocop clean, eager loading verified.

* Address the ready-review round

* Reject an out-of-range audit lookback out loud

* Speak the cycle remainder guard through the allocator locale
2026-09-02 07:06:13 +02:00

147 lines
5.4 KiB
Ruby

require "test_helper"
class Assistant::Function::GetBillDetailsTest < ActiveSupport::TestCase
setup do
@user = users(:family_admin)
@family = @user.family
@family.recurring_transactions.destroy_all
end
test "analytics come from confirmed payments on settled occurrences, never estimates" do
series = create_series(name: "CITY WATER", amount: 200)
paid = series.recurring_occurrences.order(:due_on).first
paid.allocations.create!(allocated_amount: 100, currency: "USD", source: "user_created")
paid.close!("paid", source: "user")
# An open occurrence still expecting the estimated 200 must not move the average.
result = call_tool(series.id)
assert_equal "$100.00", result[:analytics][:average_paid],
"the open occurrence's 200 estimate must not be averaged in"
assert_equal "$100.00", result[:analytics][:paid_this_year]
end
test "analytics are null before anything was paid" do
series = create_series(name: "Fresh bill", amount: 50)
result = call_tool(series.id)
assert_nil result[:analytics]
end
test "history rows carry their payments with the transaction name" do
series = create_series(name: "CITY WATER", amount: 80)
entry = accounts(:depository).entries.create!(
date: Date.current, amount: 80, currency: "USD", name: "CITY WATER PMT",
entryable: Transaction.new
)
occurrence = series.recurring_occurrences.order(:due_on).first
occurrence.allocations.create!(entry: entry, allocated_amount: 80, currency: "USD", source: "user_confirmed")
occurrence.close!("paid", source: "user")
result = call_tool(series.id)
payment = result[:history].sole[:payments].sole
assert_equal "CITY WATER PMT", payment[:transaction_name]
assert_equal "user_confirmed", payment[:source]
end
test "price changes serialize with the percent" do
series = create_series(name: "Stream Co", amount: 12)
series.recurring_price_changes.create!(
effective_on: Date.current - 10, previous_amount: 10, new_amount: 12,
currency: "USD", source: "detected"
)
result = call_tool(series.id)
change = result[:price_changes].sole
assert_equal "$10.00", change[:previous_amount]
assert_equal "$12.00", change[:new_amount]
assert_in_delta 20.0, change[:percent_change]
end
test "an invalid uuid returns an error with a hint" do
result = call_tool("not-a-uuid")
assert result[:error].present?
assert_includes result[:hint], "get_bills"
end
test "another family's bill raises RecordNotFound for the caller to convert" do
other = families(:empty).recurring_transactions.create!(
name: "Foreign bill", amount: 10, currency: "USD",
expected_day_of_month: 1, last_occurrence_date: Date.current,
next_expected_date: 1.month.from_now.to_date, status: "active"
)
assert_raises(ActiveRecord::RecordNotFound) { call_tool(other.id) }
end
# annualized_cost was the declared amount times cadence, sitting inside a
# block documented as payments-only, so a bill declared at 100 whose every
# payment was 50 reported a 50 average and a 1,200 year in the same hash.
test "the run rate follows the payments, and the declared figure says so" do
series = paid_series(declared: 100, paid: 50, cycles: 3)
analytics = call_tool(series.id)[:analytics]
assert_equal "$50.00", analytics[:average_paid]
assert_equal "$600.00", analytics[:annualized_cost], "twelve payments of what is actually paid"
assert_equal "$1,200.00", analytics[:annualized_declared], "the declared figure keeps its own name"
end
test "history discloses how much of it was withheld" do
series = paid_series(declared: 10, paid: 10, cycles: 15)
result = call_tool(series.id)
assert_equal 12, result[:history].size
assert_equal 15, result[:history_window][:count]
assert result[:history_window][:truncated], "summing 12 rows is not the lifetime total"
end
private
def call_tool(bill_id)
Assistant::Function::GetBillDetails.new(@user).call({ "bill_id" => bill_id.to_s })
end
# A series whose declared amount and actual payments deliberately disagree,
# with `cycles` settled cycles behind it.
def paid_series(declared:, paid:, cycles:)
series = create_series(name: "Gym #{declared}-#{paid}-#{cycles}", amount: declared)
series.recurring_occurrences.destroy_all
cycles.times do |index|
due = Date.current - ((index + 1) * 30)
occurrence = series.recurring_occurrences.create!(
family: @family, original_due_on: due, due_on: due,
# The series declares one figure; each cycle actually costs another,
# which is the whole point of separating run rate from declared.
currency: "USD", expected_amount: paid, status: "scheduled"
)
RecurringTransaction::Allocator.new(occurrence).allocate!(
amount: paid, paid_on: due, source: "user_created"
)
end
series.reload
end
def create_series(name:, amount:, **overrides)
@family.recurring_transactions.create!({
name: name,
account: accounts(:depository),
amount: amount,
dedup_scope: "#{name}-#{amount}",
currency: "USD",
expected_day_of_month: Date.current.day,
last_occurrence_date: 1.month.ago.to_date,
next_expected_date: Date.current,
status: "active"
}.merge(overrides))
end
end