mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Feat: Add QIF (Quicken Interchange Format) import functionality - Add the ability to import QIF files for users coming from Quicken - Includes categories and tags - Comprehensive tests for QifImport, including parsing, row generation, and import functionality. - Ensure handling of hierarchical categories (ex "Home:Home Improvement" is imported as Parent:Child) * Fix QIF import issues raised in code review - Fix two-digit year windowing in QIF date parser (e.g. '99 → 1999, not 2099) - Fix ArgumentError from invalid `undef: :raise` encoding option - Nil-safe `leaf_category_name` with blank guard and `.to_s` coercion - Memoize `qif_account_type` to avoid re-parsing the full QIF file - Add strong parameters (`selection_params`) to QifCategorySelectionsController - Wrap all mutations in DB transactions in uploads and category-selections controllers - Skip unchanged tag rows (only write rows where tags actually differ) - Replace hardcoded strings with i18n keys across QIF views and nav - Fix potentially colliding checkbox/label IDs in category selection view - Improve keyboard accessibility: use semantic `<label>` for file picker area Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix QIF import test count and Brakeman mass assignment warning - Update ImportsControllerTest to expect 4 disabled import options (was 3), accounting for the new QIF import type added in this branch - Remove :account_id from upload_params permit list; it was never accessed through strong params (always via params.dig with Current.family scope), so this resolves the Brakeman high-confidence mass assignment warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix: QIF import security, safety, and i18n issues raised in code review - Added french, spanish and german translations for newly added i18n keys - Replace params.dig(:import, :account_id) with a proper strong-params accessor (import_account_id) in UploadsController to satisfy Rails parameter filtering requirements - Guard ImportsController#show against QIF imports reaching the publish screen before a file has been uploaded, preventing an unrescued error on publish - Gate the QIF "Clean" nav step link on import.uploaded? to prevent routing to CleansController with an unconfigured import (which would raise "Unknown import type: QifImport" via ImportsHelper) - Replace hard-coded "txn" pluralize calls in the category/tag selection view with t(".txn_count") and add pluralization keys to the locale file - Localize all hard-coded strings in the QIF upload section of uploads/show.html.erb and add corresponding en.yml keys - Convert the CSV upload drop zone from a clickable <div> (JS-only) to a semantic <label> element, making it keyboard-accessible without JavaScript * Fix: missing translations keys * Add icon mapping and random color assignment to new categories * fix a lint issue * Add a warning about splits and some plumbing for future support. Updated locales. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
82 lines
2.3 KiB
Ruby
82 lines
2.3 KiB
Ruby
class Import::UploadsController < ApplicationController
|
|
layout "imports"
|
|
|
|
before_action :set_import
|
|
|
|
def show
|
|
end
|
|
|
|
def sample_csv
|
|
send_data @import.csv_template.to_csv,
|
|
filename: "#{@import.type.underscore.split('_').first}_sample.csv",
|
|
type: "text/csv",
|
|
disposition: "attachment"
|
|
end
|
|
|
|
def update
|
|
if @import.is_a?(QifImport)
|
|
handle_qif_upload
|
|
elsif csv_valid?(csv_str)
|
|
@import.account = Current.family.accounts.find_by(id: import_account_id)
|
|
@import.assign_attributes(raw_file_str: csv_str, col_sep: upload_params[:col_sep])
|
|
@import.save!(validate: false)
|
|
|
|
redirect_to import_configuration_path(@import, template_hint: true), notice: "CSV uploaded successfully."
|
|
else
|
|
flash.now[:alert] = "Must be valid CSV with headers and at least one row of data"
|
|
|
|
render :show, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
private
|
|
def set_import
|
|
@import = Current.family.imports.find(params[:import_id])
|
|
end
|
|
|
|
def handle_qif_upload
|
|
unless QifParser.valid?(csv_str)
|
|
flash.now[:alert] = "Must be a valid QIF file"
|
|
render :show, status: :unprocessable_entity and return
|
|
end
|
|
|
|
unless import_account_id.present?
|
|
flash.now[:alert] = "Please select an account for the QIF import"
|
|
render :show, status: :unprocessable_entity and return
|
|
end
|
|
|
|
ActiveRecord::Base.transaction do
|
|
@import.account = Current.family.accounts.find(import_account_id)
|
|
@import.raw_file_str = QifParser.normalize_encoding(csv_str)
|
|
@import.save!(validate: false)
|
|
@import.generate_rows_from_csv
|
|
@import.sync_mappings
|
|
end
|
|
|
|
redirect_to import_qif_category_selection_path(@import), notice: "QIF file uploaded successfully."
|
|
end
|
|
|
|
def csv_str
|
|
@csv_str ||= upload_params[:import_file]&.read || upload_params[:raw_file_str]
|
|
end
|
|
|
|
def csv_valid?(str)
|
|
begin
|
|
csv = Import.parse_csv_str(str, col_sep: upload_params[:col_sep])
|
|
return false if csv.headers.empty?
|
|
return false if csv.count == 0
|
|
true
|
|
rescue CSV::MalformedCSVError
|
|
false
|
|
end
|
|
end
|
|
|
|
def upload_params
|
|
params.require(:import).permit(:raw_file_str, :import_file, :col_sep)
|
|
end
|
|
|
|
def import_account_id
|
|
params.require(:import).permit(:account_id)[:account_id]
|
|
end
|
|
end
|