mirror of
https://github.com/we-promise/sure.git
synced 2026-06-06 11:19:02 +00:00
174f7e6be6
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
46 lines
1.4 KiB
Ruby
46 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# Pulls USDⓈ-M futures account data (balance and positions).
|
|
# Returns normalized asset list with source tag "futures".
|
|
class BinanceItem::FuturesImporter
|
|
attr_reader :binance_item, :provider
|
|
|
|
def initialize(binance_item, provider:)
|
|
@binance_item = binance_item
|
|
@provider = provider
|
|
end
|
|
|
|
# @return [Hash] { assets: [...], raw: <api_response>, source: "futures" }
|
|
def import
|
|
raw = provider.get_futures_account
|
|
|
|
# Binance Futures returns a slightly different format than spot
|
|
# assets are in raw["assets"], positions in raw["positions"]
|
|
|
|
assets = []
|
|
|
|
# Process base assets (e.g. USDT, BUSD balances)
|
|
Array(raw["assets"]).each do |asset|
|
|
wallet_balance = asset["walletBalance"].to_d
|
|
unrealized_profit = asset["unrealizedProfit"].to_d
|
|
|
|
# Total equity is wallet balance + unrealized PNL
|
|
total = wallet_balance + unrealized_profit
|
|
|
|
next if total.zero?
|
|
|
|
assets << {
|
|
symbol: asset["asset"],
|
|
free: asset["availableBalance"] || wallet_balance.to_s,
|
|
locked: (wallet_balance - (asset["availableBalance"] || wallet_balance.to_s).to_d).to_s,
|
|
total: total.to_s
|
|
}
|
|
end
|
|
|
|
{ assets: assets, raw: raw, source: "futures" }
|
|
rescue => e
|
|
Rails.logger.error "BinanceItem::FuturesImporter #{binance_item.id} - #{e.message}"
|
|
{ assets: [], raw: nil, source: "futures", error: e.message }
|
|
end
|
|
end
|