Files
sure/app/views/settings/providers/_binance_panel.html.erb
Brian Richard d266dc5f00 feat(binance): add full account sync and transaction processing (#1822)
* feat(binance): add full account sync and transaction processing

- Fixed a bug that hindered Account setup
- Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard.
- Support setting a sync_start_date during Binance account setup.
- Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history.
- Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets.
- Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration.
- Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops.

These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard.

* refactor(binance): enforce strong params, double-entry safety, and native fiat currency support

- Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines.
- Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates.
- Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records.
- Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs.
- Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload.
- Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic.

* fix(binance): process sync trades before caching transaction payload

- Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run.
- Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation.
- Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`.
- Clean up the `setup_accounts` view template by removing hardcoded default translation strings.

* fix(binance): enhance trade sync logic and error propagation

- Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching.
- Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets.
- Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs.
- Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
2026-05-27 23:58:29 +02:00

111 lines
4.8 KiB
Plaintext

<div class="space-y-4">
<% items = local_assigns[:binance_items] || @binance_items || Current.family.binance_items.active.ordered %>
<%= render DS::Alert.new(
variant: :warning,
title: t("settings.providers.binance_panel.no_withdraw_title"),
message: t("settings.providers.binance_panel.no_withdraw_body")
) %>
<div class="space-y-2">
<%= render "settings/providers/setup_steps",
steps: [
t("settings.providers.binance_panel.step1_html").html_safe,
t("settings.providers.binance_panel.step2"),
t("settings.providers.binance_panel.step3")
] %>
<div class="bg-surface-inset rounded-xl p-4 text-sm">
<p class="text-xs font-medium uppercase text-subdued tracking-wider mb-2">
<%= t("settings.providers.binance_panel.ip_hint_title") %>
</p>
<p class="text-secondary"><%= t("settings.providers.binance_panel.ip_hint_body") %></p>
<% server_ip = ENV["BINANCE_EGRESS_IP"].presence %>
<% if server_ip %>
<code class="mt-2 block text-xs bg-container px-2 py-1 rounded font-mono text-primary"><%= server_ip %></code>
<% else %>
<p class="mt-1 text-xs text-secondary italic"><%= t("settings.providers.binance_panel.ip_hint_contact_admin") %></p>
<% end %>
</div>
</div>
<% error_msg = local_assigns[:error_message] || @error_message %>
<% if error_msg.present? %>
<%= render DS::Alert.new(message: error_msg, variant: :error) %>
<% end %>
<% if items.any? %>
<div class="space-y-3">
<% items.each do |item| %>
<div class="flex items-center justify-between p-3 bg-container-inset rounded-lg border border-primary">
<div class="flex items-center gap-3">
<div class="w-10 h-10 rounded-full flex items-center justify-center" style="background-color: rgba(240, 185, 11, 0.15);">
<%= icon "coins", size: "md", class: "text-[#F0B90B]" %>
</div>
<div>
<p class="font-medium text-primary"><%= item.name %></p>
<p class="text-xs text-secondary">
<% if item.syncing? %>
<%= t("settings.providers.binance_panel.syncing") %>
<% else %>
<%= item.sync_status_summary %>
<% end %>
</p>
</div>
</div>
<div class="flex items-center gap-2">
<% if item.unlinked_accounts_count > 0 %>
<%= render DS::Link.new(
text: t("binance_items.binance_item.setup_action"),
icon: "plus",
variant: "primary",
href: setup_accounts_binance_item_path(item),
frame: :modal
) %>
<% end %>
<%= button_to sync_binance_item_path(item),
method: :post,
class: "inline-flex items-center gap-1 px-3 py-1.5 text-sm font-medium text-secondary hover:text-primary border border-secondary rounded-lg hover:border-primary",
disabled: item.syncing? do %>
<%= icon "refresh-cw", size: "sm" %>
<%= t("settings.providers.binance_panel.sync") %>
<% end %>
<%= button_to binance_item_path(item),
method: :delete,
class: "inline-flex items-center gap-1 px-3 py-1.5 text-sm font-medium text-destructive hover:bg-destructive/10 rounded-lg",
data: { turbo_confirm: t("settings.providers.binance_panel.disconnect_confirm") } do %>
<%= icon "trash-2", size: "sm" %>
<% end %>
</div>
</div>
<% end %>
</div>
<% else %>
<%
binance_item = Current.family.binance_items.build(name: "Binance")
%>
<%= styled_form_with model: binance_item,
url: binance_items_path,
scope: :binance_item,
method: :post,
data: { turbo: true },
class: "space-y-3" do |form| %>
<%= form.text_field :api_key,
label: t("settings.providers.binance_panel.api_key_label"),
placeholder: t("settings.providers.binance_panel.api_key_placeholder"),
type: :password %>
<%= form.text_field :api_secret,
label: t("settings.providers.binance_panel.api_secret_label"),
placeholder: t("settings.providers.binance_panel.api_secret_placeholder"),
type: :password %>
<div class="flex justify-end">
<%= form.submit t("settings.providers.binance_panel.connect_button") %>
</div>
<% end %>
<% end %>
</div>