mirror of
https://github.com/we-promise/sure.git
synced 2026-05-30 15:59:02 +00:00
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
226 lines
6.3 KiB
Ruby
226 lines
6.3 KiB
Ruby
require "test_helper"
|
|
|
|
class BinanceItemsControllerTest < ActionDispatch::IntegrationTest
|
|
include ActiveJob::TestHelper
|
|
|
|
setup do
|
|
sign_in users(:family_admin)
|
|
@family = families(:dylan_family)
|
|
@binance_item = BinanceItem.create!(
|
|
family: @family,
|
|
name: "Test Binance",
|
|
api_key: "test_key",
|
|
api_secret: "test_secret"
|
|
)
|
|
end
|
|
|
|
test "should destroy binance item" do
|
|
assert_difference("BinanceItem.count", 0) do # doesn't delete immediately
|
|
delete binance_item_url(@binance_item)
|
|
end
|
|
|
|
assert_redirected_to settings_providers_path
|
|
@binance_item.reload
|
|
assert @binance_item.scheduled_for_deletion?
|
|
end
|
|
|
|
test "should sync binance item" do
|
|
post sync_binance_item_url(@binance_item)
|
|
assert_response :redirect
|
|
end
|
|
|
|
test "should show setup_accounts page" do
|
|
get setup_accounts_binance_item_url(@binance_item)
|
|
assert_response :success
|
|
end
|
|
|
|
test "complete_account_setup creates accounts for selected binance_accounts" do
|
|
binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
assert_difference "Account.count", 1 do
|
|
post complete_account_setup_binance_item_url(@binance_item), params: {
|
|
selected_accounts: [ binance_account.id ]
|
|
}
|
|
end
|
|
|
|
assert_response :redirect
|
|
|
|
binance_account.reload
|
|
assert_not_nil binance_account.current_account
|
|
assert_equal "Crypto", binance_account.current_account.accountable_type
|
|
end
|
|
|
|
test "complete_account_setup updates sync_start_date when provided with a valid past date" do
|
|
binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
past_date = (Date.current - 7.days).to_s
|
|
|
|
post complete_account_setup_binance_item_url(@binance_item), params: {
|
|
selected_accounts: [ binance_account.id ],
|
|
sync_start_date: past_date
|
|
}
|
|
|
|
assert_response :redirect
|
|
@binance_item.reload
|
|
assert_equal Date.parse(past_date), @binance_item.sync_start_date
|
|
end
|
|
|
|
test "complete_account_setup rejects a future sync_start_date and sets flash alert" do
|
|
binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
future_date = (Date.current + 2.days).to_s
|
|
original_sync_date = @binance_item.sync_start_date
|
|
|
|
post complete_account_setup_binance_item_url(@binance_item), params: {
|
|
selected_accounts: [ binance_account.id ],
|
|
sync_start_date: future_date
|
|
}
|
|
|
|
@binance_item.reload
|
|
assert_nil @binance_item.sync_start_date
|
|
assert_equal "Sync start date must be a valid date in the past.", flash[:alert]
|
|
end
|
|
|
|
test "complete_account_setup with no selection shows message" do
|
|
@binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
assert_no_difference "Account.count" do
|
|
post complete_account_setup_binance_item_url(@binance_item), params: {
|
|
selected_accounts: []
|
|
}
|
|
end
|
|
|
|
assert_response :redirect
|
|
end
|
|
|
|
test "complete_account_setup skips already linked accounts" do
|
|
binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
# Pre-link the account
|
|
account = Account.create!(
|
|
family: @family,
|
|
name: "Existing Binance",
|
|
balance: 1000,
|
|
currency: "USD",
|
|
accountable: Crypto.create!(subtype: "exchange")
|
|
)
|
|
AccountProvider.create!(account: account, provider: binance_account)
|
|
|
|
assert_no_difference "Account.count" do
|
|
post complete_account_setup_binance_item_url(@binance_item), params: {
|
|
selected_accounts: [ binance_account.id ]
|
|
}
|
|
end
|
|
end
|
|
|
|
test "cannot access other family's binance_item" do
|
|
other_family = families(:empty)
|
|
other_item = BinanceItem.create!(
|
|
family: other_family,
|
|
name: "Other Binance",
|
|
api_key: "other_test_key",
|
|
api_secret: "other_test_secret"
|
|
)
|
|
|
|
get setup_accounts_binance_item_url(other_item)
|
|
assert_response :not_found
|
|
end
|
|
|
|
test "link_existing_account links manual account to binance_account" do
|
|
manual_account = Account.create!(
|
|
family: @family,
|
|
name: "Manual Crypto",
|
|
balance: 0,
|
|
currency: "USD",
|
|
accountable: Crypto.create!(subtype: "exchange")
|
|
)
|
|
|
|
binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
assert_difference "AccountProvider.count", 1 do
|
|
post link_existing_account_binance_items_url, params: {
|
|
account_id: manual_account.id,
|
|
binance_account_id: binance_account.id
|
|
}
|
|
end
|
|
|
|
binance_account.reload
|
|
assert_equal manual_account, binance_account.current_account
|
|
end
|
|
|
|
test "link_existing_account rejects account with existing provider" do
|
|
linked_account = Account.create!(
|
|
family: @family,
|
|
name: "Already Linked",
|
|
balance: 0,
|
|
currency: "USD",
|
|
accountable: Crypto.create!(subtype: "exchange")
|
|
)
|
|
|
|
other_binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Other Account",
|
|
account_type: "margin",
|
|
currency: "USD",
|
|
current_balance: 500.0
|
|
)
|
|
AccountProvider.create!(account: linked_account, provider: other_binance_account)
|
|
|
|
binance_account = @binance_item.binance_accounts.create!(
|
|
name: "Spot Portfolio",
|
|
account_type: "spot",
|
|
currency: "USD",
|
|
current_balance: 1000.0
|
|
)
|
|
|
|
assert_no_difference "AccountProvider.count" do
|
|
post link_existing_account_binance_items_url, params: {
|
|
account_id: linked_account.id,
|
|
binance_account_id: binance_account.id
|
|
}
|
|
end
|
|
end
|
|
|
|
test "select_existing_account renders without layout" do
|
|
account = Account.create!(
|
|
family: @family,
|
|
name: "Manual Account",
|
|
balance: 0,
|
|
currency: "USD",
|
|
accountable: Crypto.create!(subtype: "exchange")
|
|
)
|
|
|
|
get select_existing_account_binance_items_url, params: { account_id: account.id }
|
|
assert_response :success
|
|
end
|
|
end
|