pro3958 150e659846 fix(tags): return 404 for missing or cross-family tag deletion (#2703) ...

Tag::DeletionsController looked up the tag and its replacement with
find_by, so a missing id or a tag belonging to another family left
@tag nil. create then called @tag.replace_and_destroy!, raising
NoMethodError and returning a 500 instead of a 404.

Use find in set_tag and set_replacement_tag so an out-of-scope id
raises ActiveRecord::RecordNotFound, which is rendered as 404. The
replacement lookup keeps a presence guard so deleting without a
replacement still works. This mirrors Category::DeletionsController.

Fixes #2469

Co-authored-by: agentloop <agentloop@localhost>

2026-07-30 07:15:50 +02:00

..

deletions_controller.rb

fix(tags): return 404 for missing or cross-family tag deletion (#2703)

2026-07-30 07:15:50 +02:00