Files
sure/app/models/redbark_account/processor.rb
Oscar c6a240a183 feat(redbark): add australian bank sync (redbark) (#2794)
* add redbark provider integration

- per family api key provider, built like the lunchflow integration
- syncs accounts, balances and transactions from api.redbark.com
- account setup flow, settings panel, locales and routes
- tests and fixtures

* harden redbark integration based on prior provider pr feedback

- use DebugLogEntry.capture for sync/import/unlink failures
- retry 429s and 5xxs with backoff, raise on page cap instead of truncating
- keep raw response bodies out of logs and errors
- not null constraints on account columns, migration base 7.2
- persist ignored flag for skipped accounts so they stop nagging setup
- validate api key on every save, re-arm status on key rotation
- destroy aborts if unlink fails, atomic account create and link
- require_admin on mutating actions, see_other on error redirects
- single grouped query for item account counts
- i18n default connection name, blank password field value
- controller and provider tests

* fix issues found in second review sweep

- add missing syncable scope, without it every family sync raises
- kick off a sync on connection create and on key rotation
- setup dialog fetches accounts inline for fresh connections and shows api errors
- skip balance write when no balance has been fetched yet, never anchor a false zero
- exclude stale and non banking accounts from the batched balances call, per account fallback if the batch is rejected
- detect the server row ceiling and empty pages instead of silently truncating history
- user sync start date only governs the initial backfill, incremental after that
- fetch connections before the per account loop so auth errors propagate once
- drop untemplated index/show/new/edit routes and dead preload/link_accounts actions
- stable dom id on the settings panel so repeat turbo replaces keep working

* skip brokerage connections, found in live testing

- the transactions endpoint 400s for brokerage connections, they belong to /v1/trades
- only import accounts from banking and documents connections
- guard transaction fetches for any legacy linked non banking account

* address review feedback

- treat the truncation header as a pagination signal: split the date window and refetch instead of failing the account
- prune stale pending rows from the snapshot so settled pendings cant come back as duplicates
- block linking a sure account that already has another provider feed
- count setup failures separately from skips and surface an error instead of "all skipped"
- add not nulls on redbark_items name and api key
- enqueue the destroy job after the flag commits, not inside the transaction
- swap bg-gray-400 for bg-surface-inset, drop amounts from info logs, remove i18n default fallbacks
- tests for window splitting, pending pruning and encrypted payload round trip

* fix issues from convention review

- benign skips (unlinked account, blank id, unparseable rows) no longer count as failures, tracked separately so a clean batch reports success
- currency parsing goes through extract_currency so hash shaped payloads resolve instead of falling to the default
- merchant ids use truncated sha256 instead of md5
- debug log entries for import failures and account sync scheduling failures

* bound the raw transactions snapshot to the fetch window

- trim raw_transactions_payload to the current fetch window on merge, same as brex
- keep rows without a parseable date, drop settled pendings as before
- surface skipped rows in the aggregate debug log entry with imported/skipped counts
2026-07-26 07:40:25 +02:00

74 lines
2.6 KiB
Ruby

# frozen_string_literal: true
class RedbarkAccount::Processor
include RedbarkAccount::DataHelpers
attr_reader :redbark_account
def initialize(redbark_account)
@redbark_account = redbark_account
end
def process
account = redbark_account.current_account
return unless account
Rails.logger.info "RedbarkAccount::Processor - Processing account #{redbark_account.id} -> Sure account #{account.id}"
# Update account balance FIRST (before processing transactions/holdings/activities)
update_account_balance(account)
# Process transactions
transactions_count = redbark_account.raw_transactions_payload&.size || 0
Rails.logger.info "RedbarkAccount::Processor - Transactions payload has #{transactions_count} items"
if redbark_account.raw_transactions_payload.present?
Rails.logger.info "RedbarkAccount::Processor - Processing transactions..."
RedbarkAccount::Transactions::Processor.new(redbark_account).process
else
Rails.logger.warn "RedbarkAccount::Processor - No transactions payload to process"
end
# Trigger immediate UI refresh so entries appear in the activity feed
account.broadcast_sync_complete
Rails.logger.info "RedbarkAccount::Processor - Broadcast sync complete for account #{account.id}"
{ transactions_processed: transactions_count > 0 }
end
private
def update_account_balance(account)
balance = redbark_account.current_balance
# A nil current_balance means no balances fetch has succeeded for this
# account yet. Writing 0 here would clobber a healthy balance (or the
# opening balance the user typed during setup) and anchor a $0
# valuation, so leave the account untouched instead.
if balance.nil?
Rails.logger.warn "RedbarkAccount::Processor - No balance available for redbark_account #{redbark_account.id}, skipping balance update"
return
end
# Banking sign convention:
# - CreditCard and Loan accounts may need sign inversion
# Provider returns negative for positive balance, so we negate it
if account.accountable_type == "CreditCard" || account.accountable_type == "Loan"
balance = -balance
end
Rails.logger.info "RedbarkAccount::Processor - Balance update: #{balance}"
account.assign_attributes(
balance: balance,
cash_balance: balance,
currency: redbark_account.currency || account.currency
)
account.save!
# Create or update the current balance anchor valuation for linked accounts
# This is critical for reverse sync to work correctly
account.set_current_balance(balance)
end
end