mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
3658e812a8
* Add pending transaction handling and duplicate reconciliation logic - Implemented logic to exclude pending transactions from budgets and analytics calculations. - Introduced mechanisms for reconciling pending transactions with posted versions. - Added duplicate detection with support for merging or dismissing matches. - Updated transaction search filters to include a `status_filter` for pending/confirmed transactions. - Introduced UI elements for reviewing and resolving duplicates. - Enhanced `ProviderSyncSummary` with stats for reconciled and stale pending transactions. * Refactor translation handling and enhance transaction and sync logic - Moved hardcoded strings to locale files for improved translation support. - Refined styling for duplicate transaction indicators and sync summaries. - Improved logic for excluding stale pending transactions and updating timestamps on batch exclusion. - Added unique IDs to status filters for better element targeting in UI. - Optimized database queries to avoid N+1 issues in stale pending calculations. * Add sync settings and enhance pending transaction handling - Introduced a new "Sync Settings" section in hosting settings with UI to toggle inclusion of pending transactions. - Updated handling of pending transactions with improved inference logic for `posted=0` and `transacted_at` in processors. - Added priority order for pending transaction inclusion: explicit argument > environment variable > runtime configurable setting. - Refactored settings and controllers to store updated sync preferences. * Refactor sync settings and pending transaction reconciliation - Extracted logic for pending transaction reconciliation, stale exclusion, and unmatched tracking into dedicated methods for better maintainability. - Updated sync settings to infer defaults from multiple provider environment variables (`SIMPLEFIN_INCLUDE_PENDING`, `PLAID_INCLUDE_PENDING`). - Refined UI and messaging to handle multi-provider configurations in sync settings. # Conflicts: # app/models/simplefin_item/importer.rb * Debounce transaction reconciliation during imports - Added per-run reconciliation debouncing to prevent repeated scans for the same account during chunked history imports. - Trimmed size of reconciliation stats to retain recent details only. - Introduced error tracking for reconciliation steps to improve UI visibility of issues. * Apply ABS() in pending transaction queries and improve error handling - Updated pending transaction logic to use ABS() for consistent handling of negative amounts. - Adjusted amount bounds calculations to ensure accuracy for both positive and negative values. - Refined exception handling in `merge_duplicate` to log failures and update user alert. - Replaced `Date.today` with `Date.current` in tests to ensure timezone consistency. - Minor optimization to avoid COUNT queries by loading limited records directly. * Improve error handling in duplicate suggestion and dismissal logic - Added exception handling for `store_duplicate_suggestion` to log failures and prevent crashes during fuzzy/low-confidence matches. - Enhanced `dismiss_duplicate` action to handle `ActiveRecord::RecordInvalid` and display appropriate user alerts. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
202 lines
9.5 KiB
Plaintext
202 lines
9.5 KiB
Plaintext
<details class="group bg-surface rounded-lg border border-surface-inset/50">
|
|
<summary class="flex items-center justify-between gap-2 p-3 cursor-pointer">
|
|
<div class="flex items-center gap-2">
|
|
<%= helpers.icon "chevron-right", class: "group-open:transform group-open:rotate-90" %>
|
|
<span class="text-sm text-primary font-medium"><%= t("provider_sync_summary.title") %></span>
|
|
</div>
|
|
<div class="flex items-center gap-2 text-xs text-secondary">
|
|
<% if last_synced_at %>
|
|
<span><%= t("provider_sync_summary.last_sync", time_ago: last_synced_ago) %></span>
|
|
<% end %>
|
|
</div>
|
|
</summary>
|
|
|
|
<div class="p-3 text-sm text-secondary grid grid-cols-1 md:grid-cols-2 gap-3">
|
|
<%# Accounts section - always shown if we have account stats %>
|
|
<% if total_accounts > 0 || stats.key?("total_accounts") %>
|
|
<div>
|
|
<h4 class="text-primary font-medium mb-1"><%= t("provider_sync_summary.accounts.title") %></h4>
|
|
<div class="flex items-center gap-3 flex-wrap">
|
|
<span><%= t("provider_sync_summary.accounts.total", count: total_accounts) %></span>
|
|
<span><%= t("provider_sync_summary.accounts.linked", count: linked_accounts) %></span>
|
|
<span><%= t("provider_sync_summary.accounts.unlinked", count: unlinked_accounts) %></span>
|
|
<% if institutions_count.present? %>
|
|
<span><%= t("provider_sync_summary.accounts.institutions", count: institutions_count) %></span>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Transactions section - shown if provider collects transaction stats %>
|
|
<% if has_transaction_stats? %>
|
|
<div>
|
|
<h4 class="text-primary font-medium mb-1"><%= t("provider_sync_summary.transactions.title") %></h4>
|
|
<div class="flex items-center gap-3 flex-wrap">
|
|
<span><%= t("provider_sync_summary.transactions.seen", count: tx_seen) %></span>
|
|
<span><%= t("provider_sync_summary.transactions.imported", count: tx_imported) %></span>
|
|
<span><%= t("provider_sync_summary.transactions.updated", count: tx_updated) %></span>
|
|
<span><%= t("provider_sync_summary.transactions.skipped", count: tx_skipped) %></span>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Holdings section - shown if provider collects holdings stats %>
|
|
<% if has_holdings_stats? %>
|
|
<div>
|
|
<h4 class="text-primary font-medium mb-1"><%= t("provider_sync_summary.holdings.title") %></h4>
|
|
<div class="flex items-center gap-3">
|
|
<span><%= t("provider_sync_summary.holdings.#{holdings_label_key}", count: holdings_count) %></span>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Health section - always shown %>
|
|
<div>
|
|
<h4 class="text-primary font-medium mb-1"><%= t("provider_sync_summary.health.title") %></h4>
|
|
<div class="flex flex-col gap-1">
|
|
<div class="flex items-center gap-3 flex-wrap">
|
|
<% if rate_limited? %>
|
|
<span class="text-warning">
|
|
<%= t("provider_sync_summary.health.rate_limited", time_ago: rate_limited_ago || t("provider_sync_summary.health.recently")) %>
|
|
</span>
|
|
<% end %>
|
|
<% if has_errors? %>
|
|
<span class="text-destructive"><%= t("provider_sync_summary.health.errors", count: total_errors) %></span>
|
|
<% elsif import_started? %>
|
|
<span class="text-success"><%= t("provider_sync_summary.health.errors", count: 0) %></span>
|
|
<% else %>
|
|
<span><%= t("provider_sync_summary.health.errors", count: 0) %></span>
|
|
<% end %>
|
|
</div>
|
|
|
|
<%# Pending→posted reconciliation %>
|
|
<% if has_pending_reconciled? %>
|
|
<div class="mt-1">
|
|
<div class="flex items-center gap-1">
|
|
<%= helpers.icon "check-circle", size: "sm", color: "success" %>
|
|
<span class="text-success"><%= t("provider_sync_summary.health.pending_reconciled", count: pending_reconciled) %></span>
|
|
</div>
|
|
<% if pending_reconciled_details.any? %>
|
|
<details class="mt-1">
|
|
<summary class="text-xs cursor-pointer text-secondary hover:text-primary">
|
|
<%= t("provider_sync_summary.health.view_reconciled") %>
|
|
</summary>
|
|
<div class="mt-1 pl-2 border-l-2 border-surface-inset space-y-1">
|
|
<% pending_reconciled_details.each do |detail| %>
|
|
<p class="text-xs text-success">
|
|
<%= detail["account_name"] %>: <%= detail["pending_name"] %>
|
|
</p>
|
|
<% end %>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Duplicate suggestions needing review %>
|
|
<% if has_duplicate_suggestions_created? %>
|
|
<div class="mt-1">
|
|
<div class="flex items-center gap-1">
|
|
<%= helpers.icon "alert-triangle", size: "sm", color: "warning" %>
|
|
<span class="text-warning"><%= t("provider_sync_summary.health.duplicate_suggestions", count: duplicate_suggestions_created) %></span>
|
|
</div>
|
|
<% if duplicate_suggestions_details.any? %>
|
|
<details class="mt-1">
|
|
<summary class="text-xs cursor-pointer text-secondary hover:text-primary">
|
|
<%= t("provider_sync_summary.health.view_duplicate_suggestions") %>
|
|
</summary>
|
|
<div class="mt-1 pl-2 border-l-2 border-surface-inset space-y-1">
|
|
<% duplicate_suggestions_details.each do |detail| %>
|
|
<p class="text-xs text-warning">
|
|
<%= detail["account_name"] %>: <%= detail["pending_name"] %> → <%= detail["posted_name"] %>
|
|
</p>
|
|
<% end %>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Stale pending transactions (auto-excluded) %>
|
|
<% if has_stale_pending? %>
|
|
<div class="mt-1">
|
|
<div class="flex items-center gap-1">
|
|
<%= helpers.icon "clock", size: "sm", color: "warning" %>
|
|
<span class="text-warning"><%= t("provider_sync_summary.health.stale_pending", count: stale_pending_excluded) %></span>
|
|
</div>
|
|
<% if stale_pending_details.any? %>
|
|
<details class="mt-1">
|
|
<summary class="text-xs cursor-pointer text-secondary hover:text-primary">
|
|
<%= t("provider_sync_summary.health.view_stale_pending") %>
|
|
</summary>
|
|
<div class="mt-1 pl-2 border-l-2 border-surface-inset space-y-1">
|
|
<% stale_pending_details.each do |detail| %>
|
|
<p class="text-xs text-warning">
|
|
<%= detail["account_name"] %>: <%= t("provider_sync_summary.health.stale_pending_count", count: detail["count"]) %>
|
|
</p>
|
|
<% end %>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Stale unmatched pending (need manual review) %>
|
|
<% if has_stale_unmatched_pending? %>
|
|
<div class="mt-1">
|
|
<div class="flex items-center gap-1">
|
|
<%= helpers.icon "help-circle", size: "sm" %>
|
|
<span class="text-secondary"><%= t("provider_sync_summary.health.stale_unmatched", count: stale_unmatched_pending) %></span>
|
|
</div>
|
|
<% if stale_unmatched_details.any? %>
|
|
<details class="mt-1">
|
|
<summary class="text-xs cursor-pointer text-secondary hover:text-primary">
|
|
<%= t("provider_sync_summary.health.view_stale_unmatched") %>
|
|
</summary>
|
|
<div class="mt-1 pl-2 border-l-2 border-surface-inset space-y-1">
|
|
<% stale_unmatched_details.each do |detail| %>
|
|
<p class="text-xs text-secondary">
|
|
<%= detail["account_name"] %>: <%= t("provider_sync_summary.health.stale_unmatched_count", count: detail["count"]) %>
|
|
</p>
|
|
<% end %>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%# Data quality warnings %>
|
|
<% if has_data_quality_issues? %>
|
|
<div class="flex items-center gap-3 mt-1">
|
|
<% if data_warnings > 0 %>
|
|
<div class="flex items-center gap-1">
|
|
<%= helpers.icon "alert-triangle", size: "sm", color: "warning" %>
|
|
<span class="text-warning"><%= t("provider_sync_summary.health.data_warnings", count: data_warnings) %></span>
|
|
</div>
|
|
<% end %>
|
|
<% if notices > 0 %>
|
|
<div class="flex items-center gap-1">
|
|
<%= helpers.icon "info", size: "sm" %>
|
|
<span><%= t("provider_sync_summary.health.notices", count: notices) %></span>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<% if data_quality_details.any? %>
|
|
<details class="mt-2">
|
|
<summary class="text-xs cursor-pointer text-secondary hover:text-primary">
|
|
<%= t("provider_sync_summary.health.view_data_quality") %>
|
|
</summary>
|
|
<div class="mt-1 pl-2 border-l-2 border-surface-inset space-y-1">
|
|
<% data_quality_details.each do |detail| %>
|
|
<p class="text-xs <%= severity_color_class(detail["severity"]) %>"><%= detail["message"] %></p>
|
|
<% end %>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</details>
|