mirror of
https://github.com/we-promise/sure.git
synced 2026-04-17 02:54:10 +00:00
fc3ade392a
* Reindent TimeSeries classes * Fix spacing in time series tests * Remove trend tests where current is nil I think if we've gotten this far with a nil value for current, there's a data integrity problem. If we allow this, we'll have to be very defensive in our code. Best to raise and fix early. * Reindent Money class * Refactor TimeSeries artifacts * Use as_json in TimeSeries * Bring back tests for trends where current is nil * Bring back trend test * Correctly enumerate trend test * Use favorable_direction for trend_styles helper * Make trend public in TimeSeries::Value * Allow nil current values in trends I think I might've gotten it wrong before, nils might appear in trends if values are unavailable for snapshots * Clean up TimeSeries::Trend * Skip trend values same class validations if any values are nil * Refactor Money * Remove object parsing in TimeSeries::Value We're only every passing hashes
94 lines
1.9 KiB
Ruby
94 lines
1.9 KiB
Ruby
class TimeSeries::Trend
|
|
include ActiveModel::Validations
|
|
|
|
attr_reader :current, :previous
|
|
|
|
delegate :favorable_direction, to: :series
|
|
|
|
validate :values_must_be_of_same_type, :values_must_be_of_known_type
|
|
|
|
def initialize(current:, previous:, series: nil)
|
|
@current = current
|
|
@previous = previous
|
|
@series = series
|
|
|
|
validate!
|
|
end
|
|
|
|
def direction
|
|
if previous.nil? || current == previous
|
|
"flat"
|
|
elsif current && current > previous
|
|
"up"
|
|
else
|
|
"down"
|
|
end.inquiry
|
|
end
|
|
|
|
def value
|
|
if previous.nil?
|
|
current.is_a?(Money) ? Money.new(0) : 0
|
|
else
|
|
current - previous
|
|
end
|
|
end
|
|
|
|
def percent
|
|
if previous.nil?
|
|
0.0
|
|
elsif previous.zero?
|
|
Float::INFINITY
|
|
else
|
|
change = (current_amount - previous_amount).abs
|
|
base = previous_amount.abs.to_f
|
|
|
|
(change / base * 100).round(1).to_f
|
|
end
|
|
end
|
|
|
|
def as_json
|
|
{
|
|
favorable_direction: favorable_direction,
|
|
direction: direction,
|
|
value: value,
|
|
percent: percent
|
|
}.as_json
|
|
end
|
|
|
|
private
|
|
attr_reader :series
|
|
|
|
def values_must_be_of_same_type
|
|
unless current.class == previous.class || [ previous, current ].any?(&:nil?)
|
|
errors.add :current, "must be of the same type as previous"
|
|
errors.add :previous, "must be of the same type as current"
|
|
end
|
|
end
|
|
|
|
def values_must_be_of_known_type
|
|
unless current.is_a?(Money) || current.is_a?(Numeric) || current.nil?
|
|
errors.add :current, "must be of type Money, Numeric, or nil"
|
|
end
|
|
|
|
unless previous.is_a?(Money) || previous.is_a?(Numeric) || previous.nil?
|
|
errors.add :previous, "must be of type Money, Numeric, or nil"
|
|
end
|
|
end
|
|
|
|
def current_amount
|
|
extract_numeric current
|
|
end
|
|
|
|
def previous_amount
|
|
extract_numeric previous
|
|
end
|
|
|
|
def extract_numeric(obj)
|
|
if obj.is_a? Money
|
|
obj.amount
|
|
else
|
|
obj
|
|
end
|
|
end
|
|
end
|