mirror of
https://github.com/we-promise/sure.git
synced 2026-06-05 02:39:04 +00:00
d22ffe5994
Closes #2001. DS::Pill defaulted show_dot: true for both modes, so every status/category badge got a leading dot by default — redundant with the pill shape + tone + label already carrying the signal, and noisy in dense lists. More than half the marker:false callsites were already passing show_dot: false to fight it. The default is now mode-aware: marker: true keeps the dot (stage markers), marker: false (badges) is dot-less. An explicit show_dot: still wins. Only one in-tree callsite relied on the old default without an icon and wants the dot: settings/providers/_status_pill (live connection state) — pinned with show_dot: true. The enable_banking "Beta" badge loses its dot, which is the desired outcome (ref #1997). Icon-bearing transaction badges are unaffected (an icon already suppresses the dot). Left the now-redundant show_dot: false overrides in place to avoid churn and conflicts with in-flight pill-migration branches; they're harmless (explicit false == new default). Adds tests pinning the per-mode default resolution; updates the Lookbook preview to show the opt-in dot vs the clean default.
19 lines
494 B
Plaintext
19 lines
494 B
Plaintext
<%# locals: (status:) %>
|
|
<%
|
|
tone = case status.to_s.to_sym
|
|
when :ok then :success
|
|
when :warn then :warning
|
|
when :err then :error
|
|
else :neutral
|
|
end
|
|
%>
|
|
<%# Provider connection state is genuine live status — keep the indicator dot
|
|
(badge mode is dot-less by default; this is a deliberate opt-in). %>
|
|
<%= render DS::Pill.new(
|
|
label: t("settings.providers.status.#{status}"),
|
|
tone: tone,
|
|
marker: false,
|
|
show_dot: true,
|
|
size: :sm
|
|
) %>
|