mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Add mobile SSO support to sessions controller
Add /auth/mobile/:provider route and mobile_sso_start action that
captures device params in session and renders an auto-submitting POST
form to OmniAuth (required by omniauth-rails_csrf_protection).
Modify openid_connect callback to detect mobile_sso session, issue
Doorkeeper tokens via MobileDevice, and redirect to sureapp://oauth/callback
with tokens. Handles MFA users and unlinked accounts with error redirects.
Validates provider name against configured SSO providers and device info
before proceeding.
* Add SSO auth flow to Flutter service and provider
Add buildSsoUrl() and handleSsoCallback() to AuthService for
constructing the mobile SSO URL and parsing tokens from the deep
link callback.
Add startSsoLogin() and handleSsoCallback() to AuthProvider for
launching browser-based SSO and processing the redirect.
* Register deep link listener for SSO callback
Listen for sureapp://oauth/* deep links via app_links package,
handling both cold start (getInitialLink) and warm (uriLinkStream)
scenarios. Routes callbacks to AuthProvider.handleSsoCallback().
* Add Google Sign-In button to Flutter login screen
Add "or" divider and outlined Google Sign-In button that triggers
browser-based SSO via startSsoLogin('google_oauth2').
Add app_links and url_launcher dependencies to pubspec.yaml.
* Fix mobile SSO failure handling to redirect back to app
When OmniAuth fails during mobile SSO flow, redirect to
sureapp://oauth/callback with the error instead of the web login page.
Cleans up mobile_sso session data on failure.
* Address PR review feedback for mobile SSO flow
- Use strong params for device info in mobile_sso_start
- Guard against nil session data in handle_mobile_sso_callback
- Add error handling for AppLinks initialization and stream
- Handle launchUrl false return value in SSO login
- Use user-friendly error messages instead of exposing exceptions
- Reject empty token strings in SSO callback validation
* Consolidate mobile device token logic into MobileDevice model
Extract duplicated device upsert and token issuance code from
AuthController and SessionsController into MobileDevice. Add
CALLBACK_URL constant and URL builder helpers to eliminate repeated
deep-link strings. Add mobile SSO integration tests covering the
full flow, MFA rejection, unlinked accounts, and failure handling.
* Fix CI: resolve Brakeman redirect warnings and rubocop empty line
Move mobile SSO redirect into a private controller method with an
inline string literal so Brakeman can statically verify the target.
Remove unused URL builder helpers from MobileDevice. Fix extra empty
line at end of AuthController class body.
* Use authorization code exchange for mobile SSO and add signup error handling
Replace passing plaintext tokens in mobile SSO redirect URLs with a
one-time authorization code pattern. Tokens are now stored server-side
in Rails.cache (5min TTL) and exchanged via a secure POST to
/api/v1/auth/sso_exchange. Also wraps device/token creation in the
signup action with error handling and sanitizes device error messages.
* Add error handling for login device registration and blank SSO code guard
* Address PR #860 review: fix SSO race condition, add OpenAPI spec, and cleanup
- Fix race condition in sso_exchange by checking Rails.cache.delete return
value to ensure only one request can consume an authorization code
- Use strong parameters (params.require) for sso_exchange code param
- Move inline HTML from mobile_sso_start to a proper view template
- Clear stale session[:mobile_sso] flag on web login paths to prevent
abandoned mobile flows from hijacking subsequent web SSO logins
- Add OpenAPI/rswag spec for all auth API endpoints
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Fix mobile SSO test to match authorization code exchange pattern
The test was asserting tokens directly in the callback URL, but the code
uses an authorization code exchange pattern. Updated to exchange the code
via the sso_exchange API endpoint. Also swaps in a MemoryStore for this
test since the test environment uses null_store which discards writes.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Refactor mobile OAuth to use single shared application
Replace per-device Doorkeeper::Application creation with a shared
"Sure Mobile" OAuth app. Device tracking uses mobile_device_id on
access tokens instead of oauth_application_id on mobile_devices.
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
342 lines
11 KiB
Ruby
342 lines
11 KiB
Ruby
class SessionsController < ApplicationController
|
|
before_action :set_session, only: :destroy
|
|
skip_authentication only: %i[index new create openid_connect failure post_logout mobile_sso_start]
|
|
|
|
layout "auth"
|
|
|
|
# Handle GET /sessions (usually from browser back button)
|
|
def index
|
|
redirect_to new_session_path
|
|
end
|
|
|
|
def new
|
|
# Clear any stale mobile SSO session flag from an abandoned mobile flow
|
|
session.delete(:mobile_sso)
|
|
|
|
begin
|
|
demo = Rails.application.config_for(:demo)
|
|
@prefill_demo_credentials = demo_host_match?(demo)
|
|
if @prefill_demo_credentials
|
|
@email = params[:email].presence || demo["email"]
|
|
@password = params[:password].presence || demo["password"]
|
|
else
|
|
@email = params[:email]
|
|
@password = params[:password]
|
|
end
|
|
rescue RuntimeError, Errno::ENOENT, Psych::SyntaxError
|
|
# Demo config file missing or malformed - disable demo credential prefilling
|
|
@prefill_demo_credentials = false
|
|
@email = params[:email]
|
|
@password = params[:password]
|
|
end
|
|
end
|
|
|
|
def create
|
|
# Clear any stale mobile SSO session flag from an abandoned mobile flow
|
|
session.delete(:mobile_sso)
|
|
|
|
user = nil
|
|
|
|
if AuthConfig.local_login_enabled?
|
|
user = User.authenticate_by(email: params[:email], password: params[:password])
|
|
else
|
|
# Local login is disabled. Only allow attempts when an emergency super-admin
|
|
# override is enabled and the email belongs to a super-admin.
|
|
if AuthConfig.local_admin_override_enabled?
|
|
candidate = User.find_by(email: params[:email])
|
|
unless candidate&.super_admin?
|
|
redirect_to new_session_path, alert: t("sessions.create.local_login_disabled")
|
|
return
|
|
end
|
|
|
|
user = User.authenticate_by(email: params[:email], password: params[:password])
|
|
else
|
|
redirect_to new_session_path, alert: t("sessions.create.local_login_disabled")
|
|
return
|
|
end
|
|
end
|
|
|
|
if user
|
|
if user.otp_required?
|
|
log_super_admin_override_login(user)
|
|
session[:mfa_user_id] = user.id
|
|
redirect_to verify_mfa_path
|
|
else
|
|
log_super_admin_override_login(user)
|
|
@session = create_session_for(user)
|
|
redirect_to root_path
|
|
end
|
|
else
|
|
flash.now[:alert] = t(".invalid_credentials")
|
|
render :new, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
user = Current.user
|
|
id_token = session[:id_token_hint]
|
|
login_provider = session[:sso_login_provider]
|
|
|
|
# Find the identity for the provider used during login, with fallback to first if session data lost
|
|
oidc_identity = if login_provider.present?
|
|
user.oidc_identities.find_by(provider: login_provider)
|
|
else
|
|
user.oidc_identities.first
|
|
end
|
|
|
|
# Destroy local session
|
|
@session.destroy
|
|
session.delete(:id_token_hint)
|
|
session.delete(:sso_login_provider)
|
|
|
|
# Check if we should redirect to IdP for federated logout
|
|
if oidc_identity && id_token.present?
|
|
idp_logout_url = build_idp_logout_url(oidc_identity, id_token)
|
|
|
|
if idp_logout_url
|
|
SsoAuditLog.log_logout_idp!(user: user, provider: oidc_identity.provider, request: request)
|
|
redirect_to idp_logout_url, allow_other_host: true
|
|
return
|
|
end
|
|
end
|
|
|
|
# Standard local logout
|
|
SsoAuditLog.log_logout!(user: user, request: request)
|
|
redirect_to new_session_path, notice: t(".logout_successful")
|
|
end
|
|
|
|
# Handle redirect back from IdP after federated logout
|
|
def post_logout
|
|
redirect_to new_session_path, notice: t(".logout_successful")
|
|
end
|
|
|
|
def mobile_sso_start
|
|
provider = params[:provider].to_s
|
|
configured_providers = Rails.configuration.x.auth.sso_providers.map { |p| p[:name].to_s }
|
|
|
|
unless configured_providers.include?(provider)
|
|
mobile_sso_redirect(error: "invalid_provider", message: "SSO provider not configured")
|
|
return
|
|
end
|
|
|
|
device_params = params.permit(:device_id, :device_name, :device_type, :os_version, :app_version)
|
|
unless device_params[:device_id].present? && device_params[:device_name].present? && device_params[:device_type].present?
|
|
mobile_sso_redirect(error: "missing_device_info", message: "Device information is required")
|
|
return
|
|
end
|
|
|
|
session[:mobile_sso] = {
|
|
device_id: device_params[:device_id],
|
|
device_name: device_params[:device_name],
|
|
device_type: device_params[:device_type],
|
|
os_version: device_params[:os_version],
|
|
app_version: device_params[:app_version]
|
|
}
|
|
|
|
# Render auto-submitting form to POST to OmniAuth (required by omniauth-rails_csrf_protection)
|
|
@provider = provider
|
|
render layout: false
|
|
end
|
|
|
|
def openid_connect
|
|
auth = request.env["omniauth.auth"]
|
|
|
|
# Nil safety: ensure auth and required fields are present
|
|
unless auth&.provider && auth&.uid
|
|
redirect_to new_session_path, alert: t("sessions.openid_connect.failed")
|
|
return
|
|
end
|
|
|
|
# Security fix: Look up by provider + uid, not just email
|
|
oidc_identity = OidcIdentity.find_by(provider: auth.provider, uid: auth.uid)
|
|
|
|
if oidc_identity
|
|
# Existing OIDC identity found - authenticate the user
|
|
user = oidc_identity.user
|
|
oidc_identity.record_authentication!
|
|
oidc_identity.sync_user_attributes!(auth)
|
|
|
|
# Log successful SSO login
|
|
SsoAuditLog.log_login!(user: user, provider: auth.provider, request: request)
|
|
|
|
# Mobile SSO: issue Doorkeeper tokens and redirect to app
|
|
if session[:mobile_sso].present?
|
|
if user.otp_required?
|
|
session.delete(:mobile_sso)
|
|
mobile_sso_redirect(error: "mfa_not_supported", message: "MFA users should sign in with email and password")
|
|
else
|
|
handle_mobile_sso_callback(user)
|
|
end
|
|
return
|
|
end
|
|
|
|
# Store id_token and provider for RP-initiated logout
|
|
session[:id_token_hint] = auth.credentials&.id_token if auth.credentials&.id_token
|
|
session[:sso_login_provider] = auth.provider
|
|
|
|
# MFA check: If user has MFA enabled, require verification
|
|
if user.otp_required?
|
|
session[:mfa_user_id] = user.id
|
|
redirect_to verify_mfa_path
|
|
else
|
|
@session = create_session_for(user)
|
|
redirect_to root_path
|
|
end
|
|
else
|
|
# Mobile SSO with no linked identity - redirect back with error
|
|
if session[:mobile_sso].present?
|
|
session.delete(:mobile_sso)
|
|
mobile_sso_redirect(error: "account_not_linked", message: "Please link your Google account from the web app first")
|
|
return
|
|
end
|
|
|
|
# No existing OIDC identity - need to link to account
|
|
# Store auth data in session and redirect to linking page
|
|
session[:pending_oidc_auth] = {
|
|
provider: auth.provider,
|
|
uid: auth.uid,
|
|
email: auth.info&.email,
|
|
name: auth.info&.name,
|
|
first_name: auth.info&.first_name,
|
|
last_name: auth.info&.last_name
|
|
}
|
|
redirect_to link_oidc_account_path
|
|
end
|
|
end
|
|
|
|
def failure
|
|
# Sanitize reason to known values only
|
|
known_reasons = %w[sso_provider_unavailable sso_invalid_response sso_failed]
|
|
sanitized_reason = known_reasons.include?(params[:message]) ? params[:message] : "sso_failed"
|
|
|
|
# Log failed SSO attempt
|
|
SsoAuditLog.log_login_failed!(
|
|
provider: params[:strategy],
|
|
request: request,
|
|
reason: sanitized_reason
|
|
)
|
|
|
|
# Mobile SSO: redirect back to the app with error instead of web login page
|
|
if session[:mobile_sso].present?
|
|
session.delete(:mobile_sso)
|
|
mobile_sso_redirect(error: sanitized_reason, message: "SSO authentication failed")
|
|
return
|
|
end
|
|
|
|
message = case sanitized_reason
|
|
when "sso_provider_unavailable"
|
|
t("sessions.failure.sso_provider_unavailable")
|
|
when "sso_invalid_response"
|
|
t("sessions.failure.sso_invalid_response")
|
|
else
|
|
t("sessions.failure.sso_failed")
|
|
end
|
|
|
|
redirect_to new_session_path, alert: message
|
|
end
|
|
|
|
private
|
|
def handle_mobile_sso_callback(user)
|
|
device_info = session.delete(:mobile_sso)
|
|
|
|
unless device_info.present?
|
|
mobile_sso_redirect(error: "missing_session", message: "Mobile SSO session expired")
|
|
return
|
|
end
|
|
|
|
device = MobileDevice.upsert_device!(user, device_info.symbolize_keys)
|
|
token_response = device.issue_token!
|
|
|
|
# Store tokens behind a one-time authorization code instead of passing in URL
|
|
authorization_code = SecureRandom.urlsafe_base64(32)
|
|
Rails.cache.write(
|
|
"mobile_sso:#{authorization_code}",
|
|
token_response.merge(
|
|
user_id: user.id,
|
|
user_email: user.email,
|
|
user_first_name: user.first_name,
|
|
user_last_name: user.last_name
|
|
),
|
|
expires_in: 5.minutes
|
|
)
|
|
|
|
mobile_sso_redirect(code: authorization_code)
|
|
rescue ActiveRecord::RecordInvalid => e
|
|
Rails.logger.warn("[Mobile SSO] Device save failed: #{e.record.errors.full_messages.join(', ')}")
|
|
mobile_sso_redirect(error: "device_error", message: "Unable to register device")
|
|
end
|
|
|
|
def mobile_sso_redirect(params = {})
|
|
redirect_to "sureapp://oauth/callback?#{params.to_query}", allow_other_host: true
|
|
end
|
|
|
|
def set_session
|
|
@session = Current.user.sessions.find(params[:id])
|
|
end
|
|
|
|
def log_super_admin_override_login(user)
|
|
# Only log when local login is globally disabled but an emergency
|
|
# super-admin override is enabled.
|
|
return if AuthConfig.local_login_enabled?
|
|
return unless AuthConfig.local_admin_override_enabled?
|
|
return unless user&.super_admin?
|
|
|
|
Rails.logger.info("[AUTH] Super admin override login: user_id=#{user.id} email=#{user.email}")
|
|
end
|
|
|
|
def demo_host_match?(demo)
|
|
return false unless demo.present? && demo["hosts"].present?
|
|
|
|
demo["hosts"].include?(request.host)
|
|
end
|
|
|
|
def build_idp_logout_url(oidc_identity, id_token)
|
|
# Find the provider configuration using unified loader (supports both YAML and DB providers)
|
|
provider_config = ProviderLoader.load_providers.find do |p|
|
|
p[:name] == oidc_identity.provider
|
|
end
|
|
|
|
return nil unless provider_config
|
|
|
|
# For OIDC providers, fetch end_session_endpoint from discovery
|
|
if provider_config[:strategy] == "openid_connect" && provider_config[:issuer].present?
|
|
begin
|
|
discovery_url = discovery_url_for(provider_config[:issuer])
|
|
response = Faraday.get(discovery_url) do |req|
|
|
req.options.timeout = 5
|
|
req.options.open_timeout = 3
|
|
end
|
|
|
|
return nil unless response.success?
|
|
|
|
discovery = JSON.parse(response.body)
|
|
end_session_endpoint = discovery["end_session_endpoint"]
|
|
|
|
return nil unless end_session_endpoint.present?
|
|
|
|
# Build the logout URL with post_logout_redirect_uri
|
|
post_logout_redirect = "#{request.base_url}/auth/logout/callback"
|
|
params = {
|
|
id_token_hint: id_token,
|
|
post_logout_redirect_uri: post_logout_redirect
|
|
}
|
|
|
|
"#{end_session_endpoint}?#{params.to_query}"
|
|
rescue Faraday::Error, JSON::ParserError, StandardError => e
|
|
Rails.logger.warn("[SSO] Failed to fetch OIDC discovery for logout: #{e.message}")
|
|
nil
|
|
end
|
|
else
|
|
nil
|
|
end
|
|
end
|
|
|
|
def discovery_url_for(issuer)
|
|
if issuer.end_with?("/")
|
|
"#{issuer}.well-known/openid-configuration"
|
|
else
|
|
"#{issuer}/.well-known/openid-configuration"
|
|
end
|
|
end
|
|
end
|