mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
cc7d675500
Add an optional fee field (decimal, precision: 19, scale: 4) to trades. Fee is included in the total amount calculation (qty * price + fee) for both create and update flows. The fee field appears on both the create and edit forms, defaults to 0, and auto-submits like other trade fields. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
73 lines
1.9 KiB
Ruby
73 lines
1.9 KiB
Ruby
require "test_helper"
|
|
|
|
class TradeTest < ActiveSupport::TestCase
|
|
test "build_name generates buy trade name" do
|
|
name = Trade.build_name("buy", 10, "AAPL")
|
|
assert_equal "Buy 10.0 shares of AAPL", name
|
|
end
|
|
|
|
test "build_name generates sell trade name" do
|
|
name = Trade.build_name("sell", 5, "MSFT")
|
|
assert_equal "Sell 5.0 shares of MSFT", name
|
|
end
|
|
|
|
test "build_name handles absolute value for negative quantities" do
|
|
name = Trade.build_name("sell", -5, "GOOGL")
|
|
assert_equal "Sell 5.0 shares of GOOGL", name
|
|
end
|
|
|
|
test "build_name handles decimal quantities" do
|
|
name = Trade.build_name("buy", 0.25, "BTC")
|
|
assert_equal "Buy 0.25 shares of BTC", name
|
|
end
|
|
|
|
test "price scale is preserved at 10 decimal places" do
|
|
security = Security.create!(ticker: "TEST", exchange_operating_mic: "XNAS")
|
|
|
|
# up to 10 decimal places — should persist exactly
|
|
precise_price = BigDecimal("12.3456789012")
|
|
trade = Trade.create!(
|
|
security: security,
|
|
price: precise_price,
|
|
qty: 10000,
|
|
currency: "USD",
|
|
investment_activity_label: "Buy"
|
|
)
|
|
|
|
trade.reload
|
|
|
|
assert_equal precise_price, trade.price
|
|
end
|
|
|
|
test "fee defaults to 0" do
|
|
security = Security.create!(ticker: "FEETEST", exchange_operating_mic: "XNAS")
|
|
trade = Trade.create!(
|
|
security: security,
|
|
price: 100,
|
|
qty: 10,
|
|
currency: "USD",
|
|
investment_activity_label: "Buy"
|
|
)
|
|
|
|
assert_equal 0, trade.fee
|
|
end
|
|
|
|
test "price is rounded to 10 decimal places" do
|
|
security = Security.create!(ticker: "TEST", exchange_operating_mic: "XNAS")
|
|
|
|
# over 10 decimal places — will be rounded
|
|
price_with_too_many_decimals = BigDecimal("1.123456789012345")
|
|
trade = Trade.create!(
|
|
security: security,
|
|
price: price_with_too_many_decimals,
|
|
qty: 1,
|
|
currency: "USD",
|
|
investment_activity_label: "Buy"
|
|
)
|
|
|
|
trade.reload
|
|
|
|
assert_equal BigDecimal("1.1234567890"), trade.price
|
|
end
|
|
end
|