mirror of
https://github.com/we-promise/sure.git
synced 2026-07-13 05:15:19 +00:00
* feat(up): add Up Bank (AU) provider integration Adds Up Bank as a per-family, token-based bank sync provider, modelled on the existing Akahu integration. Up uses a JSON:API REST API with a personal access token (Bearer), cursor pagination via links.next, and returns both HELD (pending) and SETTLED transactions from one endpoint. New: - Provider::Up client (JSON:API unwrap, links.next pagination, retries, typed errors, /util/ping) + Provider::UpAdapter (Factory-registered, Depository + Loan). - UpItem / UpAccount models with Provided, Unlinking, Syncer, SyncCompleteEvent, Importer, Processor, Transactions::Processor, and UpEntry::Processor (amount sign flip, HELD->pending, foreignAmount FX, merchant from description, stale-pending pruning). - Family::UpConnectable, UpItemsController, routes, settings panel + connect flow views, accounts index wiring, initializer, en locale, and model tests. Core wiring: - "up" added to Transaction::PENDING_PROVIDERS, the three pending-match SQL blocks in Account::ProviderImportAdapter, Provider::Metadata::REGISTRY, ProviderMerchant/DataEnrichment source enums, ProviderConnectionStatus, settings provider panels, and financial data reset. Migration create_up_items_and_accounts must be run before use. No external API endpoints added (no OpenAPI changes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): dump up tables to schema and make since filter TZ-safe The feature commit added the up_items/up_accounts migration but never re-dumped db/schema.rb, leaving the schema version and tables stale. Add the two table definitions and foreign keys and bump the schema version so a fresh DB load matches the migration. Also format a bare Date `since` as UTC midnight instead of the server's local zone, so `filter[since]` is deterministic regardless of where the app runs (previously shifted by the local UTC offset). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): address code review feedback Behavior/correctness: - Persist skipped accounts via a new up_accounts.ignored flag and a needs_setup scope, so skipped accounts stop resurfacing as "needs setup" on every sync. Linking clears the flag. - destroy now checks unlink_all! per-account results and aborts deletion (alert) if any unlink failed, instead of swallowing failures. - render_provider_panel_error redirect uses :see_other (was an invalid 4xx redirect status). - Up provider adapter falls back to item institution name/url when institution_metadata is absent (early return previously blocked it). Resilience/security: - fetch_all_resources guards against an API repeating the same links.next cursor (Set#add?), preventing infinite pagination. - HTTP client validates absolute URLs (from links.next) against Up's HTTPS host before sending the bearer token, preventing credential leakage to untrusted hosts. Diagnostics: - Route provider sync/import failures through DebugLogEntry.capture (controller, UpItem, syncer, unlinking) with family/account context. Low-level HTTP client and currency-normalization warnings keep Rails.logger to match existing provider conventions. Data integrity: - up_accounts.name and currency are NOT NULL (align with model presence validations); account_id stays nullable (allow_nil uniqueness). Forms: - select_existing_account radio is required; controller guards a blank/ unknown up_account_id with a friendly alert instead of RecordNotFound. Tests: - Add UpAccount needs_setup scope test, pagination loop guard test, untrusted-host rejection test; tighten filter[since] assertion to the exact UTC timestamp. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): address second-round review feedback - Capture sync/import failures via DebugLogEntry so swallowed errors in account/transaction fetching and transaction processing surface in /settings/debug instead of only Rails.logger. - Gate UP_DEBUG_RAW raw payload dump to local envs to avoid leaking PII (merchant names, amounts, account IDs) in managed/production logs. - Collapse linked/unlinked/total account counts into one memoized query instead of 3 separate COUNTs per rendered item. - Rename "Set Up Up Accounts" locale title to "Link Up Accounts". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(up): add method docstrings and align failed_result keys Add docstrings to all Up provider source files (controller, models, providers, concerns) to satisfy the 80% docstring coverage threshold. Third-round review: failed_result now mirrors import's result shape (accounts_updated/created/failed, transactions_imported/failed) instead of the stale accounts_imported key, so failure results stay consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
92 lines
3.1 KiB
Ruby
92 lines
3.1 KiB
Ruby
class UpAccount::Processor
|
|
include CurrencyNormalizable
|
|
|
|
SanitizedProcessingError = Class.new(StandardError)
|
|
|
|
attr_reader :up_account
|
|
|
|
# Build a processor for the given +up_account+.
|
|
def initialize(up_account)
|
|
@up_account = up_account
|
|
end
|
|
|
|
# Sync the linked account's balance and process its transactions. No-op when
|
|
# the Up account isn't linked to a Sure account.
|
|
def process
|
|
unless up_account.current_account.present?
|
|
Rails.logger.info "UpAccount::Processor - No linked account for up_account #{up_account.id}, skipping processing"
|
|
return
|
|
end
|
|
|
|
process_account!
|
|
process_transactions
|
|
rescue StandardError => e
|
|
Rails.logger.error "UpAccount::Processor - Failed to process account up_account_id=#{up_account.id} error_class=#{e.class.name}"
|
|
report_exception(e, "account")
|
|
raise
|
|
end
|
|
|
|
private
|
|
|
|
# Update the linked Sure account's balance/currency from the Up snapshot.
|
|
def process_account!
|
|
account = up_account.current_account
|
|
balance = up_account.current_balance || 0
|
|
|
|
# Loan balances are stored as positive debt in Sure regardless of Up's sign.
|
|
balance = balance.abs if account.accountable_type == "Loan"
|
|
currency = parse_currency(up_account.currency) || account.currency || "AUD"
|
|
|
|
account.update!(
|
|
balance: balance,
|
|
cash_balance: balance,
|
|
currency: currency
|
|
)
|
|
end
|
|
|
|
# Delegate to the transactions processor, capturing and logging failures.
|
|
def process_transactions
|
|
UpAccount::Transactions::Processor.new(up_account).process
|
|
rescue => e
|
|
report_exception(e, "transactions")
|
|
Rails.logger.error "UpAccount::Processor - Failed to process transactions up_account_id=#{up_account.id} error_class=#{e.class.name}"
|
|
DebugLogEntry.capture(
|
|
category: "provider_sync_error",
|
|
level: "error",
|
|
message: "Failed to process transactions",
|
|
source: self.class.name,
|
|
provider_key: "up",
|
|
family: up_account.up_item.family,
|
|
account_provider: up_account.account_provider,
|
|
metadata: { up_account_id: up_account.id, error_class: e.class.name, error_message: e.message }
|
|
)
|
|
{ success: false, failed: 1, errors: [ { error: I18n.t("up_item.errors.account_processing_failed") } ] }
|
|
end
|
|
|
|
# Report a processing error to Sentry with a sanitized message and tags.
|
|
def report_exception(error, context)
|
|
safe_error = SanitizedProcessingError.new("Up account processing failed")
|
|
|
|
Sentry.capture_exception(safe_error) do |scope|
|
|
scope.set_tags(
|
|
up_account_id: up_account.id,
|
|
context: context,
|
|
error_class: error.class.name
|
|
)
|
|
scope.set_context(
|
|
"up_account_processor",
|
|
{
|
|
up_account_id: up_account.id,
|
|
context: context,
|
|
error_class: error.class.name
|
|
}
|
|
)
|
|
end
|
|
end
|
|
|
|
# CurrencyNormalizable hook: warn when an Up currency code is unrecognized.
|
|
def log_invalid_currency(currency_value)
|
|
Rails.logger.warn("Invalid currency code '#{currency_value}' for Up account #{up_account.id}, falling back to account currency")
|
|
end
|
|
end
|